[INFO] fetching crate scrubcsv 1.0.0... [INFO] checking scrubcsv-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scrubcsv 1.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate scrubcsv 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scrubcsv 1.0.0 [INFO] finished tweaking crates.io crate scrubcsv 1.0.0 [INFO] tweaked toml for crates.io crate scrubcsv 1.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate scrubcsv 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b36c00ab5af83477e66375817ddd90b10136ced6a98da05276cecf35e1bb239 [INFO] running `Command { std: "docker" "start" "-a" "0b36c00ab5af83477e66375817ddd90b10136ced6a98da05276cecf35e1bb239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b36c00ab5af83477e66375817ddd90b10136ced6a98da05276cecf35e1bb239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b36c00ab5af83477e66375817ddd90b10136ced6a98da05276cecf35e1bb239", kill_on_drop: false }` [INFO] [stdout] 0b36c00ab5af83477e66375817ddd90b10136ced6a98da05276cecf35e1bb239 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] caa8b5bf4ddb3b67ef40d71aabdf18ed3b6d7df054fdc3195553c3afc3e64135 [INFO] running `Command { std: "docker" "start" "-a" "caa8b5bf4ddb3b67ef40d71aabdf18ed3b6d7df054fdc3195553c3afc3e64135", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking cli_test_dir v0.1.7 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking scrubcsv v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / /// Character used to separate fields in a row (must be a single ASCII [INFO] [stdout] 60 | | /// byte, or "tab"). [INFO] [stdout] 61 | | #[structopt( [INFO] [stdout] 62 | | value_name = "CHAR", [INFO] [stdout] ... | [INFO] [stdout] 66 | | )] [INFO] [stdout] 67 | | delimiter: CharSpecifier, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / /// Make sure column names are unique, and use only lowercase letters, [INFO] [stdout] 85 | | /// numbers and underscores. "unique" (the default) will assign number [INFO] [stdout] 86 | | /// prefixes to make names unique. "stable" will use a simple, predictable [INFO] [stdout] 87 | | /// mapping, and fail with an error if the resulting names are not unique. [INFO] [stdout] 88 | | #[structopt(value_name = "CLEANER_TYPE", long = "clean-column-names")] [INFO] [stdout] 89 | | clean_column_names: Option>, [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / /// Fail if the output CSV file would contain any column names matching the [INFO] [stdout] 92 | | /// specified regular expression. [INFO] [stdout] 93 | | #[structopt(long = "reserve-column-names")] [INFO] [stdout] 94 | | reserve_column_names: Option, [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / /// Character used to quote entries. May be set to "none" to ignore all [INFO] [stdout] 107 | | /// quoting. [INFO] [stdout] 108 | | #[structopt(value_name = "CHAR", long = "quote", default_value = "\"")] [INFO] [stdout] 109 | | quote: CharSpecifier, [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:43:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn context(self, context: C) -> Result [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | self.with_context(|_| context.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 55 | fn with_context(self, build_context: F) -> Result [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | self.map_err(|err| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 61 | | Box::new(Context { [INFO] [stdout] 62 | | context: build_context(&err).into(), [INFO] [stdout] 63 | | source: Box::new(err), [INFO] [stdout] 64 | | }) as Error [INFO] [stdout] 65 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 55 | fn with_context(self, build_context: F) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | self.map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | / Box::new(Context { [INFO] [stdout] 62 | | context: build_context(&err).into(), [INFO] [stdout] 63 | | source: Box::new(err), [INFO] [stdout] 64 | | }) as Error [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / /// Character used to separate fields in a row (must be a single ASCII [INFO] [stdout] 60 | | /// byte, or "tab"). [INFO] [stdout] 61 | | #[structopt( [INFO] [stdout] 62 | | value_name = "CHAR", [INFO] [stdout] ... | [INFO] [stdout] 66 | | )] [INFO] [stdout] 67 | | delimiter: CharSpecifier, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / /// Make sure column names are unique, and use only lowercase letters, [INFO] [stdout] 85 | | /// numbers and underscores. "unique" (the default) will assign number [INFO] [stdout] 86 | | /// prefixes to make names unique. "stable" will use a simple, predictable [INFO] [stdout] 87 | | /// mapping, and fail with an error if the resulting names are not unique. [INFO] [stdout] 88 | | #[structopt(value_name = "CLEANER_TYPE", long = "clean-column-names")] [INFO] [stdout] 89 | | clean_column_names: Option>, [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / /// Fail if the output CSV file would contain any column names matching the [INFO] [stdout] 92 | | /// specified regular expression. [INFO] [stdout] 93 | | #[structopt(long = "reserve-column-names")] [INFO] [stdout] 94 | | reserve_column_names: Option, [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / /// Character used to quote entries. May be set to "none" to ignore all [INFO] [stdout] 107 | | /// quoting. [INFO] [stdout] 108 | | #[structopt(value_name = "CHAR", long = "quote", default_value = "\"")] [INFO] [stdout] 109 | | quote: CharSpecifier, [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:43:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn context(self, context: C) -> Result [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | self.with_context(|_| context.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 55 | fn with_context(self, build_context: F) -> Result [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | self.map_err(|err| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 61 | | Box::new(Context { [INFO] [stdout] 62 | | context: build_context(&err).into(), [INFO] [stdout] 63 | | source: Box::new(err), [INFO] [stdout] 64 | | }) as Error [INFO] [stdout] 65 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 55 | fn with_context(self, build_context: F) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | self.map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | / Box::new(Context { [INFO] [stdout] 62 | | context: build_context(&err).into(), [INFO] [stdout] 63 | | source: Box::new(err), [INFO] [stdout] 64 | | }) as Error [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scrubcsv` (bin "scrubcsv" test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `scrubcsv` (bin "scrubcsv") due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "caa8b5bf4ddb3b67ef40d71aabdf18ed3b6d7df054fdc3195553c3afc3e64135", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "caa8b5bf4ddb3b67ef40d71aabdf18ed3b6d7df054fdc3195553c3afc3e64135", kill_on_drop: false }` [INFO] [stdout] caa8b5bf4ddb3b67ef40d71aabdf18ed3b6d7df054fdc3195553c3afc3e64135