[INFO] fetching crate scromble 2.0.1... [INFO] checking scromble-2.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scromble 2.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate scromble 2.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scromble 2.0.1 [INFO] finished tweaking crates.io crate scromble 2.0.1 [INFO] tweaked toml for crates.io crate scromble 2.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate scromble 2.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa7337756473e6c201fc330fd26335c8b4f3251623475741a20f9e0b2db33ef4 [INFO] running `Command { std: "docker" "start" "-a" "aa7337756473e6c201fc330fd26335c8b4f3251623475741a20f9e0b2db33ef4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa7337756473e6c201fc330fd26335c8b4f3251623475741a20f9e0b2db33ef4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa7337756473e6c201fc330fd26335c8b4f3251623475741a20f9e0b2db33ef4", kill_on_drop: false }` [INFO] [stdout] aa7337756473e6c201fc330fd26335c8b4f3251623475741a20f9e0b2db33ef4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 81de10dfbd47eec45ea6fbacd44fa6293287d13ea8015cff361502a8b4258a88 [INFO] running `Command { std: "docker" "start" "-a" "81de10dfbd47eec45ea6fbacd44fa6293287d13ea8015cff361502a8b4258a88", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling syn v1.0.83 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking base64ct v1.5.3 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rpassword v5.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking block-padding v0.3.2 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.6 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking argon2 v0.4.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling zeroize_derive v1.3.3 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Checking cipher v0.4.3 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking chacha20 v0.9.0 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking scromble v2.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 65 | fn new(pass: Passphrase, salt: &Salt) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Self(Secret::new(key2b::( [INFO] [stdout] | ______________^ [INFO] [stdout] 101 | | &[0u8; 64], [INFO] [stdout] 102 | | &["root".as_bytes(), &rk_i, &rk_id], [INFO] [stdout] 103 | | ).into())) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:329:12 [INFO] [stdout] | [INFO] [stdout] 252 | fn new(mut hmac: HmacState, mut reader: Box) -> Result<(Self,u64,[u8;8]), Box> { [INFO] [stdout] | ------------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let init_hmac = hmac.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | Ok((Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 330 | | bytes_remaining: total_bytes_read, [INFO] [stdout] 331 | | block_size: block_size.try_into().unwrap(), [INFO] [stdout] 332 | | hashes_reversed: prefix_hashes, [INFO] [stdout] ... | [INFO] [stdout] 336 | | bytes_in_buffer: 0, [INFO] [stdout] 337 | | },total_bytes_read,last_8_bytes)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scromble` (bin "scromble") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 65 | fn new(pass: Passphrase, salt: &Salt) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Self(Secret::new(key2b::( [INFO] [stdout] | ______________^ [INFO] [stdout] 101 | | &[0u8; 64], [INFO] [stdout] 102 | | &["root".as_bytes(), &rk_i, &rk_id], [INFO] [stdout] 103 | | ).into())) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:329:12 [INFO] [stdout] | [INFO] [stdout] 252 | fn new(mut hmac: HmacState, mut reader: Box) -> Result<(Self,u64,[u8;8]), Box> { [INFO] [stdout] | ------------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let init_hmac = hmac.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | Ok((Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 330 | | bytes_remaining: total_bytes_read, [INFO] [stdout] 331 | | block_size: block_size.try_into().unwrap(), [INFO] [stdout] 332 | | hashes_reversed: prefix_hashes, [INFO] [stdout] ... | [INFO] [stdout] 336 | | bytes_in_buffer: 0, [INFO] [stdout] 337 | | },total_bytes_read,last_8_bytes)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scromble` (bin "scromble" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "81de10dfbd47eec45ea6fbacd44fa6293287d13ea8015cff361502a8b4258a88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81de10dfbd47eec45ea6fbacd44fa6293287d13ea8015cff361502a8b4258a88", kill_on_drop: false }` [INFO] [stdout] 81de10dfbd47eec45ea6fbacd44fa6293287d13ea8015cff361502a8b4258a88