[INFO] fetching crate scriptplan-bash 6.0.3... [INFO] checking scriptplan-bash-6.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scriptplan-bash 6.0.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate scriptplan-bash 6.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scriptplan-bash 6.0.3 [INFO] finished tweaking crates.io crate scriptplan-bash 6.0.3 [INFO] tweaked toml for crates.io crate scriptplan-bash 6.0.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ccaf52d5045a5fcf915021586d13108fde158f1496c0e72deef5e4429be1b2da [INFO] running `Command { std: "docker" "start" "-a" "ccaf52d5045a5fcf915021586d13108fde158f1496c0e72deef5e4429be1b2da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ccaf52d5045a5fcf915021586d13108fde158f1496c0e72deef5e4429be1b2da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccaf52d5045a5fcf915021586d13108fde158f1496c0e72deef5e4429be1b2da", kill_on_drop: false }` [INFO] [stdout] ccaf52d5045a5fcf915021586d13108fde158f1496c0e72deef5e4429be1b2da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f02f21aa69518c089e0a89694124c88533ae80d468f6caecc83f5a11332c5ba [INFO] running `Command { std: "docker" "start" "-a" "4f02f21aa69518c089e0a89694124c88533ae80d468f6caecc83f5a11332c5ba", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking scriptplan-lang-utils v1.0.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking shellwords v1.1.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking scriptplan-core v6.0.0 [INFO] [stderr] Checking scriptplan-bash v6.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:66 [INFO] [stdout] | [INFO] [stdout] 51 | async fn run(&self, vars: VarArgs) -> Result { [INFO] [stdout] | _________________________-------------____________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | let has_params = self.command_str.contains("$"); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | let args: VecDeque<&str> = vars.iter().map(|x| (*x).as_str()).collect(); [INFO] [stdout] ... | [INFO] [stdout] 81 | | return Ok(status); [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 102 | let first = (scripts_iter.next().unwrap())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let scripts_result: Result, _> = scripts_iter.collect(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let scripts = scripts_result?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | Ok(ScriptGroup { [INFO] [stdout] | ________^ [INFO] [stdout] 108 | | bail: false, [INFO] [stdout] 109 | | first, [INFO] [stdout] 110 | | rest: scripts, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:66 [INFO] [stdout] | [INFO] [stdout] 51 | async fn run(&self, vars: VarArgs) -> Result { [INFO] [stdout] | _________________________-------------____________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | let has_params = self.command_str.contains("$"); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | let args: VecDeque<&str> = vars.iter().map(|x| (*x).as_str()).collect(); [INFO] [stdout] ... | [INFO] [stdout] 81 | | return Ok(status); [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 102 | let first = (scripts_iter.next().unwrap())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let scripts_result: Result, _> = scripts_iter.collect(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let scripts = scripts_result?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | Ok(ScriptGroup { [INFO] [stdout] | ________^ [INFO] [stdout] 108 | | bail: false, [INFO] [stdout] 109 | | first, [INFO] [stdout] 110 | | rest: scripts, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:12 [INFO] [stdout] | [INFO] [stdout] 183 | let tasks_result: Result, _>, _> = yaml_object [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Ok(YamlScriptParser { [INFO] [stdout] | ____________^ [INFO] [stdout] 190 | | tasks: tasks_result?, [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:12 [INFO] [stdout] | [INFO] [stdout] 183 | let tasks_result: Result, _>, _> = yaml_object [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Ok(YamlScriptParser { [INFO] [stdout] | ____________^ [INFO] [stdout] 190 | | tasks: tasks_result?, [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scriptplan-bash` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scriptplan-bash` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4f02f21aa69518c089e0a89694124c88533ae80d468f6caecc83f5a11332c5ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f02f21aa69518c089e0a89694124c88533ae80d468f6caecc83f5a11332c5ba", kill_on_drop: false }` [INFO] [stdout] 4f02f21aa69518c089e0a89694124c88533ae80d468f6caecc83f5a11332c5ba