[INFO] fetching crate screeps-room-regions 0.1.3... [INFO] checking screeps-room-regions-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate screeps-room-regions 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate screeps-room-regions 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate screeps-room-regions 0.1.3 [INFO] finished tweaking crates.io crate screeps-room-regions 0.1.3 [INFO] tweaked toml for crates.io crate screeps-room-regions 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding js-sys v0.3.69 (latest: v0.3.70) [INFO] [stderr] Adding screeps-game-api v0.21.3 (latest: v0.22.0) [INFO] [stderr] Adding wasm-bindgen v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-backend v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro-support v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-shared v0.2.92 (latest: v0.2.93) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53bb9502895183c43ed078e4b4a98b6ad5124c2b45c53c68a57862b81f2949fe [INFO] running `Command { std: "docker" "start" "-a" "53bb9502895183c43ed078e4b4a98b6ad5124c2b45c53c68a57862b81f2949fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53bb9502895183c43ed078e4b4a98b6ad5124c2b45c53c68a57862b81f2949fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53bb9502895183c43ed078e4b4a98b6ad5124c2b45c53c68a57862b81f2949fe", kill_on_drop: false }` [INFO] [stdout] 53bb9502895183c43ed078e4b4a98b6ad5124c2b45c53c68a57862b81f2949fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8cef7079379890bc620479fb607763db2a617634d95c4d70686d6982957aff88 [INFO] running `Command { std: "docker" "start" "-a" "8cef7079379890bc620479fb607763db2a617634d95c4d70686d6982957aff88", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.92 [INFO] [stderr] Compiling wasm-bindgen v0.2.92 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking priority-queue v2.1.0 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.92 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling enum-iterator-derive v1.4.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.92 [INFO] [stderr] Checking enum-iterator v2.1.0 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.92 [INFO] [stderr] Checking js-sys v0.3.69 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde-wasm-bindgen v0.6.5 [INFO] [stderr] Checking screeps-game-api v0.21.3 [INFO] [stderr] Checking screeps-room-regions v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Direction::*` [INFO] [stdout] --> src/distance_transform.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | use Direction::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LocalCostMatrix` [INFO] [stdout] --> src/region_analysis/structs.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | use screeps::{RoomXY, LocalCostMatrix, LocalRoomTerrain}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Direction::*` [INFO] [stdout] --> src/region_analysis/watershed.rs:458:7 [INFO] [stdout] | [INFO] [stdout] 458 | use Direction::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Direction::*` [INFO] [stdout] --> src/distance_transform.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | use Direction::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LocalCostMatrix` [INFO] [stdout] --> src/region_analysis/structs.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | use screeps::{RoomXY, LocalCostMatrix, LocalRoomTerrain}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Direction::*` [INFO] [stdout] --> src/region_analysis/watershed.rs:458:7 [INFO] [stdout] | [INFO] [stdout] 458 | use Direction::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `idx` [INFO] [stdout] --> src/region_analysis/structs.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | for (xy, idx) in all_room_xy_and_idx() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_idx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_id` [INFO] [stdout] --> src/region_analysis/structs.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | Color::Pending(color_id) => (), // Shouldn't exist, ignore for now [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/structs.rs:155:33 [INFO] [stdout] | [INFO] [stdout] 155 | if let Some(mut edges_a) = graph.get_mut(label_a) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/structs.rs:158:33 [INFO] [stdout] | [INFO] [stdout] 158 | if let Some(mut edges_b) = graph.get_mut(label_b) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `height` [INFO] [stdout] --> src/region_analysis/watershed.rs:154:25 [INFO] [stdout] | [INFO] [stdout] 154 | while let Some((xy, height)) = queue.pop() { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xy_height` [INFO] [stdout] --> src/region_analysis/watershed.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | let xy_height = height_map.get(xy); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xy_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `group_tilemap` [INFO] [stdout] --> src/region_analysis/watershed.rs:477:13 [INFO] [stdout] | [INFO] [stdout] 477 | let mut group_tilemap: TileMap = TileMap::new(0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_tilemap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/watershed.rs:477:9 [INFO] [stdout] | [INFO] [stdout] 477 | let mut group_tilemap: TileMap = TileMap::new(0); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/watershed.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | let mut current_group_members = group_members.entry(current_group_id).or_insert(HashSet::new()); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/watershed.rs:494:13 [INFO] [stdout] | [INFO] [stdout] 494 | let mut member_set = if has_neighbor_in_current_group { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `maxima_for_xy`, `maxima_and_height_for`, `find_xy`, `same_set`, and `same_set_xy` are never used [INFO] [stdout] --> src/disjoint_tile_set.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl DisjointTileSet<'_> { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn maxima_for_xy(&mut self, xy: RoomXY) -> RoomXY { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 97 | pub fn maxima_and_height_for(&mut self, index: u16) -> (RoomXY, u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | pub fn find_xy(&mut self, xy: RoomXY) -> RoomXY { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | pub fn same_set(&mut self, a: u16, b: u16) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn same_set_xy(&mut self, a: RoomXY, b: RoomXY) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `screeps-room-regions` (lib) due to 4 previous errors; 18 warnings emitted [INFO] [stdout] warning: field `next_border_region_label_value` is never read [INFO] [stdout] --> src/region_analysis/structs.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct RoomRegionAnalysis { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | next_border_region_label_value: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RoomRegionAnalysis` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `update_height_for_xy` is never used [INFO] [stdout] --> src/region_analysis/structs.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl RoomRegionAnalysis { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 107 | fn update_height_for_xy(&mut self, xy: &RoomXY, height: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `num_colors` is never read [INFO] [stdout] --> src/region_analysis/watershed.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct RoomRegionWatershed { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | num_colors: ColorIdx, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/region_analysis/watershed.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl RoomRegionWatershed { [INFO] [stdout] | ------------------------ associated function in this implementation [INFO] [stdout] 29 | fn new(heights: DistanceTransform, local_maximas: &[RoomXY], color_map: TileMap, num_colors: ColorIdx, borders: &[RoomXY], exi... [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region_analysis/watershed.rs:57:28 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new_from_distance_transform(heights: DistanceTransform) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | // Find local maximas from the DT using union-find [INFO] [stdout] 43 | let (maxima_iter, _) = calculate_local_maxima(&heights); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let maxima_set: HashSet = maxima_iter.collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | local_maximas: maxima_set.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region_analysis/watershed.rs:401:7 [INFO] [stdout] | [INFO] [stdout] 390 | neighbors: impl Iterator [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | unique_pairs(0..adj_colors.len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region_analysis/watershed.rs:538:5 [INFO] [stdout] | [INFO] [stdout] 480 | let mut group_members: HashMap> = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | group_members.into_values().map(|s| s.iter().map(|xy| *xy).collect()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `idx` [INFO] [stdout] --> src/region_analysis/structs.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | for (xy, idx) in all_room_xy_and_idx() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_idx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_id` [INFO] [stdout] --> src/region_analysis/structs.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | Color::Pending(color_id) => (), // Shouldn't exist, ignore for now [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/structs.rs:155:33 [INFO] [stdout] | [INFO] [stdout] 155 | if let Some(mut edges_a) = graph.get_mut(label_a) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/structs.rs:158:33 [INFO] [stdout] | [INFO] [stdout] 158 | if let Some(mut edges_b) = graph.get_mut(label_b) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `height` [INFO] [stdout] --> src/region_analysis/watershed.rs:154:25 [INFO] [stdout] | [INFO] [stdout] 154 | while let Some((xy, height)) = queue.pop() { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xy_height` [INFO] [stdout] --> src/region_analysis/watershed.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | let xy_height = height_map.get(xy); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xy_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `group_tilemap` [INFO] [stdout] --> src/region_analysis/watershed.rs:477:13 [INFO] [stdout] | [INFO] [stdout] 477 | let mut group_tilemap: TileMap = TileMap::new(0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_tilemap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/watershed.rs:477:9 [INFO] [stdout] | [INFO] [stdout] 477 | let mut group_tilemap: TileMap = TileMap::new(0); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/watershed.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | let mut current_group_members = group_members.entry(current_group_id).or_insert(HashSet::new()); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/region_analysis/watershed.rs:494:13 [INFO] [stdout] | [INFO] [stdout] 494 | let mut member_set = if has_neighbor_in_current_group { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `maxima_for_xy`, `find_xy`, and `same_set_xy` are never used [INFO] [stdout] --> src/disjoint_tile_set.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl DisjointTileSet<'_> { [INFO] [stdout] | ------------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn maxima_for_xy(&mut self, xy: RoomXY) -> RoomXY { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | pub fn find_xy(&mut self, xy: RoomXY) -> RoomXY { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn same_set_xy(&mut self, a: RoomXY, b: RoomXY) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `next_border_region_label_value` is never read [INFO] [stdout] --> src/region_analysis/structs.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct RoomRegionAnalysis { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | next_border_region_label_value: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RoomRegionAnalysis` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_height_for_xy` is never used [INFO] [stdout] --> src/region_analysis/structs.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl RoomRegionAnalysis { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 107 | fn update_height_for_xy(&mut self, xy: &RoomXY, height: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `num_colors` is never read [INFO] [stdout] --> src/region_analysis/watershed.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct RoomRegionWatershed { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | num_colors: ColorIdx, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/region_analysis/watershed.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl RoomRegionWatershed { [INFO] [stdout] | ------------------------ associated function in this implementation [INFO] [stdout] 29 | fn new(heights: DistanceTransform, local_maximas: &[RoomXY], color_map: TileMap, num_colors: ColorIdx, borders: &[RoomXY], exi... [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region_analysis/watershed.rs:57:28 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new_from_distance_transform(heights: DistanceTransform) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | // Find local maximas from the DT using union-find [INFO] [stdout] 43 | let (maxima_iter, _) = calculate_local_maxima(&heights); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let maxima_set: HashSet = maxima_iter.collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | local_maximas: maxima_set.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region_analysis/watershed.rs:401:7 [INFO] [stdout] | [INFO] [stdout] 390 | neighbors: impl Iterator [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | unique_pairs(0..adj_colors.len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region_analysis/watershed.rs:538:5 [INFO] [stdout] | [INFO] [stdout] 480 | let mut group_members: HashMap> = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | group_members.into_values().map(|s| s.iter().map(|xy| *xy).collect()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `screeps-room-regions` (lib test) due to 4 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8cef7079379890bc620479fb607763db2a617634d95c4d70686d6982957aff88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cef7079379890bc620479fb607763db2a617634d95c4d70686d6982957aff88", kill_on_drop: false }` [INFO] [stdout] 8cef7079379890bc620479fb607763db2a617634d95c4d70686d6982957aff88