[INFO] fetching crate scratchstack-aspen 0.3.1... [INFO] checking scratchstack-aspen-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scratchstack-aspen 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate scratchstack-aspen 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scratchstack-aspen 0.3.1 [INFO] finished tweaking crates.io crate scratchstack-aspen 0.3.1 [INFO] tweaked toml for crates.io crate scratchstack-aspen 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 87 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive_builder v0.11.2 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.11.2 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.11.2 (latest: v0.20.1) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ce20105afd6517989c1b9a0a851d5facd51080d34402ec0bb1209c87d13f047 [INFO] running `Command { std: "docker" "start" "-a" "4ce20105afd6517989c1b9a0a851d5facd51080d34402ec0bb1209c87d13f047", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ce20105afd6517989c1b9a0a851d5facd51080d34402ec0bb1209c87d13f047", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ce20105afd6517989c1b9a0a851d5facd51080d34402ec0bb1209c87d13f047", kill_on_drop: false }` [INFO] [stdout] 4ce20105afd6517989c1b9a0a851d5facd51080d34402ec0bb1209c87d13f047 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc56ac2b47b46228b79165c0f14805b37287bce89857d5cbb34092756de44c3b [INFO] running `Command { std: "docker" "start" "-a" "cc56ac2b47b46228b79165c0f14805b37287bce89857d5cbb34092756de44c3b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.11.2 [INFO] [stderr] Compiling derive_builder_macro v0.11.2 [INFO] [stderr] Checking derive_builder v0.11.2 [INFO] [stderr] Checking scratchstack-arn v0.4.9 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking scratchstack-aws-principal v0.4.9 [INFO] [stderr] Checking scratchstack-aspen v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/condition/date.rs:88:43 [INFO] [stdout] | [INFO] [stdout] 88 | Ok(allowed) => Some(DateTime::from_utc(allowed.naive_utc(), Utc)), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/condition/date.rs:91:36 [INFO] [stdout] | [INFO] [stdout] 91 | NaiveDateTime::from_timestamp_opt(unix_seconds, 0).map(|ndt| DateTime::from_utc(ndt, Utc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/condition/date.rs:91:92 [INFO] [stdout] | [INFO] [stdout] 91 | NaiveDateTime::from_timestamp_opt(unix_seconds, 0).map(|ndt| DateTime::from_utc(ndt, Utc)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/principal/mod.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 84 | fn visit_map(self, access: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let deserializer = MapAccessDeserializer::new(access); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | match SpecifiedPrincipal::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serutil.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 235 | fn visit_map>(self, access: A) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let el = E::deserialize(MapAccessDeserializer::new(access))?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Ok(MapList { [INFO] [stdout] | ____________^ [INFO] [stdout] 238 | | elements: vec![el], [INFO] [stdout] 239 | | kind: JsonRep::Single, [INFO] [stdout] 240 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serutil.rs:253:12 [INFO] [stdout] | [INFO] [stdout] 243 | fn visit_seq>(self, mut access: A) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let mut result: Vec = match access.size_hint() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(MapList { [INFO] [stdout] | ____________^ [INFO] [stdout] 254 | | elements: result, [INFO] [stdout] 255 | | kind: JsonRep::List, [INFO] [stdout] 256 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serutil.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 323 | fn visit_seq>(self, access: A) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | let deserializer = SeqAccessDeserializer::new(access); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | match Vec::::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scratchstack-aspen` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/condition/date.rs:88:43 [INFO] [stdout] | [INFO] [stdout] 88 | Ok(allowed) => Some(DateTime::from_utc(allowed.naive_utc(), Utc)), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/condition/date.rs:91:36 [INFO] [stdout] | [INFO] [stdout] 91 | NaiveDateTime::from_timestamp_opt(unix_seconds, 0).map(|ndt| DateTime::from_utc(ndt, Utc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/condition/date.rs:91:92 [INFO] [stdout] | [INFO] [stdout] 91 | NaiveDateTime::from_timestamp_opt(unix_seconds, 0).map(|ndt| DateTime::from_utc(ndt, Utc)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/principal/mod.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 84 | fn visit_map(self, access: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let deserializer = MapAccessDeserializer::new(access); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | match SpecifiedPrincipal::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serutil.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 235 | fn visit_map>(self, access: A) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let el = E::deserialize(MapAccessDeserializer::new(access))?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Ok(MapList { [INFO] [stdout] | ____________^ [INFO] [stdout] 238 | | elements: vec![el], [INFO] [stdout] 239 | | kind: JsonRep::Single, [INFO] [stdout] 240 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serutil.rs:253:12 [INFO] [stdout] | [INFO] [stdout] 243 | fn visit_seq>(self, mut access: A) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let mut result: Vec = match access.size_hint() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(MapList { [INFO] [stdout] | ____________^ [INFO] [stdout] 254 | | elements: result, [INFO] [stdout] 255 | | kind: JsonRep::List, [INFO] [stdout] 256 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serutil.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 323 | fn visit_seq>(self, access: A) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | let deserializer = SeqAccessDeserializer::new(access); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | match Vec::::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scratchstack-aspen` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cc56ac2b47b46228b79165c0f14805b37287bce89857d5cbb34092756de44c3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc56ac2b47b46228b79165c0f14805b37287bce89857d5cbb34092756de44c3b", kill_on_drop: false }` [INFO] [stdout] cc56ac2b47b46228b79165c0f14805b37287bce89857d5cbb34092756de44c3b