[INFO] fetching crate scraper 0.20.0... [INFO] checking scraper-0.20.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scraper 0.20.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate scraper 0.20.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scraper 0.20.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate scraper 0.20.0 [INFO] tweaked toml for crates.io crate scraper 0.20.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate scraper 0.20.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee1a7660261be8762975983d48310f02762eaf4b75358aa0390bbbd47f203e75 [INFO] running `Command { std: "docker" "start" "-a" "ee1a7660261be8762975983d48310f02762eaf4b75358aa0390bbbd47f203e75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee1a7660261be8762975983d48310f02762eaf4b75358aa0390bbbd47f203e75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee1a7660261be8762975983d48310f02762eaf4b75358aa0390bbbd47f203e75", kill_on_drop: false }` [INFO] [stdout] ee1a7660261be8762975983d48310f02762eaf4b75358aa0390bbbd47f203e75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eca7ffa37dd17701a36bdd2a0adcf2e8f029345b8885c4c366540e32007f547b [INFO] running `Command { std: "docker" "start" "-a" "eca7ffa37dd17701a36bdd2a0adcf2e8f029345b8885c4c366540e32007f547b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking dtoa-short v0.3.4 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Compiling markup5ever v0.12.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking scraper v0.20.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 80 | fn create_comment(&mut self, text: StrTendril) -> Self::Handle { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.tree [INFO] [stdout] 82 | .orphan(Node::Comment(Comment { [INFO] [stdout] | _____________________^ [INFO] [stdout] 83 | | comment: make_tendril(text), [INFO] [stdout] 84 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 224 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let target = make_tendril(target); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let data = make_tendril(data); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | self.tree [INFO] [stdout] 228 | .orphan(Node::ProcessingInstruction(ProcessingInstruction { [INFO] [stdout] | _____________________^ [INFO] [stdout] 229 | | target, [INFO] [stdout] 230 | | data, [INFO] [stdout] 231 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new(name: QualName, attributes: Vec) -> Self { [INFO] [stdout] | -------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let attrs = attributes [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | id: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new(name: QualName, attributes: Vec) -> Self { [INFO] [stdout] | -------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let attrs = attributes [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | classes: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:243:31 [INFO] [stdout] | [INFO] [stdout] 243 | .map(|a| (a.name, crate::tendril_util::make(a.value))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selector.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | let mut parser_input = cssparser::ParserInput::new(selectors); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / SelectorList::parse(&Parser, &mut parser, ParseRelative::No) [INFO] [stdout] 33 | | .map(|selectors| Self { selectors }) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scraper` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 80 | fn create_comment(&mut self, text: StrTendril) -> Self::Handle { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.tree [INFO] [stdout] 82 | .orphan(Node::Comment(Comment { [INFO] [stdout] | _____________________^ [INFO] [stdout] 83 | | comment: make_tendril(text), [INFO] [stdout] 84 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 224 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let target = make_tendril(target); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let data = make_tendril(data); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | self.tree [INFO] [stdout] 228 | .orphan(Node::ProcessingInstruction(ProcessingInstruction { [INFO] [stdout] | _____________________^ [INFO] [stdout] 229 | | target, [INFO] [stdout] 230 | | data, [INFO] [stdout] 231 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new(name: QualName, attributes: Vec) -> Self { [INFO] [stdout] | -------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let attrs = attributes [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | id: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new(name: QualName, attributes: Vec) -> Self { [INFO] [stdout] | -------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let attrs = attributes [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | classes: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:243:31 [INFO] [stdout] | [INFO] [stdout] 243 | .map(|a| (a.name, crate::tendril_util::make(a.value))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selectable.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 51 | fn select_one<'a, S>(selectable: S, selector: &Selector) -> Option> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | selectable.select(selector).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selector.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | let mut parser_input = cssparser::ParserInput::new(selectors); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / SelectorList::parse(&Parser, &mut parser, ParseRelative::No) [INFO] [stdout] 33 | | .map(|selectors| Self { selectors }) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scraper` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "eca7ffa37dd17701a36bdd2a0adcf2e8f029345b8885c4c366540e32007f547b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eca7ffa37dd17701a36bdd2a0adcf2e8f029345b8885c4c366540e32007f547b", kill_on_drop: false }` [INFO] [stdout] eca7ffa37dd17701a36bdd2a0adcf2e8f029345b8885c4c366540e32007f547b