[INFO] fetching crate scoundrel 0.9.1... [INFO] checking scoundrel-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scoundrel 0.9.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate scoundrel 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scoundrel 0.9.1 [INFO] finished tweaking crates.io crate scoundrel 0.9.1 [INFO] tweaked toml for crates.io crate scoundrel 0.9.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 194 packages to latest compatible versions [INFO] [stderr] Adding atomicwrites v0.3.1 (latest: v0.4.3) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bincode v0.8.0 (latest: v1.3.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding core-foundation v0.6.4 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation-sys v0.6.2 (latest: v0.8.7) [INFO] [stderr] Adding crc v1.8.1 (latest: v3.2.1) [INFO] [stderr] Adding deflate v0.8.6 (latest: v1.0.0) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding fsevent v0.4.0 (latest: v2.1.2) [INFO] [stderr] Adding fsevent-sys v2.0.1 (latest: v4.1.0) [INFO] [stderr] Adding gif v0.11.4 (latest: v0.13.1) [INFO] [stderr] Adding gilrs v0.8.2 (latest: v0.10.9) [INFO] [stderr] Adding gilrs-core v0.3.2 (latest: v0.5.15) [INFO] [stderr] Adding glfw v0.44.0 (latest: v0.58.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding image v0.23.14 (latest: v0.25.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding inotify v0.7.1 (latest: v0.11.0) [INFO] [stderr] Adding io-kit-sys v0.1.0 (latest: v0.4.1) [INFO] [stderr] Adding jpeg-decoder v0.1.22 (latest: v0.3.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mach v0.2.3 (latest: v0.3.2) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding memmap v0.5.2 (latest: v0.7.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.3.7 (latest: v0.8.0) [INFO] [stderr] Adding miniz_oxide v0.4.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding multimap v0.8.3 (latest: v0.10.0) [INFO] [stderr] Adding nalgebra v0.30.1 (latest: v0.33.0) [INFO] [stderr] Adding nalgebra-glm v0.16.0 (latest: v0.19.0) [INFO] [stderr] Adding nix v0.23.2 (latest: v0.29.0) [INFO] [stderr] Adding notify v4.0.18 (latest: v6.1.1) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding page_size v0.4.2 (latest: v0.6.0) [INFO] [stderr] Adding png v0.16.8 (latest: v0.17.13) [INFO] [stderr] Adding priority-queue v1.4.0 (latest: v2.1.0) [INFO] [stderr] Adding raw-window-handle v0.4.3 (latest: v0.6.2) [INFO] [stderr] Adding robust v0.2.3 (latest: v1.1.0) [INFO] [stderr] Adding ron v0.7.1 (latest: v0.8.1) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding same-file v0.1.3 (latest: v1.0.6) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding sha1 v0.6.1 (latest: v0.10.6) [INFO] [stderr] Adding simba v0.7.3 (latest: v0.9.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding tiff v0.6.1 (latest: v0.9.1) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding walkdir v1.0.7 (latest: v2.5.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26d6e27928d7e484aedce51c787d2f4a2ea3443784db7a8fcfc4cea3759c1075 [INFO] running `Command { std: "docker" "start" "-a" "26d6e27928d7e484aedce51c787d2f4a2ea3443784db7a8fcfc4cea3759c1075", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26d6e27928d7e484aedce51c787d2f4a2ea3443784db7a8fcfc4cea3759c1075", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26d6e27928d7e484aedce51c787d2f4a2ea3443784db7a8fcfc4cea3759c1075", kill_on_drop: false }` [INFO] [stdout] 26d6e27928d7e484aedce51c787d2f4a2ea3443784db7a8fcfc4cea3759c1075 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a93482f4f2cd76fb8cb03dfccf26209e84556d46fdbff09f0aea2d3094b02db0 [INFO] running `Command { std: "docker" "start" "-a" "a93482f4f2cd76fb8cb03dfccf26209e84556d46fdbff09f0aea2d3094b02db0", kill_on_drop: false }` [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling xml-rs v0.8.21 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling gl_loader v0.1.2 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling priority-queue v1.4.0 [INFO] [stderr] Checking same-file v0.1.3 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking atomicwrites v0.3.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking walkdir v1.0.7 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking memmap v0.5.2 [INFO] [stderr] Checking robust v0.2.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking notify v4.0.18 [INFO] [stderr] Checking caves v0.2.1 [INFO] [stderr] Checking glfw v0.44.0 [INFO] [stderr] Checking delaunator v1.0.2 [INFO] [stderr] Checking sparseset v1.0.1 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking bresenham v0.1.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking bitmaps v3.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking multimap v0.8.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking filearco v0.1.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling scoundrel-macro v0.4.0 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking gilrs-core v0.3.2 [INFO] [stderr] Checking gilrs v0.8.2 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Checking nalgebra-glm v0.16.0 [INFO] [stderr] Checking scoundrel v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `destroy::*` [INFO] [stdout] --> src/core/world/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use destroy::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `destroy::*` [INFO] [stdout] --> src/core/world/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use destroy::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `petgraph::*` [INFO] [stdout] --> src/map/graph_internals/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub use petgraph::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `petgraph::*` [INFO] [stdout] --> src/map/graph_internals/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub use petgraph::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/engine.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | let mut live_sync = &mut engine_state.live_sync_state; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/engine.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | let mut live_sync = &mut engine_state.live_sync_state; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/input.rs:483:19 [INFO] [stdout] | [INFO] [stdout] 481 | pub fn build(self) -> AcceptingContext { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | AcceptingContext { [INFO] [stdout] 483 | mask: self.context.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | for e in world.components.get(&tid).unwrap().first() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 32 | while let Some(e) = world.components.get(&tid).unwrap().first() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 32 | if let Some(e) = world.components.get(&tid).unwrap().first() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 63 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 63 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 63 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:98:26 [INFO] [stdout] | [INFO] [stdout] 98 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 98 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:138:26 [INFO] [stdout] | [INFO] [stdout] 138 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 138 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 138 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:228:26 [INFO] [stdout] | [INFO] [stdout] 228 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 228 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 228 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/stencil.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn line, Q: Into>(p: P, q: Q) -> StencilImpl { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Box::new(Stencil::Line { [INFO] [stdout] | ______________^ [INFO] [stdout] 57 | | a: p.into(), [INFO] [stdout] 58 | | b: q.into(), [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/stencil.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn circle>(c: P, r: u16) -> StencilImpl { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Box::new(Stencil::Circle { [INFO] [stdout] | ______________^ [INFO] [stdout] 72 | | center: c.into(), [INFO] [stdout] 73 | | radius: r, [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/input.rs:483:19 [INFO] [stdout] | [INFO] [stdout] 481 | pub fn build(self) -> AcceptingContext { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | AcceptingContext { [INFO] [stdout] 483 | mask: self.context.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | for e in world.components.get(&tid).unwrap().first() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 32 | while let Some(e) = world.components.get(&tid).unwrap().first() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 32 | if let Some(e) = world.components.get(&tid).unwrap().first() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 63 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 63 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 63 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:98:26 [INFO] [stdout] | [INFO] [stdout] 98 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 98 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:138:26 [INFO] [stdout] | [INFO] [stdout] 138 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 138 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 138 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 181 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 181 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/core/world/unique.rs:228:26 [INFO] [stdout] | [INFO] [stdout] 228 | for index in indexed_entities.first_index() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 228 | while let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 228 | if let Some(index) = indexed_entities.first_index() { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/stencil.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn line, Q: Into>(p: P, q: Q) -> StencilImpl { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Box::new(Stencil::Line { [INFO] [stdout] | ______________^ [INFO] [stdout] 57 | | a: p.into(), [INFO] [stdout] 58 | | b: q.into(), [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/stencil.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn circle>(c: P, r: u16) -> StencilImpl { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Box::new(Stencil::Circle { [INFO] [stdout] | ______________^ [INFO] [stdout] 72 | | center: c.into(), [INFO] [stdout] 73 | | radius: r, [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scoundrel` (lib) due to 4 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scoundrel` (lib test) due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a93482f4f2cd76fb8cb03dfccf26209e84556d46fdbff09f0aea2d3094b02db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a93482f4f2cd76fb8cb03dfccf26209e84556d46fdbff09f0aea2d3094b02db0", kill_on_drop: false }` [INFO] [stdout] a93482f4f2cd76fb8cb03dfccf26209e84556d46fdbff09f0aea2d3094b02db0