[INFO] fetching crate scm-bisect 0.2.0... [INFO] checking scm-bisect-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scm-bisect 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate scm-bisect 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scm-bisect 0.2.0 [INFO] finished tweaking crates.io crate scm-bisect 0.2.0 [INFO] tweaked toml for crates.io crate scm-bisect 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate scm-bisect 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a2c2d04843a0b661ad6d63f39fdc7509798e0148e81ecdf59010f88514c1d0b [INFO] running `Command { std: "docker" "start" "-a" "6a2c2d04843a0b661ad6d63f39fdc7509798e0148e81ecdf59010f88514c1d0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a2c2d04843a0b661ad6d63f39fdc7509798e0148e81ecdf59010f88514c1d0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a2c2d04843a0b661ad6d63f39fdc7509798e0148e81ecdf59010f88514c1d0b", kill_on_drop: false }` [INFO] [stdout] 6a2c2d04843a0b661ad6d63f39fdc7509798e0148e81ecdf59010f88514c1d0b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dadbffa056f69548f692e214973eb0a31e467ca46cf723cb6bad34ae1408669a [INFO] running `Command { std: "docker" "start" "-a" "dadbffa056f69548f692e214973eb0a31e467ca46cf723cb6bad34ae1408669a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking insta v1.38.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking scm-bisect v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/basic.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|node| Ok((node.clone(), self.ancestors(node.clone())?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/basic.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|node| Ok((node.clone(), self.descendants(node.clone())?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn into_eager(self) -> Result, TError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let LazySolution { [INFO] [stdout] 148 | bounds, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | next_to_search, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | } = self; [INFO] [stdout] 151 | Ok(EagerSolution { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | bounds, [INFO] [stdout] 153 | | next_to_search: next_to_search.collect::, TError>>()?, [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scm-bisect` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/basic.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|node| Ok((node.clone(), self.ancestors(node.clone())?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/basic.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|node| Ok((node.clone(), self.descendants(node.clone())?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn into_eager(self) -> Result, TError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let LazySolution { [INFO] [stdout] 148 | bounds, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | next_to_search, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | } = self; [INFO] [stdout] 151 | Ok(EagerSolution { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | bounds, [INFO] [stdout] 153 | | next_to_search: next_to_search.collect::, TError>>()?, [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 69 | let nodes = prop::collection::hash_set( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / nodes [INFO] [stdout] 74 | | .prop_flat_map(|nodes| { [INFO] [stdout] 75 | | let num_nodes = nodes.len(); [INFO] [stdout] 76 | | let nodes_kv = nodes [INFO] [stdout] ... | [INFO] [stdout] 94 | | graph [INFO] [stdout] 95 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 74 | .prop_flat_map(|nodes| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let num_nodes = nodes.len(); [INFO] [stdout] 76 | let nodes_kv = nodes [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let graph = TestGraph { nodes: nodes_kv }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let lineages = prop::collection::vec( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | (Just(graph), lineages) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|node| (node, HashSet::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 96 | .prop_flat_map(|graph| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let failure_nodes = prop::sample::subsequence(nodes, 0..num_nodes); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | (Just(graph), failure_nodes) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scm-bisect` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "dadbffa056f69548f692e214973eb0a31e467ca46cf723cb6bad34ae1408669a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dadbffa056f69548f692e214973eb0a31e467ca46cf723cb6bad34ae1408669a", kill_on_drop: false }` [INFO] [stdout] dadbffa056f69548f692e214973eb0a31e467ca46cf723cb6bad34ae1408669a