[INFO] fetching crate scgi 0.3.4... [INFO] checking scgi-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scgi 0.3.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate scgi 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scgi 0.3.4 [INFO] finished tweaking crates.io crate scgi 0.3.4 [INFO] tweaked toml for crates.io crate scgi 0.3.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26fc22e49b757e7e302e8f0a090151ed6f3f5247d2e3e3cd91cb25b22f92aba8 [INFO] running `Command { std: "docker" "start" "-a" "26fc22e49b757e7e302e8f0a090151ed6f3f5247d2e3e3cd91cb25b22f92aba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26fc22e49b757e7e302e8f0a090151ed6f3f5247d2e3e3cd91cb25b22f92aba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26fc22e49b757e7e302e8f0a090151ed6f3f5247d2e3e3cd91cb25b22f92aba8", kill_on_drop: false }` [INFO] [stdout] 26fc22e49b757e7e302e8f0a090151ed6f3f5247d2e3e3cd91cb25b22f92aba8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b121fe2291324777b6bcdf9bdd78e52c2a404e897140715321a09f39288c02d3 [INFO] running `Command { std: "docker" "start" "-a" "b121fe2291324777b6bcdf9bdd78e52c2a404e897140715321a09f39288c02d3", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking scgi v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 52 | let got = try! (stream.read (&mut ch_buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | let length_str = try! (from_utf8 (&length_string[0 .. length_string_len])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let length: usize = try! (length_str.parse().map_err (|_| BadLength)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | let got = try! (stream.read (&mut headers_buf[total .. length])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:68:10 [INFO] [stdout] | [INFO] [stdout] 68 | if try! (stream.read (&mut ch_buf)) != 1 || ch_buf[0] != b',' {return Err (WrongLength (length_str.to_string()))} [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | return Err (WrongLength (try! (from_utf8 (&length_string[0 .. length_string_len])).to_string())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let zero1 = try! (raw_headers[pos..].iter().position (|&ch|ch == 0) .ok_or (WrongHeaders)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | let header_name = try! (from_utf8 (&raw_headers[pos .. pos + zero1])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | let zero2 = try! (raw_headers[pos..].iter().position (|&ch|ch == 0) .ok_or (WrongHeaders)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:86:24 [INFO] [stdout] | [INFO] [stdout] 86 | let header_value = try! (from_utf8 (&raw_headers[pos .. pos + zero2])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:96:3 [INFO] [stdout] | [INFO] [stdout] 96 | try! (parse (raw_headers, |name,value| {headers_map.insert (name.to_string(), value.to_string());})); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 103 | try! (parse (raw_headers, |name,value| {headers_map.insert (name, value);})); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/scgi.rs:48:55 [INFO] [stdout] | [INFO] [stdout] 48 | let mut length_string: [u8; 10] = unsafe {std::mem::uninitialized()}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 52 | let got = try! (stream.read (&mut ch_buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | let length_str = try! (from_utf8 (&length_string[0 .. length_string_len])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let length: usize = try! (length_str.parse().map_err (|_| BadLength)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | let got = try! (stream.read (&mut headers_buf[total .. length])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:68:10 [INFO] [stdout] | [INFO] [stdout] 68 | if try! (stream.read (&mut ch_buf)) != 1 || ch_buf[0] != b',' {return Err (WrongLength (length_str.to_string()))} [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | return Err (WrongLength (try! (from_utf8 (&length_string[0 .. length_string_len])).to_string())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let zero1 = try! (raw_headers[pos..].iter().position (|&ch|ch == 0) .ok_or (WrongHeaders)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | let header_name = try! (from_utf8 (&raw_headers[pos .. pos + zero1])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | let zero2 = try! (raw_headers[pos..].iter().position (|&ch|ch == 0) .ok_or (WrongHeaders)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:86:24 [INFO] [stdout] | [INFO] [stdout] 86 | let header_value = try! (from_utf8 (&raw_headers[pos .. pos + zero2])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:96:3 [INFO] [stdout] | [INFO] [stdout] 96 | try! (parse (raw_headers, |name,value| {headers_map.insert (name.to_string(), value.to_string());})); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/scgi.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 103 | try! (parse (raw_headers, |name,value| {headers_map.insert (name, value);})); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/scgi.rs:48:55 [INFO] [stdout] | [INFO] [stdout] 48 | let mut length_string: [u8; 10] = unsafe {std::mem::uninitialized()}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::thread::sleep_ms`: replaced by `std::thread::sleep` [INFO] [stdout] --> src/scgi.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 110 | std::thread::sleep_ms (10); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scgi.rs:75:7 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn read_headers (stream: S) -> Result<(Vec, BufStream), ScgiError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut stream = BufStream::new (stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok ((raw_headers, stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 10]` does not permit being left uninitialized [INFO] [stdout] --> src/scgi.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | let mut length_string: [u8; 10] = unsafe {std::mem::uninitialized()}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scgi` (lib) due to 2 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scgi.rs:75:7 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn read_headers (stream: S) -> Result<(Vec, BufStream), ScgiError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut stream = BufStream::new (stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok ((raw_headers, stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 10]` does not permit being left uninitialized [INFO] [stdout] --> src/scgi.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | let mut length_string: [u8; 10] = unsafe {std::mem::uninitialized()}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scgi` (lib test) due to 2 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b121fe2291324777b6bcdf9bdd78e52c2a404e897140715321a09f39288c02d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b121fe2291324777b6bcdf9bdd78e52c2a404e897140715321a09f39288c02d3", kill_on_drop: false }` [INFO] [stdout] b121fe2291324777b6bcdf9bdd78e52c2a404e897140715321a09f39288c02d3