[INFO] fetching crate scf-core 1.2.1... [INFO] checking scf-core-1.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scf-core 1.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate scf-core 1.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scf-core 1.2.1 [INFO] finished tweaking crates.io crate scf-core 1.2.1 [INFO] tweaked toml for crates.io crate scf-core 1.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding arc-swap v0.3.11 (latest: v1.7.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding log4rs v0.8.3 (latest: v1.3.0) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding serde-value v0.5.3 (latest: v0.7.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding thread-id v3.3.0 (latest: v4.2.2) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64f4dcc4fb92bba1e9158049e949f29e80ff50fb018e4380e8ab035a6071b771 [INFO] running `Command { std: "docker" "start" "-a" "64f4dcc4fb92bba1e9158049e949f29e80ff50fb018e4380e8ab035a6071b771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64f4dcc4fb92bba1e9158049e949f29e80ff50fb018e4380e8ab035a6071b771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64f4dcc4fb92bba1e9158049e949f29e80ff50fb018e4380e8ab035a6071b771", kill_on_drop: false }` [INFO] [stdout] 64f4dcc4fb92bba1e9158049e949f29e80ff50fb018e4380e8ab035a6071b771 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37b09ddb395beaf56b8a8d42bacf0c0bf5ee0ca0a523d6ccc8ec0467403a50aa [INFO] running `Command { std: "docker" "start" "-a" "37b09ddb395beaf56b8a8d42bacf0c0bf5ee0ca0a523d6ccc8ec0467403a50aa", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking lang_extension v1.0.1 [INFO] [stderr] Checking arc-swap v0.3.11 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking scf-core v1.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:198:25 [INFO] [stdout] | [INFO] [stdout] 198 | |v|Box::new(v.as_ref().as_any_ref().downcast_ref::().unwrap().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:288:18 [INFO] [stdout] | [INFO] [stdout] 277 | let raw = DefaultRawPropertyConfig { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | Box::new(DefaultPropertyConfig { [INFO] [stdout] | __________________^ [INFO] [stdout] 289 | | raw: Arc::new(RawPropertyConfig::clone_boxed(&raw)), [INFO] [stdout] 290 | | k: PhantomData::, [INFO] [stdout] 291 | | v: PhantomData:: [INFO] [stdout] 292 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:437:25 [INFO] [stdout] | [INFO] [stdout] 437 | |v|Box::new(v.as_ref().as_any_ref().downcast_ref::().unwrap().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:514:23 [INFO] [stdout] | [INFO] [stdout] 512 | let property = DefaultProperty::::from_raw(event.get_raw_property()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | DefaultPropertyChangeEvent { [INFO] [stdout] 514 | property: Arc::new(Box::new(property)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:515:18 [INFO] [stdout] | [INFO] [stdout] 512 | let property = DefaultProperty::::from_raw(event.get_raw_property()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | raw: Arc::new(RawPropertyChangeEvent::clone_boxed(event)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:570:25 [INFO] [stdout] | [INFO] [stdout] 570 | |v|Box::new(v.as_ref().as_any_ref().downcast_ref::().unwrap().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/property/default/mod.rs:575:25 [INFO] [stdout] | [INFO] [stdout] 575 | |v|Box::new(v.as_ref().as_any_ref().downcast_ref::().unwrap().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/default/mod.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(config: Box, property_provider: PropertyProvider) [INFO] [stdout] | ------------------------------------------ ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/default/mod.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(config: Box, property_provider: PropertyProvider) [INFO] [stdout] | ------------------------------------------ ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | property_provider: Arc::new(RwLock::new(property_provider)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/default/mod.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(config: Box, property_provider: PropertyProvider) [INFO] [stdout] | ------------------------------------------ ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | listeners: Arc::new(RwLock::new(Vec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/default/mod.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 99 | let lock = self.property_provider.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | match lock(config.get_raw_key().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager/default/mod.rs:175:68 [INFO] [stdout] | [INFO] [stdout] 175 | new_value.as_ref().map(|v|ImmutableValue::wrap(v.clone())), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/manager/default/mod.rs:177:53 [INFO] [stdout] | [INFO] [stdout] 177 | let raw_property = property.as_ref().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn property::RawProperty` does not implement `Clone`, so calling `clone` on `&dyn property::RawProperty` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/facade/mod.rs:25:18 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new_manager(config: Box) -> Box { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Box::new(DefaultConfigurationManager::new(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/facade/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new(manager: Box) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | manager: Arc::new(manager) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/facade/mod.rs:57:36 [INFO] [stdout] | [INFO] [stdout] 56 | let p = self.manager.get_property(RawPropertyConfig::as_trait_ref(config)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Property::::to_boxed(DefaultProperty::from_raw(p.as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scf-core` (lib) due to 16 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "37b09ddb395beaf56b8a8d42bacf0c0bf5ee0ca0a523d6ccc8ec0467403a50aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37b09ddb395beaf56b8a8d42bacf0c0bf5ee0ca0a523d6ccc8ec0467403a50aa", kill_on_drop: false }` [INFO] [stdout] 37b09ddb395beaf56b8a8d42bacf0c0bf5ee0ca0a523d6ccc8ec0467403a50aa