[INFO] fetching crate scdlang 0.2.1... [INFO] checking scdlang-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scdlang 0.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate scdlang 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scdlang 0.2.1 [INFO] finished tweaking crates.io crate scdlang 0.2.1 [INFO] tweaked toml for crates.io crate scdlang 0.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0cc96da7e4e65d7d5c66159859af7c73ed11fba7623c9a9e98f723adeb38c5c6 [INFO] running `Command { std: "docker" "start" "-a" "0cc96da7e4e65d7d5c66159859af7c73ed11fba7623c9a9e98f723adeb38c5c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0cc96da7e4e65d7d5c66159859af7c73ed11fba7623c9a9e98f723adeb38c5c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cc96da7e4e65d7d5c66159859af7c73ed11fba7623c9a9e98f723adeb38c5c6", kill_on_drop: false }` [INFO] [stdout] 0cc96da7e4e65d7d5c66159859af7c73ed11fba7623c9a9e98f723adeb38c5c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1eb9582d4547d5e9b8eb4cbbaaa70635e035f9ae820385e71eacf104e68924ac [INFO] running `Command { std: "docker" "start" "-a" "1eb9582d4547d5e9b8eb4cbbaaa70635e035f9ae820385e71eacf104e68924ac", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking scdlang v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Error as ScdlError` and `PestError` [INFO] [stdout] --> src/semantics/transition/helper.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | error::{Error as ScdlError, PestError}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error::ErrorVariant` and `iterators::Pair` [INFO] [stdout] --> src/semantics/transition/helper.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pest::{error::ErrorVariant, iterators::Pair, Span}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/semantics/transition/helper.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | pub use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/semantics/kind.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 39 | fn action(&self) -> Option<&Any/*👈TBD*/> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | fn action(&self) -> Option<&dyn Any/*👈TBD*/> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/semantics/kind.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | fn action(&self) -> Option<&Any /*👈TBD*/>; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | fn action(&self) -> Option<&dyn Any /*👈TBD*/>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Error as ScdlError` and `PestError` [INFO] [stdout] --> src/semantics/transition/helper.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | error::{Error as ScdlError, PestError}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error::ErrorVariant` and `iterators::Pair` [INFO] [stdout] --> src/semantics/transition/helper.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pest::{error::ErrorVariant, iterators::Pair, Span}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryInto` [INFO] [stdout] --> src/semantics/transition/helper.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | pub use std::convert::TryInto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/semantics/kind.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 39 | fn action(&self) -> Option<&Any/*👈TBD*/> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | fn action(&self) -> Option<&dyn Any/*👈TBD*/> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/semantics/kind.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | fn action(&self) -> Option<&Any /*👈TBD*/>; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | fn action(&self) -> Option<&dyn Any /*👈TBD*/>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/parser.rs:24:42 [INFO] [stdout] | [INFO] [stdout] 24 | parse(source).map_err(|e| Error::Parse(self.reformat_error(source, e).into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/parser.rs:29:42 [INFO] [stdout] | [INFO] [stdout] 29 | parse(source).map_err(|e| Error::Parse(e.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/parser.rs:36:3 [INFO] [stdout] | [INFO] [stdout] 36 | / pairs [INFO] [stdout] 37 | | .filter(|pair| if let Rule::EOI = pair.as_rule() { false } else { true }) [INFO] [stdout] 38 | | .map(|pair| { [INFO] [stdout] 39 | | Ok(match pair.as_rule() { [INFO] [stdout] ... | [INFO] [stdout] 49 | | Ok(kinds) => Either::Right(kinds.into_iter().map(Ok)), [INFO] [stdout] 50 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cache_list = [ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(Shrink(cache_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scdlang` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/parser.rs:24:42 [INFO] [stdout] | [INFO] [stdout] 24 | parse(source).map_err(|e| Error::Parse(self.reformat_error(source, e).into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/parser.rs:29:42 [INFO] [stdout] | [INFO] [stdout] 29 | parse(source).map_err(|e| Error::Parse(e.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/parser.rs:36:3 [INFO] [stdout] | [INFO] [stdout] 36 | / pairs [INFO] [stdout] 37 | | .filter(|pair| if let Rule::EOI = pair.as_rule() { false } else { true }) [INFO] [stdout] 38 | | .map(|pair| { [INFO] [stdout] 39 | | Ok(match pair.as_rule() { [INFO] [stdout] ... | [INFO] [stdout] 49 | | Ok(kinds) => Either::Right(kinds.into_iter().map(Ok)), [INFO] [stdout] 50 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cache_list = [ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(Shrink(cache_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:4 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn expression<'a>(text: &'a str, callback: impl Fn(Pair<'a, Rule>) -> Result) -> Result { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | cache::clear()?.shrink() [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:4 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn from<'a>(text: &'a str, callback: impl FnOnce(Pairs<'a, Rule>) -> Result) -> Result { [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | cache::clear()?.shrink() [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scdlang` (lib test) due to 7 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1eb9582d4547d5e9b8eb4cbbaaa70635e035f9ae820385e71eacf104e68924ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1eb9582d4547d5e9b8eb4cbbaaa70635e035f9ae820385e71eacf104e68924ac", kill_on_drop: false }` [INFO] [stdout] 1eb9582d4547d5e9b8eb4cbbaaa70635e035f9ae820385e71eacf104e68924ac