[INFO] fetching crate scatternotes 0.1.4... [INFO] checking scatternotes-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scatternotes 0.1.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate scatternotes 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scatternotes 0.1.4 [INFO] finished tweaking crates.io crate scatternotes 0.1.4 [INFO] tweaked toml for crates.io crate scatternotes 0.1.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate scatternotes 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 234c6d871baa1504573aa2de7d2e6daba01ecd6c0ef611a249556a671906c6a6 [INFO] running `Command { std: "docker" "start" "-a" "234c6d871baa1504573aa2de7d2e6daba01ecd6c0ef611a249556a671906c6a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "234c6d871baa1504573aa2de7d2e6daba01ecd6c0ef611a249556a671906c6a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "234c6d871baa1504573aa2de7d2e6daba01ecd6c0ef611a249556a671906c6a6", kill_on_drop: false }` [INFO] [stdout] 234c6d871baa1504573aa2de7d2e6daba01ecd6c0ef611a249556a671906c6a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 982c1c1ae469c3cb4395fb4ac37e1df55f70ec8047662988cb71ca2086a6397c [INFO] running `Command { std: "docker" "start" "-a" "982c1c1ae469c3cb4395fb4ac37e1df55f70ec8047662988cb71ca2086a6397c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking termfmt v0.2.5 [INFO] [stderr] Checking scatternotes v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `nom::branch::alt` [INFO] [stdout] --> src/note/repository.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom::branch::alt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `tag` and `take_until` [INFO] [stdout] --> src/note/repository.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | use nom::bytes::complete::{tag, take_until}; [INFO] [stdout] | ^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `alphanumeric1` and `space0` [INFO] [stdout] --> src/note/repository.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::character::complete::{alphanumeric1, char, space0, u16, u8}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `delimited` and `tuple` [INFO] [stdout] --> src/note/repository.rs:11:21 [INFO] [stdout] | [INFO] [stdout] 11 | use nom::sequence::{delimited, tuple}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `termh2` [INFO] [stdout] --> src/output.rs:5:57 [INFO] [stdout] | [INFO] [stdout] 5 | use termfmt::{termarrow, termarrow_fg, termerr, termh1, termh2, terminfo, BundleFmt, Fg, TermFmt}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::branch::alt` [INFO] [stdout] --> src/note/repository.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use nom::branch::alt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `tag` and `take_until` [INFO] [stdout] --> src/note/repository.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | use nom::bytes::complete::{tag, take_until}; [INFO] [stdout] | ^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `alphanumeric1` and `space0` [INFO] [stdout] --> src/note/repository.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::character::complete::{alphanumeric1, char, space0, u16, u8}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `delimited` and `tuple` [INFO] [stdout] --> src/note/repository.rs:11:21 [INFO] [stdout] | [INFO] [stdout] 11 | use nom::sequence::{delimited, tuple}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `termh2` [INFO] [stdout] --> src/output.rs:5:57 [INFO] [stdout] | [INFO] [stdout] 5 | use termfmt::{termarrow, termarrow_fg, termerr, termh1, termh2, terminfo, BundleFmt, Fg, TermFmt}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> src/note/repository.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `command` [INFO] [stdout] --> src/commands/carlender.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn run(command: &ArgMatches, term: &Term) {} [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/commands/carlender.rs:11:34 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn run(command: &ArgMatches, term: &Term) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `note` [INFO] [stdout] --> src/commands/clean.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let note = if !is_valid_note_name(note.path()) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_note` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> src/note/repository.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `command` [INFO] [stdout] --> src/commands/carlender.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn run(command: &ArgMatches, term: &Term) {} [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/commands/carlender.rs:11:34 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn run(command: &ArgMatches, term: &Term) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `note` [INFO] [stdout] --> src/commands/clean.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let note = if !is_valid_note_name(note.path()) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_note` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/todo.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 15 | let arg_done = Arg::new("done") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | / Command::new(NAME) [INFO] [stdout] 20 | | .subcommand_required(true) [INFO] [stdout] 21 | | .subcommands([ [INFO] [stdout] 22 | | Command::new(CMD_LIST) [INFO] [stdout] ... | [INFO] [stdout] 32 | | .about("search through your todos"), [INFO] [stdout] 33 | | ]) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|content| serde_json::from_str(&content).expect("Could not parse you config.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note/repository.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | .filter_map(|path| Note::load(path).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/todo.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 15 | let arg_done = Arg::new("done") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | / Command::new(NAME) [INFO] [stdout] 20 | | .subcommand_required(true) [INFO] [stdout] 21 | | .subcommands([ [INFO] [stdout] 22 | | Command::new(CMD_LIST) [INFO] [stdout] ... | [INFO] [stdout] 32 | | .about("search through your todos"), [INFO] [stdout] 33 | | ]) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|content| serde_json::from_str(&content).expect("Could not parse you config.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note/repository.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | .filter_map(|path| Note::load(path).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scatternotes` (bin "scatternotes" test) due to 4 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `scatternotes` (bin "scatternotes") due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "982c1c1ae469c3cb4395fb4ac37e1df55f70ec8047662988cb71ca2086a6397c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "982c1c1ae469c3cb4395fb4ac37e1df55f70ec8047662988cb71ca2086a6397c", kill_on_drop: false }` [INFO] [stdout] 982c1c1ae469c3cb4395fb4ac37e1df55f70ec8047662988cb71ca2086a6397c