[INFO] fetching crate scalpel-bin 2.0.0... [INFO] checking scalpel-bin-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scalpel-bin 2.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate scalpel-bin 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scalpel-bin 2.0.0 [INFO] finished tweaking crates.io crate scalpel-bin 2.0.0 [INFO] tweaked toml for crates.io crate scalpel-bin 2.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 79 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding common_failures v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding env_logger v0.5.13 (latest: v0.11.5) [INFO] [stderr] Adding fixedbitset v0.2.0 (latest: v0.5.7) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding ihex v1.1.2 (latest: v3.0.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memchr v1.0.2 (latest: v2.7.4) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nom v3.2.1 (latest: v7.1.3) [INFO] [stderr] Adding parking_lot v0.10.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.7.3 (latest: v0.9.10) [INFO] [stderr] Adding petgraph v0.5.1 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: bin.0.plugin [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 318bea9b8168ec36bd8f5918ef6f6419d417431ae56d11b1823ddd639ab4c9c5 [INFO] running `Command { std: "docker" "start" "-a" "318bea9b8168ec36bd8f5918ef6f6419d417431ae56d11b1823ddd639ab4c9c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "318bea9b8168ec36bd8f5918ef6f6419d417431ae56d11b1823ddd639ab4c9c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "318bea9b8168ec36bd8f5918ef6f6419d417431ae56d11b1823ddd639ab4c9c5", kill_on_drop: false }` [INFO] [stdout] 318bea9b8168ec36bd8f5918ef6f6419d417431ae56d11b1823ddd639ab4c9c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6db57e0041146ddf7a2dfbf3f91dcedf30267769ee67e1d58e8f5ae8b1eb19d [INFO] running `Command { std: "docker" "start" "-a" "a6db57e0041146ddf7a2dfbf3f91dcedf30267769ee67e1d58e8f5ae8b1eb19d", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: bin.0.plugin [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking ihex v1.1.2 [INFO] [stderr] Checking tree_magic v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking common_failures v0.1.1 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking docopt v1.1.1 [INFO] [stderr] Checking scalpel-bin v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intelhex.rs:16:26 [INFO] [stdout] | [INFO] [stdout] 16 | ihex_reader.try_fold(BytesMut::new(), |bin, record| hex_record2bin(record?, bin)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 132 | mut files: Vec<(AnnotatedBytes, ByteOffset)>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / files [INFO] [stdout] 138 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops.rs:139:23 [INFO] [stdout] | [INFO] [stdout] 132 | mut files: Vec<(AnnotatedBytes, ByteOffset)>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | .try_fold(AnnotatedBytes::new(), |mut stitched, (elem, offset)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scalpel-bin` (bin "scalpel") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_offset.rs:299:23 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|bo| ByteOffset::from_str(bo).expect("Failed to parse")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_offset.rs:316:23 [INFO] [stdout] | [INFO] [stdout] 316 | .map(|bo| ByteOffset::from_str(bo).expect("failed to parse")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intelhex.rs:16:26 [INFO] [stdout] | [INFO] [stdout] 16 | ihex_reader.try_fold(BytesMut::new(), |bin, record| hex_record2bin(record?, bin)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 132 | mut files: Vec<(AnnotatedBytes, ByteOffset)>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / files [INFO] [stdout] 138 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops.rs:139:23 [INFO] [stdout] | [INFO] [stdout] 132 | mut files: Vec<(AnnotatedBytes, ByteOffset)>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | .try_fold(AnnotatedBytes::new(), |mut stitched, (elem, offset)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:208:27 [INFO] [stdout] | [INFO] [stdout] 208 | .and_then(|d| d.argv(argv().into_iter()).deserialize()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:235:27 [INFO] [stdout] | [INFO] [stdout] 235 | .and_then(|d| d.argv(argv().into_iter()).deserialize()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:262:45 [INFO] [stdout] | [INFO] [stdout] 262 | Docopt::new(USAGE).and_then(|d| d.argv(argv().into_iter()).deserialize()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:280:45 [INFO] [stdout] | [INFO] [stdout] 280 | Docopt::new(USAGE).and_then(|d| d.argv(argv().into_iter()).deserialize()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:292:27 [INFO] [stdout] | [INFO] [stdout] 292 | .and_then(|d| d.argv(argv().into_iter()).deserialize()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:328:27 [INFO] [stdout] | [INFO] [stdout] 328 | .and_then(|d| d.argv(argv().into_iter()).deserialize()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scalpel-bin` (bin "scalpel" test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "a6db57e0041146ddf7a2dfbf3f91dcedf30267769ee67e1d58e8f5ae8b1eb19d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6db57e0041146ddf7a2dfbf3f91dcedf30267769ee67e1d58e8f5ae8b1eb19d", kill_on_drop: false }` [INFO] [stdout] a6db57e0041146ddf7a2dfbf3f91dcedf30267769ee67e1d58e8f5ae8b1eb19d