[INFO] fetching crate scalpel 0.4.1... [INFO] checking scalpel-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scalpel 0.4.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate scalpel 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scalpel 0.4.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate scalpel 0.4.1 [INFO] tweaked toml for crates.io crate scalpel 0.4.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate scalpel 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c85a18d37706c1ead5d2da44d84e4ac5a11c25ac83aac0a8425bf135bf150fd0 [INFO] running `Command { std: "docker" "start" "-a" "c85a18d37706c1ead5d2da44d84e4ac5a11c25ac83aac0a8425bf135bf150fd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c85a18d37706c1ead5d2da44d84e4ac5a11c25ac83aac0a8425bf135bf150fd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c85a18d37706c1ead5d2da44d84e4ac5a11c25ac83aac0a8425bf135bf150fd0", kill_on_drop: false }` [INFO] [stdout] c85a18d37706c1ead5d2da44d84e4ac5a11c25ac83aac0a8425bf135bf150fd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ea5ec2758ff5f74e2c333ad8d247d77ce928163f6f74332e9706558e05fcb3f8 [INFO] running `Command { std: "docker" "start" "-a" "ea5ec2758ff5f74e2c333ad8d247d77ce928163f6f74332e9706558e05fcb3f8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.110 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling libloading v0.6.7 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking clap_builder v4.4.12 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling scalpel v0.4.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling pcap v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.12 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking erased-serde v0.4.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/tcp.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 98 | let map = get_tcp_apps_map().read().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok((app.map(|creator_fn| creator_fn()), TCP_BASE_HEADER_LENGTH)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/udp.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 82 | let map = get_udp_apps_map().read().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok((app.map(|creator_fn| creator_fn()), UDP_HEADER_LENGTH)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/sctp.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 223 | let map = get_sctp_protocols_map().read().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let layer_creator = map.get(&payload_proto); [INFO] [stdout] 225 | let payload = match layer_creator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let mut layer = creator_fn(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 241 | | SCTPChunk::Data { [INFO] [stdout] 242 | | header, [INFO] [stdout] 243 | | tsn, [INFO] [stdout] ... | [INFO] [stdout] 249 | | chunk_len, [INFO] [stdout] 250 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/sctp.rs:263:12 [INFO] [stdout] | [INFO] [stdout] 260 | let payload = ChunkPayload::UnProcessed(payload); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | Ok((SCTPChunk::Unsupported { header, payload }, chunk_len)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/sctp.rs:298:12 [INFO] [stdout] | [INFO] [stdout] 286 | let mut chunks = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | Ok((None, bytes.len())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scalpel` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ea5ec2758ff5f74e2c333ad8d247d77ce928163f6f74332e9706558e05fcb3f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea5ec2758ff5f74e2c333ad8d247d77ce928163f6f74332e9706558e05fcb3f8", kill_on_drop: false }` [INFO] [stdout] ea5ec2758ff5f74e2c333ad8d247d77ce928163f6f74332e9706558e05fcb3f8