[INFO] fetching crate sc-state-db 0.36.0... [INFO] checking sc-state-db-0.36.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sc-state-db 0.36.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sc-state-db 0.36.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sc-state-db 0.36.0 [INFO] finished tweaking crates.io crate sc-state-db 0.36.0 [INFO] tweaked toml for crates.io crate sc-state-db 0.36.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 251 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitcoin-internals v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.13.0 (latest: v0.14.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding constcat v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding matchers v0.0.1 (latest: v0.2.0) [INFO] [stderr] Adding polkavm-common v0.9.0 (latest: v0.11.0) [INFO] [stderr] Adding polkavm-derive v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding polkavm-derive-impl v0.9.0 (latest: v0.11.0) [INFO] [stderr] Adding polkavm-derive-impl-macro v0.9.0 (latest: v0.11.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding secp256k1 v0.28.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (latest: v0.10.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tracing-log v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (latest: v0.3.18) [INFO] [stderr] Adding unicode-normalization v0.1.22 (latest: v0.1.23) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d968d1b2e7364c59f541e8ae0dc9dbe99fe78e11628e55a9b76000ef24db9e03 [INFO] running `Command { std: "docker" "start" "-a" "d968d1b2e7364c59f541e8ae0dc9dbe99fe78e11628e55a9b76000ef24db9e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d968d1b2e7364c59f541e8ae0dc9dbe99fe78e11628e55a9b76000ef24db9e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d968d1b2e7364c59f541e8ae0dc9dbe99fe78e11628e55a9b76000ef24db9e03", kill_on_drop: false }` [INFO] [stdout] d968d1b2e7364c59f541e8ae0dc9dbe99fe78e11628e55a9b76000ef24db9e03 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a9760b3b5e54aef4bc3ecafe5ddc4eed431b477798735c3bc416313953145c0 [INFO] running `Command { std: "docker" "start" "-a" "5a9760b3b5e54aef4bc3ecafe5ddc4eed431b477798735c3bc416313953145c0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling libsecp256k1-core v0.3.0 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling expander v2.2.1 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Compiling file-guard v0.2.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling blake2 v0.10.6 [INFO] [stderr] Compiling libsecp256k1-gen-ecmult v0.3.0 [INFO] [stderr] Compiling libsecp256k1-gen-genmult v0.3.0 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling libsecp256k1 v0.7.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Checking environmental v1.1.4 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking sp-std v14.0.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking hash256-std-hasher v0.15.2 [INFO] [stderr] Checking array-bytes v6.2.3 [INFO] [stderr] Checking hash-db v0.16.0 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling parity-scale-codec-derive v3.6.12 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling scale-info-derive v2.11.3 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling sp-debug-derive v14.0.0 [INFO] [stderr] Checking fixed-hash v0.8.0 [INFO] [stderr] Checking getrandom_or_panic v0.0.3 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Compiling dyn-clonable-impl v0.9.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling sp-runtime-interface-proc-macro v18.0.0 [INFO] [stderr] Checking dyn-clonable v0.9.0 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking ed25519-zebra v4.0.3 [INFO] [stderr] Checking sp-crypto-hashing v0.1.0 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Checking impl-serde v0.4.0 [INFO] [stderr] Checking serdect v0.2.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking parity-bip39 v2.0.1 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking schnorrkel v0.11.4 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking substrate-bip39 v0.6.0 [INFO] [stderr] Checking scale-info v2.11.3 [INFO] [stderr] Checking impl-codec v0.6.0 [INFO] [stderr] Checking sp-storage v21.0.0 [INFO] [stderr] Checking sp-wasm-interface v21.0.0 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking sp-externalities v0.29.0 [INFO] [stderr] Compiling ss58-registry v1.47.0 [INFO] [stderr] Checking primitive-types v0.12.2 [INFO] [stderr] Checking bounded-collections v0.2.0 [INFO] [stderr] Checking sp-tracing v17.0.0 [INFO] [stderr] Checking sp-runtime-interface v28.0.0 [INFO] [stderr] Checking sp-core v34.0.0 [INFO] [stderr] Checking sc-state-db v0.36.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:3 [INFO] [stdout] | [INFO] [stdout] 164 | fn from(x: codec::Error) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | StateDbError::Decoding(x).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:6 [INFO] [stdout] | [INFO] [stdout] 314 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let non_canonical: NonCanonicalOverlay = NonCanonicalOverlay::new(&db)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let pruning: Option> = match mode { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | Ok(StateDbSync { mode, non_canonical, pruning, pinned: Default::default(), ref_counting }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:575:6 [INFO] [stdout] | [INFO] [stdout] 535 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | let db_init_commit_set = if should_init { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | let mut cs: CommitSet = Default::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | let state_db = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | Ok((db_init_commit_set, state_db)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:590:3 [INFO] [stdout] | [INFO] [stdout] 588 | changeset: ChangeSet, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | ) -> Result, Error> { [INFO] [stdout] 590 | self.db.write().insert_block(hash, number, parent_hash, changeset) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:604:3 [INFO] [stdout] | [INFO] [stdout] 600 | pub fn pin(&self, hash: &BlockHash, number: u64, hint: F) -> Result<(), PinError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 604 | self.db.write().pin(hash, number, hint) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/noncanonical.rs:233:6 [INFO] [stdout] | [INFO] [stdout] 175 | let last_canonicalized = last_canonicalized [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut levels = VecDeque::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let mut parents = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let mut values = HashMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(NonCanonicalOverlay { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | last_canonicalized, [INFO] [stdout] 235 | | levels, [INFO] [stdout] 236 | | parents, [INFO] [stdout] ... | [INFO] [stdout] 240 | | pinned_canonincalized: Default::default(), [INFO] [stdout] 241 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pruning.rs:126:6 [INFO] [stdout] | [INFO] [stdout] 112 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut cache = VecDeque::with_capacity(cache_capacity); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(DeathRowQueue::DbBacked { db, cache, cache_capacity, last }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pruning.rs:350:6 [INFO] [stdout] | [INFO] [stdout] 305 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | let queue = if count_insertions { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Ok(RefWindow { queue, base }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sc-state-db` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:3 [INFO] [stdout] | [INFO] [stdout] 164 | fn from(x: codec::Error) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | StateDbError::Decoding(x).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:6 [INFO] [stdout] | [INFO] [stdout] 314 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let non_canonical: NonCanonicalOverlay = NonCanonicalOverlay::new(&db)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let pruning: Option> = match mode { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | Ok(StateDbSync { mode, non_canonical, pruning, pinned: Default::default(), ref_counting }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:575:6 [INFO] [stdout] | [INFO] [stdout] 535 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | let db_init_commit_set = if should_init { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | let mut cs: CommitSet = Default::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | let state_db = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | Ok((db_init_commit_set, state_db)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:590:3 [INFO] [stdout] | [INFO] [stdout] 588 | changeset: ChangeSet, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | ) -> Result, Error> { [INFO] [stdout] 590 | self.db.write().insert_block(hash, number, parent_hash, changeset) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:604:3 [INFO] [stdout] | [INFO] [stdout] 600 | pub fn pin(&self, hash: &BlockHash, number: u64, hint: F) -> Result<(), PinError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 604 | self.db.write().pin(hash, number, hint) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/noncanonical.rs:233:6 [INFO] [stdout] | [INFO] [stdout] 175 | let last_canonicalized = last_canonicalized [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut levels = VecDeque::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let mut parents = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let mut values = HashMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(NonCanonicalOverlay { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | last_canonicalized, [INFO] [stdout] 235 | | levels, [INFO] [stdout] 236 | | parents, [INFO] [stdout] ... | [INFO] [stdout] 240 | | pinned_canonincalized: Default::default(), [INFO] [stdout] 241 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pruning.rs:126:6 [INFO] [stdout] | [INFO] [stdout] 112 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut cache = VecDeque::with_capacity(cache_capacity); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(DeathRowQueue::DbBacked { db, cache, cache_capacity, last }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pruning.rs:350:6 [INFO] [stdout] | [INFO] [stdout] 305 | db: D, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | let queue = if count_insertions { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Ok(RefWindow { queue, base }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sc-state-db` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "5a9760b3b5e54aef4bc3ecafe5ddc4eed431b477798735c3bc416313953145c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a9760b3b5e54aef4bc3ecafe5ddc4eed431b477798735c3bc416313953145c0", kill_on_drop: false }` [INFO] [stdout] 5a9760b3b5e54aef4bc3ecafe5ddc4eed431b477798735c3bc416313953145c0