[INFO] fetching crate sc-rpc-server 16.0.2... [INFO] checking sc-rpc-server-16.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sc-rpc-server 16.0.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate sc-rpc-server 16.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sc-rpc-server 16.0.2 [INFO] finished tweaking crates.io crate sc-rpc-server 16.0.2 [INFO] tweaked toml for crates.io crate sc-rpc-server 16.0.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 146 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding jsonrpsee v0.23.2 (latest: v0.24.3) [INFO] [stderr] Adding jsonrpsee-core v0.23.2 (latest: v0.24.3) [INFO] [stderr] Adding jsonrpsee-server v0.23.2 (latest: v0.24.3) [INFO] [stderr] Adding jsonrpsee-types v0.23.2 (latest: v0.24.3) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nonempty v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f6d7e7ae6c45fa71fd38902019ba0a2e7baa87d00de42990bb4c4b74d22d7fd [INFO] running `Command { std: "docker" "start" "-a" "6f6d7e7ae6c45fa71fd38902019ba0a2e7baa87d00de42990bb4c4b74d22d7fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f6d7e7ae6c45fa71fd38902019ba0a2e7baa87d00de42990bb4c4b74d22d7fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f6d7e7ae6c45fa71fd38902019ba0a2e7baa87d00de42990bb4c4b74d22d7fd", kill_on_drop: false }` [INFO] [stdout] 6f6d7e7ae6c45fa71fd38902019ba0a2e7baa87d00de42990bb4c4b74d22d7fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 514668a465a2443b9187ad673282dd983ea7977c2b93743f1ff70f91ca022a6f [INFO] running `Command { std: "docker" "start" "-a" "514668a465a2443b9187ad673282dd983ea7977c2b93743f1ff70f91ca022a6f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking route-recognizer v0.3.1 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking nonempty v0.7.0 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking ip_network v0.4.1 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking forwarded-header-value v0.1.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking soketto v0.8.0 [INFO] [stderr] Checking governor v0.6.3 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking beef v0.5.2 [INFO] [stderr] Checking substrate-prometheus-endpoint v0.17.0 [INFO] [stderr] Checking jsonrpsee-types v0.23.2 [INFO] [stderr] Checking jsonrpsee-core v0.23.2 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking jsonrpsee-server v0.23.2 [INFO] [stderr] Checking jsonrpsee v0.23.2 [INFO] [stderr] Checking sc-rpc-server v16.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:6 [INFO] [stdout] | [INFO] [stdout] 184 | let svc = tower::service_fn(move |req: http::Request| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | tokio_handle, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let middleware_layer = match (metrics, rate_limit_cfg) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let mut svc = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | svc.call(req).await.map_err(|e| BoxError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn with_rate_limit_per_minute(self, n: NonZeroU32) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { rate_limit: Some(RateLimit::per_minute(n)), metrics: self.metrics } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:65:48 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn with_metrics(self, metrics: Metrics) -> Self { [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Self { rate_limit: self.rate_limit, metrics: Some(metrics) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:83:37 [INFO] [stdout] | [INFO] [stdout] 82 | fn layer(&self, service: S) -> Self::Service { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Middleware { service, rate_limit: self.rate_limit.clone(), metrics: self.metrics.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:83:71 [INFO] [stdout] | [INFO] [stdout] 82 | fn layer(&self, service: S) -> Self::Service { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Middleware { service, rate_limit: self.rate_limit.clone(), metrics: self.metrics.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:115:3 [INFO] [stdout] | [INFO] [stdout] 106 | fn call(&self, req: Request<'a>) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let service = self.service.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let rate_limit = self.rate_limit.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let metrics = self.metrics.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | [INFO] [stdout] 115 | / async move { [INFO] [stdout] 116 | | let mut is_rate_limited = false; [INFO] [stdout] 117 | | [INFO] [stdout] 118 | | if let Some(limit) = rate_limit.as_ref() { [INFO] [stdout] ... | [INFO] [stdout] 142 | | rp [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:149:28 [INFO] [stdout] | [INFO] [stdout] 148 | fn reject_too_many_calls(id: Id) -> MethodResponse { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | MethodResponse::error(id, ErrorObject::owned(-32999, "RPC rate limit exceeded", None::<()>)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/node_health.rs:100:3 [INFO] [stdout] | [INFO] [stdout] 78 | fn call(&mut self, req: http::Request) -> Self::Future { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut req = req.map(|body| HttpBody::new(body)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let fut = self.0.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | / async move { [INFO] [stdout] 101 | | let res = fut.await.map_err(|err| err.into())?; [INFO] [stdout] 102 | | [INFO] [stdout] 103 | | Ok(match maybe_intercept { [INFO] [stdout] ... | [INFO] [stdout] 119 | | }) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/node_health.rs:103:7 [INFO] [stdout] | [INFO] [stdout] 98 | let fut = self.0.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let res = fut.await.map_err(|err| err.into())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | [INFO] [stdout] 103 | Ok(match maybe_intercept { [INFO] [stdout] | ________________^ [INFO] [stdout] 104 | | InterceptRequest::Deny => [INFO] [stdout] 105 | | http_response(StatusCode::METHOD_NOT_ALLOWED, HttpBody::empty()), [INFO] [stdout] 106 | | InterceptRequest::No => res, [INFO] [stdout] ... | [INFO] [stdout] 118 | | }, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/node_health.rs:144:2 [INFO] [stdout] | [INFO] [stdout] 143 | fn http_response>(status_code: StatusCode, body: S) -> HttpResponse { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | / HttpResponse::builder() [INFO] [stdout] 145 | | .status(status_code) [INFO] [stdout] 146 | | .header(http::header::CONTENT_TYPE, HEADER_VALUE_JSON) [INFO] [stdout] 147 | | .body(body.into()) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/rate_limit.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 41 | let clock = QuantaClock::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | inner: Arc::new(RateLimitInner::direct_with_clock(Quota::per_minute(n), &clock)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:6 [INFO] [stdout] | [INFO] [stdout] 184 | let svc = tower::service_fn(move |req: http::Request| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | tokio_handle, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let middleware_layer = match (metrics, rate_limit_cfg) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let mut svc = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | svc.call(req).await.map_err(|e| BoxError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn with_rate_limit_per_minute(self, n: NonZeroU32) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { rate_limit: Some(RateLimit::per_minute(n)), metrics: self.metrics } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:65:48 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn with_metrics(self, metrics: Metrics) -> Self { [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Self { rate_limit: self.rate_limit, metrics: Some(metrics) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:83:37 [INFO] [stdout] | [INFO] [stdout] 82 | fn layer(&self, service: S) -> Self::Service { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Middleware { service, rate_limit: self.rate_limit.clone(), metrics: self.metrics.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:83:71 [INFO] [stdout] | [INFO] [stdout] 82 | fn layer(&self, service: S) -> Self::Service { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Middleware { service, rate_limit: self.rate_limit.clone(), metrics: self.metrics.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:115:3 [INFO] [stdout] | [INFO] [stdout] 106 | fn call(&self, req: Request<'a>) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let service = self.service.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let rate_limit = self.rate_limit.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let metrics = self.metrics.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | [INFO] [stdout] 115 | / async move { [INFO] [stdout] 116 | | let mut is_rate_limited = false; [INFO] [stdout] 117 | | [INFO] [stdout] 118 | | if let Some(limit) = rate_limit.as_ref() { [INFO] [stdout] ... | [INFO] [stdout] 142 | | rp [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/mod.rs:149:28 [INFO] [stdout] | [INFO] [stdout] 148 | fn reject_too_many_calls(id: Id) -> MethodResponse { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | MethodResponse::error(id, ErrorObject::owned(-32999, "RPC rate limit exceeded", None::<()>)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/node_health.rs:100:3 [INFO] [stdout] | [INFO] [stdout] 78 | fn call(&mut self, req: http::Request) -> Self::Future { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut req = req.map(|body| HttpBody::new(body)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let fut = self.0.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | / async move { [INFO] [stdout] 101 | | let res = fut.await.map_err(|err| err.into())?; [INFO] [stdout] 102 | | [INFO] [stdout] 103 | | Ok(match maybe_intercept { [INFO] [stdout] ... | [INFO] [stdout] 119 | | }) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/node_health.rs:103:7 [INFO] [stdout] | [INFO] [stdout] 98 | let fut = self.0.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let res = fut.await.map_err(|err| err.into())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | [INFO] [stdout] 103 | Ok(match maybe_intercept { [INFO] [stdout] | ________________^ [INFO] [stdout] 104 | | InterceptRequest::Deny => [INFO] [stdout] 105 | | http_response(StatusCode::METHOD_NOT_ALLOWED, HttpBody::empty()), [INFO] [stdout] 106 | | InterceptRequest::No => res, [INFO] [stdout] ... | [INFO] [stdout] 118 | | }, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/node_health.rs:144:2 [INFO] [stdout] | [INFO] [stdout] 143 | fn http_response>(status_code: StatusCode, body: S) -> HttpResponse { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | / HttpResponse::builder() [INFO] [stdout] 145 | | .status(status_code) [INFO] [stdout] 146 | | .header(http::header::CONTENT_TYPE, HEADER_VALUE_JSON) [INFO] [stdout] 147 | | .body(body.into()) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware/rate_limit.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 41 | let clock = QuantaClock::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | inner: Arc::new(RateLimitInner::direct_with_clock(Quota::per_minute(n), &clock)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sc-rpc-server` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sc-rpc-server` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "514668a465a2443b9187ad673282dd983ea7977c2b93743f1ff70f91ca022a6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "514668a465a2443b9187ad673282dd983ea7977c2b93743f1ff70f91ca022a6f", kill_on_drop: false }` [INFO] [stdout] 514668a465a2443b9187ad673282dd983ea7977c2b93743f1ff70f91ca022a6f