[INFO] fetching crate sbwt 0.3.1... [INFO] checking sbwt-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sbwt 0.3.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate sbwt 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sbwt 0.3.1 [INFO] finished tweaking crates.io crate sbwt 0.3.1 [INFO] tweaked toml for crates.io crate sbwt 0.3.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 161 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam v0.5.0 (latest: v0.8.4) [INFO] [stderr] Adding crossbeam-channel v0.3.9 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-deque v0.6.3 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.6.1 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-epoch v0.7.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding lock_api v0.1.5 (latest: v0.4.12) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding memoffset v0.2.1 (latest: v0.9.1) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding parking_lot v0.6.4 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.3.1 (latest: v0.9.10) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scopeguard v0.3.3 (latest: v1.2.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c37ba400f3109636a576d35b0fa455fb349810599284efc9aa3ef5d4493d5e48 [INFO] running `Command { std: "docker" "start" "-a" "c37ba400f3109636a576d35b0fa455fb349810599284efc9aa3ef5d4493d5e48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c37ba400f3109636a576d35b0fa455fb349810599284efc9aa3ef5d4493d5e48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c37ba400f3109636a576d35b0fa455fb349810599284efc9aa3ef5d4493d5e48", kill_on_drop: false }` [INFO] [stdout] c37ba400f3109636a576d35b0fa455fb349810599284efc9aa3ef5d4493d5e48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c25ba198411f1877d42257886f13fe3f883de3bf7a04583b9088a6a3a8cb12a [INFO] running `Command { std: "docker" "start" "-a" "7c25ba198411f1877d42257886f13fe3f883de3bf7a04583b9088a6a3a8cb12a", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking ex v0.1.3 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking jseqio v0.1.3 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling base64 v0.13.1 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking simple-sds-sbwt v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking read_exact v0.0.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking clap_complete v4.5.24 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking unitig_flipper v0.1.0 [INFO] [stderr] Compiling embed-doc-image v0.1.4 [INFO] [stderr] Checking sbwt v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `NullReader` is never constructed [INFO] [stdout] --> src/bitpacked_kmer_sorting/dummies.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct NullReader{} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | InvalidNucleotide(char), // contains the offending char [INFO] [stdout] | ----------------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `KmerEncodingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | InvalidNucleotide(()), // contains the offending char [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | TooLong(usize), // Contains the length of the k-mer which was too long [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `KmerEncodingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 11 | TooLong(()), // Contains the length of the k-mer which was too long [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FastXReader` is never constructed [INFO] [stdout] --> src/util.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | pub(crate) struct FastXReader{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/mod.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn build_with_bitpacked_kmer_sorting(seqs: IN, k: usize, mem_gb: u... [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | [INFO] [stdout] 17 | let thread_pool = rayon::ThreadPoolBuilder::new().num_threads(n_threads).build().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | thread_pool.install(||{ [INFO] [stdout] | _________________________^ [INFO] [stdout] 20 | | let sigma = DNA_ALPHABET.len(); [INFO] [stdout] 21 | | [INFO] [stdout] 22 | | log::info!("Splitting k-mers into bins"); [INFO] [stdout] ... | [INFO] [stdout] 76 | | (index, lcs) [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn split_to_bins(mut seqs: IN, k: usize, mem_gb: usize, n_threads: usize, dedup_batches:... [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | std::thread::scope(|scope| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 35 | | [INFO] [stdout] 36 | | let bin_prefix_len = 3_usize; // If you update this you must update all the logic below [INFO] [stdout] 37 | | let n_bins = (4_usize).pow(bin_prefix_len as u32); // 64 [INFO] [stdout] ... | [INFO] [stdout] 152 | | [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:147:70 [INFO] [stdout] | [INFO] [stdout] 147 | let mut writers: Vec = writers.into_iter().map(|w| w.into_inner().unwrap()).collect(); [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:246:5 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn par_sort_and_dedup_bin_files(bin_files: Vec, mem_gb: usize, n_threads: usize) -> Vec { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let mut files_and_sizes = bin_files.into_iter().enumerate().map(|(i, f)| (f, filesizes[i], i)).collect::(); // File, size, index [INFO] [stdout] | ------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let (producer_notify, producer_recv_notify) = unbounded::(); [INFO] [stdout] | --------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let producer_handle = thread::spawn(move || { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let mut consumer_handles = Vec::>>::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let mut processed_files = Vec::<(TempFile, usize)>::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | processed_files.into_iter().map(|(f,_)| f).collect() // Return to owner [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:159:46 [INFO] [stdout] | [INFO] [stdout] 159 | let filesizes = bin_files.iter().map(|f| f.path.metadata().unwrap().len() as usize).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/cursors.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 194 | let mut f = File::open(nondummy_filepath).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | f.seek(SeekFrom::Start(pos as u64 * nondummy_record_len as u64)).unwrap(); [INFO] [stdout] 196 | LongKmer::::load(&mut f).unwrap().unwrap() // Should never be None because we know the file length [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_chunk.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new>>(input: I) -> Self{ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self{kmers: input.into_iter().collect()} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempfile.rs:94:31 [INFO] [stdout] | [INFO] [stdout] 78 | let mut file = std::fs::File::create_new(&path); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | TempFile {path, file: file.unwrap()} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sbwt` (lib) due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `NullReader` is never constructed [INFO] [stdout] --> src/bitpacked_kmer_sorting/dummies.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct NullReader{} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | InvalidNucleotide(char), // contains the offending char [INFO] [stdout] | ----------------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `KmerEncodingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | InvalidNucleotide(()), // contains the offending char [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | TooLong(usize), // Contains the length of the k-mer which was too long [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `KmerEncodingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 11 | TooLong(()), // Contains the length of the k-mer which was too long [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FastXReader` is never constructed [INFO] [stdout] --> src/util.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | pub(crate) struct FastXReader{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/mod.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn build_with_bitpacked_kmer_sorting(seqs: IN, k: usize, mem_gb: u... [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | [INFO] [stdout] 17 | let thread_pool = rayon::ThreadPoolBuilder::new().num_threads(n_threads).build().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | thread_pool.install(||{ [INFO] [stdout] | _________________________^ [INFO] [stdout] 20 | | let sigma = DNA_ALPHABET.len(); [INFO] [stdout] 21 | | [INFO] [stdout] 22 | | log::info!("Splitting k-mers into bins"); [INFO] [stdout] ... | [INFO] [stdout] 76 | | (index, lcs) [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn split_to_bins(mut seqs: IN, k: usize, mem_gb: usize, n_threads: usize, dedup_batches:... [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | std::thread::scope(|scope| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 35 | | [INFO] [stdout] 36 | | let bin_prefix_len = 3_usize; // If you update this you must update all the logic below [INFO] [stdout] 37 | | let n_bins = (4_usize).pow(bin_prefix_len as u32); // 64 [INFO] [stdout] ... | [INFO] [stdout] 152 | | [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:147:70 [INFO] [stdout] | [INFO] [stdout] 147 | let mut writers: Vec = writers.into_iter().map(|w| w.into_inner().unwrap()).collect(); [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:246:5 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn par_sort_and_dedup_bin_files(bin_files: Vec, mem_gb: usize, n_threads: usize) -> Vec { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let mut files_and_sizes = bin_files.into_iter().enumerate().map(|(i, f)| (f, filesizes[i], i)).collect::(); // File, size, index [INFO] [stdout] | ------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let (producer_notify, producer_recv_notify) = unbounded::(); [INFO] [stdout] | --------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let producer_handle = thread::spawn(move || { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let mut consumer_handles = Vec::>>::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let mut processed_files = Vec::<(TempFile, usize)>::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | processed_files.into_iter().map(|(f,_)| f).collect() // Return to owner [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_splitter.rs:159:46 [INFO] [stdout] | [INFO] [stdout] 159 | let filesizes = bin_files.iter().map(|f| f.path.metadata().unwrap().len() as usize).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/cursors.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 194 | let mut f = File::open(nondummy_filepath).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | f.seek(SeekFrom::Start(pos as u64 * nondummy_record_len as u64)).unwrap(); [INFO] [stdout] 196 | LongKmer::::load(&mut f).unwrap().unwrap() // Should never be None because we know the file length [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitpacked_kmer_sorting/kmer_chunk.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new>>(input: I) -> Self{ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self{kmers: input.into_iter().collect()} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempfile.rs:94:31 [INFO] [stdout] | [INFO] [stdout] 78 | let mut file = std::fs::File::create_new(&path); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | TempFile {path, file: file.unwrap()} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sbwt` (lib test) due to 9 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7c25ba198411f1877d42257886f13fe3f883de3bf7a04583b9088a6a3a8cb12a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c25ba198411f1877d42257886f13fe3f883de3bf7a04583b9088a6a3a8cb12a", kill_on_drop: false }` [INFO] [stdout] 7c25ba198411f1877d42257886f13fe3f883de3bf7a04583b9088a6a3a8cb12a