[INFO] fetching crate savvy-macro 0.6.5... [INFO] checking savvy-macro-0.6.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate savvy-macro 0.6.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate savvy-macro 0.6.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate savvy-macro 0.6.5 [INFO] finished tweaking crates.io crate savvy-macro 0.6.5 [INFO] tweaked toml for crates.io crate savvy-macro 0.6.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a3c7232dc8831f78714f196f6c96ed595a9807342394a82f2df3c5e78fef7a1 [INFO] running `Command { std: "docker" "start" "-a" "7a3c7232dc8831f78714f196f6c96ed595a9807342394a82f2df3c5e78fef7a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a3c7232dc8831f78714f196f6c96ed595a9807342394a82f2df3c5e78fef7a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a3c7232dc8831f78714f196f6c96ed595a9807342394a82f2df3c5e78fef7a1", kill_on_drop: false }` [INFO] [stdout] 7a3c7232dc8831f78714f196f6c96ed595a9807342394a82f2df3c5e78fef7a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03f090d4bad909866a8e76615d4ee377b592ec0ffe222d44bb83e120df9eaf48 [INFO] running `Command { std: "docker" "start" "-a" "03f090d4bad909866a8e76615d4ee377b592ec0ffe222d44bb83e120df9eaf48", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking savvy-bindgen v0.6.5 [INFO] [stderr] Checking savvy-macro v0.6.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 58 | let savvy_fn = SavvyFn::from_fn(orig, as_init_fn)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let item_fn_inner = savvy_fn.generate_inner_fn(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let item_fn_ffi = savvy_fn.generate_ffi_fn(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 67 | | #orig [INFO] [stdout] 68 | | [INFO] [stdout] 69 | | #item_fn_inner [INFO] [stdout] 70 | | #item_fn_ffi [INFO] [stdout] 71 | | } [INFO] [stdout] 72 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 76 | let savvy_impl = SavvyImpl::new(orig)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let list_fn_inner = savvy_impl.generate_inner_fns(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let list_fn_ffi = savvy_impl.generate_ffi_fns(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 98 | | #orig [INFO] [stdout] 99 | | [INFO] [stdout] 100 | | #(#list_fn_inner)* [INFO] [stdout] 101 | | #(#list_fn_ffi)* [INFO] [stdout] 102 | | } [INFO] [stdout] 103 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 107 | let savvy_struct = SavvyStruct::new(orig)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let try_from_impls = savvy_struct.generate_try_from_impls(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(quote!( [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | #orig [INFO] [stdout] 115 | | [INFO] [stdout] 116 | | #(#try_from_impls)* [INFO] [stdout] 117 | | ) [INFO] [stdout] 118 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 122 | let savvy_enum = SavvyEnum::new(orig)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let enum_with_discriminant = savvy_enum.generate_enum_with_discriminant(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let try_from_impls = savvy_enum.generate_try_from_impls(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(quote!( [INFO] [stdout] | ________^ [INFO] [stdout] 130 | | #enum_with_discriminant [INFO] [stdout] 131 | | [INFO] [stdout] 132 | | #(#try_from_impls)* [INFO] [stdout] 133 | | ) [INFO] [stdout] 134 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `savvy-macro` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "03f090d4bad909866a8e76615d4ee377b592ec0ffe222d44bb83e120df9eaf48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03f090d4bad909866a8e76615d4ee377b592ec0ffe222d44bb83e120df9eaf48", kill_on_drop: false }` [INFO] [stdout] 03f090d4bad909866a8e76615d4ee377b592ec0ffe222d44bb83e120df9eaf48