[INFO] fetching crate satisfactory-save-file 0.2.0... [INFO] checking satisfactory-save-file-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate satisfactory-save-file 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate satisfactory-save-file 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate satisfactory-save-file 0.2.0 [INFO] finished tweaking crates.io crate satisfactory-save-file 0.2.0 [INFO] tweaked toml for crates.io crate satisfactory-save-file 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `flate2` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 252762dad0fe9075835b580c578027f3f4483b55620d8203632804e3a9fa3475 [INFO] running `Command { std: "docker" "start" "-a" "252762dad0fe9075835b580c578027f3f4483b55620d8203632804e3a9fa3475", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "252762dad0fe9075835b580c578027f3f4483b55620d8203632804e3a9fa3475", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "252762dad0fe9075835b580c578027f3f4483b55620d8203632804e3a9fa3475", kill_on_drop: false }` [INFO] [stdout] 252762dad0fe9075835b580c578027f3f4483b55620d8203632804e3a9fa3475 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b7e5b50d1ef2ae43b790e6ebd6dca23d89516a4287cc4ffe5502cad4fba8ee5 [INFO] running `Command { std: "docker" "start" "-a" "0b7e5b50d1ef2ae43b790e6ebd6dca23d89516a4287cc4ffe5502cad4fba8ee5", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `flate2` dependency) [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking satisfactory-save-file v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/lib.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | chrono::Utc.ymd(1, 1, 1).and_hms(12, 0, 0) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/lib.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | chrono::Utc.ymd(1, 1, 1).and_hms(12, 0, 0) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zlib_reader.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(mut file: R) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let chunk_length = ChunkedZLibReader::read_header(&mut file)?; [INFO] [stdout] 17 | let mut decoder = ZlibDecoder::new(file.take(chunk_length)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | decoder: Some(decoder), [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `satisfactory-save-file` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0b7e5b50d1ef2ae43b790e6ebd6dca23d89516a4287cc4ffe5502cad4fba8ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b7e5b50d1ef2ae43b790e6ebd6dca23d89516a4287cc4ffe5502cad4fba8ee5", kill_on_drop: false }` [INFO] [stdout] 0b7e5b50d1ef2ae43b790e6ebd6dca23d89516a4287cc4ffe5502cad4fba8ee5