[INFO] fetching crate sapio-base 0.2.4... [INFO] checking sapio-base-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sapio-base 0.2.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sapio-base 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sapio-base 0.2.4 [INFO] finished tweaking crates.io crate sapio-base 0.2.4 [INFO] tweaked toml for crates.io crate sapio-base 0.2.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.8.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoin_hashes v0.10.0 (latest: v0.14.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88cb52f5ef4da80891b1951fb8f481b59a3c1c6240223a984d77705d56d65221 [INFO] running `Command { std: "docker" "start" "-a" "88cb52f5ef4da80891b1951fb8f481b59a3c1c6240223a984d77705d56d65221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88cb52f5ef4da80891b1951fb8f481b59a3c1c6240223a984d77705d56d65221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88cb52f5ef4da80891b1951fb8f481b59a3c1c6240223a984d77705d56d65221", kill_on_drop: false }` [INFO] [stdout] 88cb52f5ef4da80891b1951fb8f481b59a3c1c6240223a984d77705d56d65221 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0497e9c1d3681ff17ab931bf879d04ec1e14b2e0b413e82ecc9cec9dc8add710 [INFO] running `Command { std: "docker" "start" "-a" "0497e9c1d3681ff17ab931bf879d04ec1e14b2e0b413e82ecc9cec9dc8add710", kill_on_drop: false }` [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking bech32 v0.8.1 [INFO] [stderr] Compiling sapio-secp256k1-sys v0.9.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bitcoin_hashes v0.10.0 [INFO] [stderr] Checking sapio-secp256k1 v0.28.1 [INFO] [stderr] Checking sapio-bitcoin v0.28.2 [INFO] [stderr] Checking sapio-miniscript v7.0.1 [INFO] [stderr] Checking sapio-base v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/effects/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::reverse_path::ReversePath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `ReversePath` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/effects/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub use reverse_path::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/effects/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::reverse_path::ReversePath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/effects/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::reverse_path::ReversePath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `ReversePath` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/effects/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub use reverse_path::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/effects/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::reverse_path::ReversePath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/path_fragment.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 142 | let frags = r [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | ReversePath::try_from(frags).map_err(ValidFragmentError::InvalidReversePath) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 55 | fn try_from(v: Vec) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | match v [INFO] [stdout] | _______________^ [INFO] [stdout] 57 | | .into_iter() [INFO] [stdout] 58 | | .fold(None, |x, v| Some(Self::push(x, v))) [INFO] [stdout] 59 | | .map(Arc::try_unwrap) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:58:37 [INFO] [stdout] | [INFO] [stdout] 58 | .fold(None, |x, v| Some(Self::push(x, v))) [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(this: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ReversePath { [INFO] [stdout] 76 | past: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn push(v: Option>>, s: T) -> Arc> { [INFO] [stdout] | --------------------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Arc::new(Self::push_owned(v, s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialization_helpers.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn deserializer<'de, T, D>(d: D) -> Result, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Arc::new(T::deserialize(d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/path_fragment.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 142 | let frags = r [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | ReversePath::try_from(frags).map_err(ValidFragmentError::InvalidReversePath) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 55 | fn try_from(v: Vec) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | match v [INFO] [stdout] | _______________^ [INFO] [stdout] 57 | | .into_iter() [INFO] [stdout] 58 | | .fold(None, |x, v| Some(Self::push(x, v))) [INFO] [stdout] 59 | | .map(Arc::try_unwrap) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:58:37 [INFO] [stdout] | [INFO] [stdout] 58 | .fold(None, |x, v| Some(Self::push(x, v))) [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(this: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ReversePath { [INFO] [stdout] 76 | past: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn push(v: Option>>, s: T) -> Arc> { [INFO] [stdout] | --------------------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Arc::new(Self::push_owned(v, s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:175:37 [INFO] [stdout] | [INFO] [stdout] 175 | .fold(None, |x, y| Some(ReversePath::>::push(x, y))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sapio-base` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:179:37 [INFO] [stdout] | [INFO] [stdout] 179 | .fold(None, |x, y| Some(ReversePath::push(x, y))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:190:37 [INFO] [stdout] | [INFO] [stdout] 190 | .fold(None, |x, y| Some(ReversePath::>::push(x, y))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/effects/reverse_path.rs:193:37 [INFO] [stdout] | [INFO] [stdout] 193 | .fold(None, |x, y| Some(ReversePath::>::push(x, y))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialization_helpers.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn deserializer<'de, T, D>(d: D) -> Result, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Arc::new(T::deserialize(d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sapio-base` (lib test) due to 11 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0497e9c1d3681ff17ab931bf879d04ec1e14b2e0b413e82ecc9cec9dc8add710", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0497e9c1d3681ff17ab931bf879d04ec1e14b2e0b413e82ecc9cec9dc8add710", kill_on_drop: false }` [INFO] [stdout] 0497e9c1d3681ff17ab931bf879d04ec1e14b2e0b413e82ecc9cec9dc8add710