[INFO] fetching crate samply 0.12.0... [INFO] checking samply-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate samply 0.12.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate samply 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate samply 0.12.0 [INFO] finished tweaking crates.io crate samply 0.12.0 [INFO] tweaked toml for crates.io crate samply 0.12.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate samply 0.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c461b92c9f2f84d68fa65e7cea89983adc4e530200d8a34e1dfd5ab685c6540 [INFO] running `Command { std: "docker" "start" "-a" "8c461b92c9f2f84d68fa65e7cea89983adc4e530200d8a34e1dfd5ab685c6540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c461b92c9f2f84d68fa65e7cea89983adc4e530200d8a34e1dfd5ab685c6540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c461b92c9f2f84d68fa65e7cea89983adc4e530200d8a34e1dfd5ab685c6540", kill_on_drop: false }` [INFO] [stdout] 8c461b92c9f2f84d68fa65e7cea89983adc4e530200d8a34e1dfd5ab685c6540 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ddaaa44cdea1713d6c85d55e533626f3ba6751a38e191b8d3002b330632e2e84 [INFO] running `Command { std: "docker" "start" "-a" "ddaaa44cdea1713d6c85d55e533626f3ba6751a38e191b8d3002b330632e2e84", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling cc v1.0.92 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling rustls v0.22.3 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling ref-cast v1.0.22 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking brotli-decompressor v3.0.0 [INFO] [stderr] Checking inplace-vec-builder v0.1.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking scroll v0.11.0 [INFO] [stderr] Compiling cpp_demangle v0.4.3 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking binary-merge v0.1.2 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking pdb2 v0.9.0 [INFO] [stderr] Checking elsa v1.10.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Compiling yaxpeax-x86 v1.2.2 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking linear-map v1.2.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking zerofrom v0.1.3 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking brotli v4.0.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Checking yaxpeax-arch v0.2.7 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking yoke v0.7.3 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking msvc-demangler v0.10.0 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking scala-native-demangle v0.0.6 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking rangemap v1.5.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking lzxd v0.2.5 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking cab v0.6.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking fs4 v0.8.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Checking nix-base32 v0.1.1 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling thiserror-impl-no-std v2.0.2 [INFO] [stderr] Checking opener v0.7.0 [INFO] [stderr] Checking yaxpeax-arm v0.2.5 [INFO] [stderr] Checking thiserror-no-std v2.0.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking ruzstd v0.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling ref-cast-impl v1.0.22 [INFO] [stderr] Compiling zerocopy-derive v0.7.32 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling yoke-derive v0.7.3 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking object v0.35.0 [INFO] [stderr] Checking range-collections v0.4.5 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking macho-unwind-info v0.4.0 [INFO] [stderr] Checking linux-perf-event-reader v0.10.0 [INFO] [stderr] Checking pdb-addr2line v0.11.0 [INFO] [stderr] Checking srcsrv v0.2.2 [INFO] [stderr] Checking pe-unwind-info v0.2.3 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking framehop v0.11.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking linux-perf-data v0.9.0 [INFO] [stderr] Checking fxprof-processed-profile v0.7.0 [INFO] [stderr] Checking samply-symbols v0.22.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking async-compression v0.4.8 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking samply-api v0.23.0 [INFO] [stderr] Checking hyper v1.3.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking reqwest v0.12.3 [INFO] [stderr] Checking symsrv v0.5.1 [INFO] [stderr] Checking wholesym v0.5.0 [INFO] [stderr] Checking samply v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/shared/jit_category_manager.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | SelfHosted(StringHandle), [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `JsName` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 14 | SelfHosted(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `main_thread_only` is never read [INFO] [stdout] --> src/shared/recording_props.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct RecordingProps { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub main_thread_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnresolvedRssStatMarker` is never constructed [INFO] [stdout] --> src/shared/unresolved_samples.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | pub struct UnresolvedRssStatMarker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UnresolvedRssStatMarker` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/process.rs:26:35 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|os_str: &OsStr| CString::new(os_str.as_bytes().to_vec()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/sorter.rs:108:24 [INFO] [stdout] | [INFO] [stdout] 106 | self.heap.extend(iter.into_iter().map(|(seq, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | EventHeapItem { [INFO] [stdout] 108 | group: self [INFO] [stdout] | ________________________^ [INFO] [stdout] 109 | | .current_group [INFO] [stdout] 110 | | .clone() [INFO] [stdout] 111 | | .expect("begin_group must be called before insertion"), [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 87 | delayed_product_name_generator: Option, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | cache: U::Cache, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let profile = Profile::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let kernel_symbols = match KernelSymbols::new_for_running_kernel() { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Ok(kernel_symbols) => Some(kernel_symbols), [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Err(_err) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | processes: Processes::new(reuse_threads), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:1189:26 [INFO] [stdout] | [INFO] [stdout] 1144 | mmap_arc: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1175 | let eh_frame_data = eh_frame.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1176 | let eh_frame_hdr_data = eh_frame_hdr.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | let text_data = text.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1189 | unwind_info: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:1194:26 [INFO] [stdout] | [INFO] [stdout] 1144 | mmap_arc: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1175 | let eh_frame_data = eh_frame.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1176 | let eh_frame_hdr_data = eh_frame_hdr.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | let text_data = text.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1194 | debug_frame: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:1196:27 [INFO] [stdout] | [INFO] [stdout] 1144 | mmap_arc: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1175 | let eh_frame_data = eh_frame.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1176 | let eh_frame_hdr_data = eh_frame_hdr.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | let text_data = text.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1196 | text_segment: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/injected_jit_object.rs:108:10 [INFO] [stdout] | [INFO] [stdout] 72 | let mmap = unsafe { memmap2::MmapOptions::new().map(file) }.ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let fixed_file = std::fs::File::open(&fixed_path).ok()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Some((fixed_file, fixed_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/kernel_symbols.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 44 | let symbol_table = Arc::new(symbol_table); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(KernelSymbols { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | build_id, [INFO] [stdout] 47 | | base_avma, [INFO] [stdout] 48 | | symbol_table, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/kernel_symbols.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 141 | let mut res: T = T::from(0); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok((remaining, res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:258:29 [INFO] [stdout] | [INFO] [stdout] 243 | let symbol_manager = symbol_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let profile_filename = profile_filename.clone(); [INFO] [stdout] 245 | let template_values = template_values.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | template_values.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:259:29 [INFO] [stdout] | [INFO] [stdout] 243 | let symbol_manager = symbol_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let profile_filename = profile_filename.clone(); [INFO] [stdout] 245 | let template_values = template_values.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | symbol_manager.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/jitdump_manager.rs:57:26 [INFO] [stdout] | [INFO] [stdout] 55 | let (file, path) = open_file_with_fallback(path, fallback_dir).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let reader = JitDumpReader::new(file).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Some((reader, path)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/jitdump_manager.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 85 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / self.processors [INFO] [stdout] 93 | | .into_iter() [INFO] [stdout] 94 | | .map(|processor| processor.finish(profile)) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/jitdump_manager.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 120 | reader: JitDumpReader, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | reader: Some(reader), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/marker_file.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse(file: File, timestamp_converter: TimestampConverter) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Self { [INFO] [stdout] 45 | lines: BufReader::new(file).lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `samply` (bin "samply") due to 16 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/shared/jit_category_manager.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | SelfHosted(StringHandle), [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `JsName` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 14 | SelfHosted(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `main_thread_only` is never read [INFO] [stdout] --> src/shared/recording_props.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct RecordingProps { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub main_thread_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnresolvedRssStatMarker` is never constructed [INFO] [stdout] --> src/shared/unresolved_samples.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | pub struct UnresolvedRssStatMarker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UnresolvedRssStatMarker` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/process.rs:26:35 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|os_str: &OsStr| CString::new(os_str.as_bytes().to_vec()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/sorter.rs:108:24 [INFO] [stdout] | [INFO] [stdout] 106 | self.heap.extend(iter.into_iter().map(|(seq, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | EventHeapItem { [INFO] [stdout] 108 | group: self [INFO] [stdout] | ________________________^ [INFO] [stdout] 109 | | .current_group [INFO] [stdout] 110 | | .clone() [INFO] [stdout] 111 | | .expect("begin_group must be called before insertion"), [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 87 | delayed_product_name_generator: Option, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | cache: U::Cache, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let profile = Profile::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let kernel_symbols = match KernelSymbols::new_for_running_kernel() { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Ok(kernel_symbols) => Some(kernel_symbols), [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Err(_err) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | processes: Processes::new(reuse_threads), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:1189:26 [INFO] [stdout] | [INFO] [stdout] 1144 | mmap_arc: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1175 | let eh_frame_data = eh_frame.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1176 | let eh_frame_hdr_data = eh_frame_hdr.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | let text_data = text.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1189 | unwind_info: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:1194:26 [INFO] [stdout] | [INFO] [stdout] 1144 | mmap_arc: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1175 | let eh_frame_data = eh_frame.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1176 | let eh_frame_hdr_data = eh_frame_hdr.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | let text_data = text.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1194 | debug_frame: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/converter.rs:1196:27 [INFO] [stdout] | [INFO] [stdout] 1144 | mmap_arc: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1175 | let eh_frame_data = eh_frame.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1176 | let eh_frame_hdr_data = eh_frame_hdr.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1177 | let text_data = text.as_ref().and_then(|s| section_data(s, mmap)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1196 | text_segment: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/injected_jit_object.rs:108:10 [INFO] [stdout] | [INFO] [stdout] 72 | let mmap = unsafe { memmap2::MmapOptions::new().map(file) }.ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let fixed_file = std::fs::File::open(&fixed_path).ok()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Some((fixed_file, fixed_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/kernel_symbols.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 44 | let symbol_table = Arc::new(symbol_table); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(KernelSymbols { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | build_id, [INFO] [stdout] 47 | | base_avma, [INFO] [stdout] 48 | | symbol_table, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux_shared/kernel_symbols.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 141 | let mut res: T = T::from(0); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok((remaining, res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:258:29 [INFO] [stdout] | [INFO] [stdout] 243 | let symbol_manager = symbol_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let profile_filename = profile_filename.clone(); [INFO] [stdout] 245 | let template_values = template_values.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | template_values.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:259:29 [INFO] [stdout] | [INFO] [stdout] 243 | let symbol_manager = symbol_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let profile_filename = profile_filename.clone(); [INFO] [stdout] 245 | let template_values = template_values.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | symbol_manager.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/jitdump_manager.rs:57:26 [INFO] [stdout] | [INFO] [stdout] 55 | let (file, path) = open_file_with_fallback(path, fallback_dir).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let reader = JitDumpReader::new(file).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Some((reader, path)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/jitdump_manager.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 85 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / self.processors [INFO] [stdout] 93 | | .into_iter() [INFO] [stdout] 94 | | .map(|processor| processor.finish(profile)) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/jitdump_manager.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 120 | reader: JitDumpReader, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | reader: Some(reader), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared/marker_file.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse(file: File, timestamp_converter: TimestampConverter) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Self { [INFO] [stdout] 45 | lines: BufReader::new(file).lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `samply` (bin "samply" test) due to 16 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ddaaa44cdea1713d6c85d55e533626f3ba6751a38e191b8d3002b330632e2e84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddaaa44cdea1713d6c85d55e533626f3ba6751a38e191b8d3002b330632e2e84", kill_on_drop: false }` [INFO] [stdout] ddaaa44cdea1713d6c85d55e533626f3ba6751a38e191b8d3002b330632e2e84