[INFO] fetching crate sample-arrow2 0.17.2... [INFO] checking sample-arrow2-0.17.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sample-arrow2 0.17.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sample-arrow2 0.17.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sample-arrow2 0.17.2 [INFO] finished tweaking crates.io crate sample-arrow2 0.17.2 [INFO] tweaked toml for crates.io crate sample-arrow2 0.17.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding arrow2 v0.17.4 (latest: v0.18.0) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding rand_regex v0.15.1 (latest: v0.17.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f78117bd1a7f678b88fbb3fb5881f23cde7d87d72cefab2c0e4df379771ab3fa [INFO] running `Command { std: "docker" "start" "-a" "f78117bd1a7f678b88fbb3fb5881f23cde7d87d72cefab2c0e4df379771ab3fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f78117bd1a7f678b88fbb3fb5881f23cde7d87d72cefab2c0e4df379771ab3fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f78117bd1a7f678b88fbb3fb5881f23cde7d87d72cefab2c0e4df379771ab3fa", kill_on_drop: false }` [INFO] [stdout] f78117bd1a7f678b88fbb3fb5881f23cde7d87d72cefab2c0e4df379771ab3fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a39cf11f3536f750c7c7774839d22f0f676bcfe101f6ffd579399e8b193c8b72 [INFO] running `Command { std: "docker" "start" "-a" "a39cf11f3536f750c7c7774839d22f0f676bcfe101f6ffd579399e8b193c8b72", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling casey v0.4.0 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking hash_hasher v2.0.3 [INFO] [stderr] Compiling arrow2 v0.17.4 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling rand_regex v0.15.1 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking sample-std v0.2.1 [INFO] [stderr] Checking sample-arrow2 v0.17.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `StructDataTypeSampler` is never constructed [INFO] [stdout] --> src/datatypes.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | struct StructDataTypeSampler { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn arbitrary_array(self, data_type_sampler: DataTypeSampler) -> ChainedArraySampler { [INFO] [stdout] | ---- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Box::new(data_type_sampler.chain_resample( [INFO] [stdout] | __________________^ [INFO] [stdout] 135 | | move |data_type| self.sampler_from_data_type(&data_type), [INFO] [stdout] 136 | | 100, [INFO] [stdout] 137 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn sample_one(self) -> ChunkSampler { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Box::new( [INFO] [stdout] 30 | / VecSampler { [INFO] [stdout] 31 | | length: self.array_count, [INFO] [stdout] 32 | | el: self.data_type, [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | .zip(self.chunk_len) [INFO] [stdout] 35 | | .chain_resample(move |seed| Self::from_seed(&self.array, seed), 100), [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn sample_many(self, chunk_count: Range) -> MultiChunkSampler { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Box::new( [INFO] [stdout] 41 | / VecSampler { [INFO] [stdout] 42 | | length: self.array_count, [INFO] [stdout] 43 | | el: self.data_type, [INFO] [stdout] 44 | | } [INFO] [stdout] ... | [INFO] [stdout] 57 | | 100, [INFO] [stdout] 58 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:52:25 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn sample_many(self, chunk_count: Range) -> MultiChunkSampler { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | move |(dts, lens)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | sample_all( [INFO] [stdout] 52 | / lens.into_iter() [INFO] [stdout] 53 | | .map(|len| Self::from_seed(&self.array, (dts.clone(), len))) [INFO] [stdout] 54 | | .collect(), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:53:69 [INFO] [stdout] | [INFO] [stdout] 53 | ... .map(|len| Self::from_seed(&self.array, (dts.clone(), len))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 64 | seed: (Vec, usize), [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Box>> + Send + Sync> { [INFO] [stdout] 66 | let (dts, len) = seed; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Box::new( [INFO] [stdout] 68 | / sample_all( [INFO] [stdout] 69 | | dts.into_iter() [INFO] [stdout] 70 | | .map(|data_type| array.with_len(len).sampler_from_data_type(&data_type)) [INFO] [stdout] 71 | | .collect(), [INFO] [stdout] 72 | | ) [INFO] [stdout] 73 | | .try_convert(Chunk::new, |chunk| Some(chunk.to_vec())), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|data_type| array.with_len(len).sampler_from_data_type(&data_type)) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:73:51 [INFO] [stdout] | [INFO] [stdout] 73 | .try_convert(Chunk::new, |chunk| Some(chunk.to_vec())), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn sample_nested(&self, inner: IF) -> DataTypeSampler [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Box::new(sampler_choice([ [INFO] [stdout] | __________________^ [INFO] [stdout] 88 | | Box::new((self.flat)()) as DataTypeSampler, [INFO] [stdout] 89 | | Box::new( [INFO] [stdout] 90 | | VecSampler { [INFO] [stdout] ... | [INFO] [stdout] 96 | | Box::new(field().try_convert(|f| DataType::List(Box::new(f)), |_| None)), [INFO] [stdout] 97 | | ])) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | names: self.names.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | nullable: self.nullable.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | inner: inner(), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes.rs:96:61 [INFO] [stdout] | [INFO] [stdout] 96 | Box::new(field().try_convert(|f| DataType::List(Box::new(f)), |_| None)), [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_size_list.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 39 | let values = self.inner.generate(g); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let field = Field::new(inner_name, values.data_type().clone(), is_nullable); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let data_type = DataType::FixedSizeList(Box::new(field), count); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let validity = self.validity.generate(g); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | FixedSizeListArray::new(data_type, values, validity).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 50 | let values = self.inner.generate(g); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let field = Field::new(inner_name, values.data_type().clone(), is_nullable); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let data_type = DataType::List(Box::new(field)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let offsets = OffsetsBuffer::try_from(offsets).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let validity = self.validity.generate(g); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | ListArray::new(data_type, offsets, values, validity).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 90 | let values = self.inner.generate(g); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let validity = generate_validity(&mut self.null, g, len); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | / ListArray::new( [INFO] [stdout] 111 | | self.data_type.clone(), [INFO] [stdout] 112 | | OffsetsBuffer::try_from(offsets).unwrap(), [INFO] [stdout] 113 | | values, [INFO] [stdout] 114 | | validity, [INFO] [stdout] 115 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 57 | fn boxed(self) -> ArrowLenSampler { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Box::new(self.try_convert(PrimitiveArray::boxed, unbox)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn primitive_len_sampler(inner: PT, validity: V) -> ArrowLenSampler [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | / PrimitiveArraySampler { [INFO] [stdout] 72 | | len: 0, [INFO] [stdout] 73 | | inner, [INFO] [stdout] 74 | | validity, [INFO] [stdout] 75 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:91:14 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn valid_float_len_sampler(valid: V) -> ArrowLenSampler [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 92 | | // todo: f16 [INFO] [stdout] 93 | | primitive_len_sampler(valid_f32(), valid.clone()), [INFO] [stdout] 94 | | primitive_len_sampler(valid_f64(), valid), [INFO] [stdout] 95 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn arbitrary_float_len_sampler(valid: V) -> ArrowLenSampler [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 103 | | // todo: f16 [INFO] [stdout] 104 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 105 | | arbitrary_len_sampler::(valid), [INFO] [stdout] 106 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn arbitrary_int_len_sampler(valid: V) -> ArrowLenSampler [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 114 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 115 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 116 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 117 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 118 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn arbitrary_uint_len_sampler(valid: V) -> ArrowLenSampler [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 129 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 130 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 131 | | arbitrary_len_sampler::(valid.clone()), [INFO] [stdout] 132 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:139:14 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn valid_primitive_len(valid: V) -> ArrowLenSampler [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Box::new(sampler_choice([ [INFO] [stdout] | ______________^ [INFO] [stdout] 140 | | valid_float_len_sampler(valid.clone()), [INFO] [stdout] 141 | | arbitrary_int_len_sampler(valid.clone()), [INFO] [stdout] 142 | | arbitrary_uint_len_sampler(valid.clone()), [INFO] [stdout] 143 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn arbitrary_primitive_len(valid: V) -> ArrowLenSampler [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Box::new(sampler_choice([ [INFO] [stdout] | ______________^ [INFO] [stdout] 151 | | arbitrary_float_len_sampler(valid.clone()), [INFO] [stdout] 152 | | arbitrary_int_len_sampler(valid.clone()), [INFO] [stdout] 153 | | arbitrary_uint_len_sampler(valid.clone()), [INFO] [stdout] 154 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 180 | fn shrink(&self, v: Self::Output) -> Shrunk { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let vec = v.iter().map(|el| el.cloned()).collect(); [INFO] [stdout] 182 | Box::new(self.inner.shrink(vec).map(to_primitive)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 202 | fn shrink(&self, v: Self::Output) -> Shrunk { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | / self.inner [INFO] [stdout] 206 | | .shrink(vec) [INFO] [stdout] 207 | | .map(IntoIterator::into_iter) [INFO] [stdout] 208 | | .map(PrimitiveArray::from_trusted_len_values_iter), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:218:14 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn boxed_nullable(len: Range, el: GT) -> ArrowSampler [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Box::new(ProtoBoxedNullablePrimitiveArray { [INFO] [stdout] | ______________^ [INFO] [stdout] 219 | | inner: ProtoNullablePrimitiveArray { [INFO] [stdout] 220 | | inner: VecSampler { length: len, el }, [INFO] [stdout] 221 | | }, [INFO] [stdout] 222 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn boxed(len: Range, el: GT) -> ArrowSampler [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | / ProtoPrimitiveArray { [INFO] [stdout] 232 | | inner: VecSampler { length: len, el }, [INFO] [stdout] 233 | | } [INFO] [stdout] 234 | | .try_convert(PrimitiveArray::boxed, |boxed| { [INFO] [stdout] ... | [INFO] [stdout] 239 | | } [INFO] [stdout] 240 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:262:13 [INFO] [stdout] | [INFO] [stdout] 260 | fn shrink(&self, v: Self::Output) -> Shrunk { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | Box::new( [INFO] [stdout] 262 | / v.as_any() [INFO] [stdout] 263 | | .downcast_ref::>() [INFO] [stdout] 264 | | .cloned() [INFO] [stdout] 265 | | .into_iter() [INFO] [stdout] 266 | | .flat_map(move |arr| self.inner.shrink(arr.clone()).map(|arr| arr.boxed())), [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:266:38 [INFO] [stdout] | [INFO] [stdout] 266 | .flat_map(move |arr| self.inner.shrink(arr.clone()).map(|arr| arr.boxed())), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:329:14 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn valid_float_array(len: Range, null: Option) -> ArrowSampler [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 330 | | // todo: f16 [INFO] [stdout] 331 | | boxed_primitive(valid_f32(), len.clone(), null.clone()), [INFO] [stdout] 332 | | boxed_primitive(valid_f64(), len, null), [INFO] [stdout] 333 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:340:14 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn arbitrary_float_array(len: Range, null: Option) -> ArrowSampler [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 341 | | // todo: f16 [INFO] [stdout] 342 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 343 | | arbitrary_boxed_primitive::(len, null), [INFO] [stdout] 344 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:351:14 [INFO] [stdout] | [INFO] [stdout] 347 | pub fn arbitrary_int_array(len: Range, null: Option) -> ArrowSampler [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 352 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 353 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 354 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 355 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 356 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:365:14 [INFO] [stdout] | [INFO] [stdout] 361 | pub fn arbitrary_uint_array(len: Range, null: Option) -> ArrowSampler [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | Box::new(sampler_choice(vec![ [INFO] [stdout] | ______________^ [INFO] [stdout] 366 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 367 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 368 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 369 | | arbitrary_boxed_primitive::(len.clone(), null.clone()), [INFO] [stdout] 370 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:377:14 [INFO] [stdout] | [INFO] [stdout] 373 | pub fn valid_primitive(len: Range, null: Option) -> ArrowSampler [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | Box::new(sampler_choice([ [INFO] [stdout] | ______________^ [INFO] [stdout] 378 | | valid_float_array(len.clone(), null.clone()), [INFO] [stdout] 379 | | arbitrary_int_array(len.clone(), null.clone()), [INFO] [stdout] 380 | | arbitrary_uint_array(len.clone(), null.clone()), [INFO] [stdout] 381 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/primitive.rs:388:14 [INFO] [stdout] | [INFO] [stdout] 384 | pub fn arbitrary_primitive(len: Range, null: Option) -> ArrowSampler [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | Box::new(sampler_choice([ [INFO] [stdout] | ______________^ [INFO] [stdout] 389 | | arbitrary_float_array(len.clone(), null.clone()), [INFO] [stdout] 390 | | arbitrary_int_array(len.clone(), null.clone()), [INFO] [stdout] 391 | | arbitrary_uint_array(len.clone(), null.clone()), [INFO] [stdout] 392 | | ])) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/struct_.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 23 | let values: Vec<_> = self.values.iter_mut().map(|sa| sa.generate(g)).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let validity = generate_validity(&mut self.null, g, values[0].len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | StructArray::new(self.data_type.clone(), values, validity).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 37 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sample-arrow2` (lib) due to 38 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a39cf11f3536f750c7c7774839d22f0f676bcfe101f6ffd579399e8b193c8b72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a39cf11f3536f750c7c7774839d22f0f676bcfe101f6ffd579399e8b193c8b72", kill_on_drop: false }` [INFO] [stdout] a39cf11f3536f750c7c7774839d22f0f676bcfe101f6ffd579399e8b193c8b72