[INFO] fetching crate samotop-with-rustls 0.13.0... [INFO] checking samotop-with-rustls-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate samotop-with-rustls 0.13.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate samotop-with-rustls 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate samotop-with-rustls 0.13.0 [INFO] finished tweaking crates.io crate samotop-with-rustls 0.13.0 [INFO] tweaked toml for crates.io crate samotop-with-rustls 0.13.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding async-tls v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.19.1 (latest: v0.23.12) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding webpki-roots v0.21.1 (latest: v0.26.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a736fce3eeb405a3ec480e9d9fb776b0d36d9f489b3acbd2a21aa003f155d17 [INFO] running `Command { std: "docker" "start" "-a" "8a736fce3eeb405a3ec480e9d9fb776b0d36d9f489b3acbd2a21aa003f155d17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a736fce3eeb405a3ec480e9d9fb776b0d36d9f489b3acbd2a21aa003f155d17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a736fce3eeb405a3ec480e9d9fb776b0d36d9f489b3acbd2a21aa003f155d17", kill_on_drop: false }` [INFO] [stdout] 8a736fce3eeb405a3ec480e9d9fb776b0d36d9f489b3acbd2a21aa003f155d17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52804b1000150884ca277800b58f302c123ec88cd0267a21ba9541823faeb89a [INFO] running `Command { std: "docker" "start" "-a" "52804b1000150884ca277800b58f302c123ec88cd0267a21ba9541823faeb89a", kill_on_drop: false }` [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking samotop-core v0.13.1+smtp [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking async-tls v0.11.0 [INFO] [stderr] Checking samotop-with-rustls v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 30 | io: Box, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let fut = self.inner.accept(io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 35 | | match fut.await { [INFO] [stdout] 36 | | Ok(encrypted) => { [INFO] [stdout] 37 | | let encrypted: Box = Box::new(encrypted); [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 33 | let fut = self.inner.accept(io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::pin(async move { [INFO] [stdout] 35 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 47 | fn upgrade_to_tls(&self, io: Box, name: String) -> S3Fut>> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let fut = self.inner.connect(name.as_str(), io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 50 | | match fut.await { [INFO] [stdout] 51 | | Ok(encrypted) => { [INFO] [stdout] 52 | | let encrypted: Box = Box::new(encrypted); [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 48 | let fut = self.inner.connect(name.as_str(), io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Box::pin(async move { [INFO] [stdout] 50 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `samotop-with-rustls` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 30 | io: Box, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let fut = self.inner.accept(io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 35 | | match fut.await { [INFO] [stdout] 36 | | Ok(encrypted) => { [INFO] [stdout] 37 | | let encrypted: Box = Box::new(encrypted); [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 33 | let fut = self.inner.accept(io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::pin(async move { [INFO] [stdout] 35 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 47 | fn upgrade_to_tls(&self, io: Box, name: String) -> S3Fut>> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let fut = self.inner.connect(name.as_str(), io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 50 | | match fut.await { [INFO] [stdout] 51 | | Ok(encrypted) => { [INFO] [stdout] 52 | | let encrypted: Box = Box::new(encrypted); [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 48 | let fut = self.inner.connect(name.as_str(), io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Box::pin(async move { [INFO] [stdout] 50 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `samotop-with-rustls` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "52804b1000150884ca277800b58f302c123ec88cd0267a21ba9541823faeb89a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52804b1000150884ca277800b58f302c123ec88cd0267a21ba9541823faeb89a", kill_on_drop: false }` [INFO] [stdout] 52804b1000150884ca277800b58f302c123ec88cd0267a21ba9541823faeb89a