[INFO] fetching crate salvo-proxy 0.71.1... [INFO] checking salvo-proxy-0.71.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate salvo-proxy 0.71.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate salvo-proxy 0.71.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate salvo-proxy 0.71.1 [INFO] finished tweaking crates.io crate salvo-proxy 0.71.1 [INFO] tweaked toml for crates.io crate salvo-proxy 0.71.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 202 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cfd19ecaac0a4664086908ffcc7755aa3ffec4434359760bd24c90e725abbe27 [INFO] running `Command { std: "docker" "start" "-a" "cfd19ecaac0a4664086908ffcc7755aa3ffec4434359760bd24c90e725abbe27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cfd19ecaac0a4664086908ffcc7755aa3ffec4434359760bd24c90e725abbe27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfd19ecaac0a4664086908ffcc7755aa3ffec4434359760bd24c90e725abbe27", kill_on_drop: false }` [INFO] [stdout] cfd19ecaac0a4664086908ffcc7755aa3ffec4434359760bd24c90e725abbe27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c101ff36ad919c3989da488cc469ee7681d9df22300f3ec18750bb7fb1d1f7d [INFO] running `Command { std: "docker" "start" "-a" "4c101ff36ad919c3989da488cc469ee7681d9df22300f3ec18750bb7fb1d1f7d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Compiling mime-infer v3.0.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling salvo-serde-util v0.71.1 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking multimap v0.10.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Compiling salvo_macros v0.71.1 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking salvo_core v0.71.1 [INFO] [stderr] Checking salvo-proxy v0.71.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:30 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(upstreams: U, client: C) -> Self { [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | url_path_getter: Box::new(default_url_path_getter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(upstreams: U, client: C) -> Self { [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | url_query_getter: Box::new(default_url_query_getter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:256:64 [INFO] [stdout] | [INFO] [stdout] 256 | if let Some(host) = forward_url.host().and_then(|host| HeaderValue::from_str(host).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:337:38 [INFO] [stdout] | [INFO] [stdout] 337 | .any(|e| e.trim() == UPGRADE) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyper_client.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 20 | let https = HttpsConnectorBuilder::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | inner: HyperUtilClient::builder(TokioExecutor::new()).build(https), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyper_client.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn use_hyper_client(upstreams: U) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Proxy::new(upstreams, HyperClient::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyper_client.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 65 | let response_upgraded = hyper::upgrade::on(&mut response).await?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | if let Some(request_upgraded) = request_upgraded { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | tokio::spawn(async move { [INFO] [stdout] 68 | match request_upgraded.await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salvo-proxy` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:30 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(upstreams: U, client: C) -> Self { [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | url_path_getter: Box::new(default_url_path_getter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(upstreams: U, client: C) -> Self { [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | url_query_getter: Box::new(default_url_query_getter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:256:64 [INFO] [stdout] | [INFO] [stdout] 256 | if let Some(host) = forward_url.host().and_then(|host| HeaderValue::from_str(host).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:337:38 [INFO] [stdout] | [INFO] [stdout] 337 | .any(|e| e.trim() == UPGRADE) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyper_client.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 20 | let https = HttpsConnectorBuilder::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | inner: HyperUtilClient::builder(TokioExecutor::new()).build(https), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyper_client.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn use_hyper_client(upstreams: U) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Proxy::new(upstreams, HyperClient::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyper_client.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 65 | let response_upgraded = hyper::upgrade::on(&mut response).await?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | if let Some(request_upgraded) = request_upgraded { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | tokio::spawn(async move { [INFO] [stdout] 68 | match request_upgraded.await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salvo-proxy` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4c101ff36ad919c3989da488cc469ee7681d9df22300f3ec18750bb7fb1d1f7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c101ff36ad919c3989da488cc469ee7681d9df22300f3ec18750bb7fb1d1f7d", kill_on_drop: false }` [INFO] [stdout] 4c101ff36ad919c3989da488cc469ee7681d9df22300f3ec18750bb7fb1d1f7d