[INFO] fetching crate salak 0.14.1... [INFO] checking salak-0.14.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate salak 0.14.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate salak 0.14.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate salak 0.14.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate salak 0.14.1 [INFO] tweaked toml for crates.io crate salak 0.14.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate salak 0.14.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de2b6a37d66570b02cb3db28ea6c6c47a792477c9f0de48fe2b455246def10cd [INFO] running `Command { std: "docker" "start" "-a" "de2b6a37d66570b02cb3db28ea6c6c47a792477c9f0de48fe2b455246def10cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de2b6a37d66570b02cb3db28ea6c6c47a792477c9f0de48fe2b455246def10cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de2b6a37d66570b02cb3db28ea6c6c47a792477c9f0de48fe2b455246def10cd", kill_on_drop: false }` [INFO] [stdout] de2b6a37d66570b02cb3db28ea6c6c47a792477c9f0de48fe2b455246def10cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af6b1e64d37d4ef2cd72f47b71171c865671eb3230e3ff693e554b2f83c69e1c [INFO] running `Command { std: "docker" "start" "-a" "af6b1e64d37d4ef2cd72f47b71171c865671eb3230e3ff693e554b2f83c69e1c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling libc v0.2.100 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.75 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_json v1.0.66 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Compiling trybuild v1.0.45 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking pad v0.1.6 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling salak_derive v0.8.0 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking salak v0.14.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] warning: fields `key`, `tp`, and `def` are never read [INFO] [stdout] --> src/derive.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) struct KeyDesc { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 47 | key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 48 | tp: &'static str, [INFO] [stdout] | ^^ [INFO] [stdout] 49 | pub(crate) required: Option, [INFO] [stdout] 50 | def: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KeyDesc` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `KeyDescs` is never constructed [INFO] [stdout] --> src/derive.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) struct KeyDescs(pub(crate) Vec); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:51:40 [INFO] [stdout] | [INFO] [stdout] 50 | fn from(err: E) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | PropertyError::ParseFail(None, Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_ioref.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 36 | fn new(key: &str, val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self(Arc::new(Mutex::new(val)), key.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_ioref.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | let guard = self.0.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(T::clone(&*guard)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_vec.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 59 | let v = >::from_env(val, env)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(NonEmptyVec(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:252:34 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn register(&mut self, provider: P) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | self.reg.register_by_ref(Box::new(provider)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_raw.rs:184:32 [INFO] [stdout] | [INFO] [stdout] 184 | .map(|f| match f.reload_source() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_raw.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 278 | sub_key: K, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let val = match self.registry.get(self.key, def) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | Ok(val) => Ok(T::from_env(val, self)), [INFO] [stdout] 284 | Err(e) => Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | match val? { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salak` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "af6b1e64d37d4ef2cd72f47b71171c865671eb3230e3ff693e554b2f83c69e1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af6b1e64d37d4ef2cd72f47b71171c865671eb3230e3ff693e554b2f83c69e1c", kill_on_drop: false }` [INFO] [stdout] af6b1e64d37d4ef2cd72f47b71171c865671eb3230e3ff693e554b2f83c69e1c