[INFO] fetching crate saikoro 1.2.4... [INFO] checking saikoro-1.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate saikoro 1.2.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate saikoro 1.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate saikoro 1.2.4 [INFO] finished tweaking crates.io crate saikoro 1.2.4 [INFO] tweaked toml for crates.io crate saikoro 1.2.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate saikoro 1.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 501ba33affddcbbc4e0571e95501e61dc6869c63c9880f1ca82eefdcc4c56e47 [INFO] running `Command { std: "docker" "start" "-a" "501ba33affddcbbc4e0571e95501e61dc6869c63c9880f1ca82eefdcc4c56e47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "501ba33affddcbbc4e0571e95501e61dc6869c63c9880f1ca82eefdcc4c56e47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "501ba33affddcbbc4e0571e95501e61dc6869c63c9880f1ca82eefdcc4c56e47", kill_on_drop: false }` [INFO] [stdout] 501ba33affddcbbc4e0571e95501e61dc6869c63c9880f1ca82eefdcc4c56e47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a20eee054aa200a8b3164db5b0b4cbce5368a10c4b6a63bfbdcc12b7b12e460b [INFO] running `Command { std: "docker" "start" "-a" "a20eee054aa200a8b3164db5b0b4cbce5368a10c4b6a63bfbdcc12b7b12e460b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling memchr v2.6.2 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.42 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.1.0 [INFO] [stderr] Checking lazy-regex v3.1.0 [INFO] [stderr] Checking saikoro v1.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 13 | parse_tree: Node, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let mut rolls = OrderedMap::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(DiceEvaluation { [INFO] [stdout] | ________^ [INFO] [stdout] 24 | | value, [INFO] [stdout] 25 | | roll_groups: rolls.values().cloned().collect(), [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation/operand.rs:161:10 [INFO] [stdout] | [INFO] [stdout] 159 | fn sub(self, rhs: Self) -> Self::Output [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | { [INFO] [stdout] 161 | self + -rhs [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation/roll_types.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(faces: u32, rolls: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | rolls: rolls.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/binary_op.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn eval(&self, lhs: Operand, rhs: Operand, random: &mut R) -> Operand [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | { [INFO] [stdout] 48 | self.eval_fn()(lhs, rhs, random) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/comp_op.rs:47:3 [INFO] [stdout] | [INFO] [stdout] 41 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | self.eval_fn()(dice_lhs, dice_rhs, compare_to, rand) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn unary_dice(operand: Operand, random: &mut R) -> Operand [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Operand::from(RollGroup::new(faces, [roll])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn dice(lhs: Operand, rhs: Operand, random: &mut R) -> Operand [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | { [INFO] [stdout] 50 | Operand::from(dice_roll( [INFO] [stdout] | ___________________^ [INFO] [stdout] 51 | | clamp_f64_to_u32(lhs.value()), [INFO] [stdout] 52 | | clamp_f64_to_u32(rhs.value()), [INFO] [stdout] 53 | | random, [INFO] [stdout] 54 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 58 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 65 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 66 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 67 | | compare_to, [INFO] [stdout] 68 | | |l, r| f64::from(l.original_value).approx_eq(r.value()), [INFO] [stdout] 69 | | random, [INFO] [stdout] 70 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:79:16 [INFO] [stdout] | [INFO] [stdout] 73 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 80 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 81 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 82 | | compare_to, [INFO] [stdout] 83 | | |l, r| !f64::from(l.original_value).approx_eq(r.value()), [INFO] [stdout] 84 | | random, [INFO] [stdout] 85 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 88 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 95 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 96 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 97 | | compare_to, [INFO] [stdout] 98 | | |l, r| f64::from(l.original_value) > r.value(), [INFO] [stdout] 99 | | random, [INFO] [stdout] 100 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:109:16 [INFO] [stdout] | [INFO] [stdout] 103 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 110 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 111 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 112 | | compare_to, [INFO] [stdout] 113 | | |l, r| f64::from(l.original_value) < r.value(), [INFO] [stdout] 114 | | random, [INFO] [stdout] 115 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:124:16 [INFO] [stdout] | [INFO] [stdout] 118 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 125 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 126 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 127 | | compare_to, [INFO] [stdout] 128 | | |l, r| f64::from(l.original_value) >= r.value(), [INFO] [stdout] 129 | | random, [INFO] [stdout] 130 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 133 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 140 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 141 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 142 | | compare_to, [INFO] [stdout] 143 | | |l, r| f64::from(l.original_value) <= r.value(), [INFO] [stdout] 144 | | random, [INFO] [stdout] 145 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/unary_op.rs:40:3 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn eval(&self, operand: Operand, rng: &mut R) -> Operand [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | { [INFO] [stdout] 40 | self.eval_fn()(operand, rng) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `saikoro` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 13 | parse_tree: Node, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let mut rolls = OrderedMap::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(DiceEvaluation { [INFO] [stdout] | ________^ [INFO] [stdout] 24 | | value, [INFO] [stdout] 25 | | roll_groups: rolls.values().cloned().collect(), [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation/operand.rs:161:10 [INFO] [stdout] | [INFO] [stdout] 159 | fn sub(self, rhs: Self) -> Self::Output [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | { [INFO] [stdout] 161 | self + -rhs [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation/roll_types.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(faces: u32, rolls: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | rolls: rolls.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/binary_op.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn eval(&self, lhs: Operand, rhs: Operand, random: &mut R) -> Operand [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | { [INFO] [stdout] 48 | self.eval_fn()(lhs, rhs, random) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/comp_op.rs:47:3 [INFO] [stdout] | [INFO] [stdout] 41 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | self.eval_fn()(dice_lhs, dice_rhs, compare_to, rand) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn unary_dice(operand: Operand, random: &mut R) -> Operand [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Operand::from(RollGroup::new(faces, [roll])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn dice(lhs: Operand, rhs: Operand, random: &mut R) -> Operand [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | { [INFO] [stdout] 50 | Operand::from(dice_roll( [INFO] [stdout] | ___________________^ [INFO] [stdout] 51 | | clamp_f64_to_u32(lhs.value()), [INFO] [stdout] 52 | | clamp_f64_to_u32(rhs.value()), [INFO] [stdout] 53 | | random, [INFO] [stdout] 54 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 58 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 65 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 66 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 67 | | compare_to, [INFO] [stdout] 68 | | |l, r| f64::from(l.original_value).approx_eq(r.value()), [INFO] [stdout] 69 | | random, [INFO] [stdout] 70 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:79:16 [INFO] [stdout] | [INFO] [stdout] 73 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 80 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 81 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 82 | | compare_to, [INFO] [stdout] 83 | | |l, r| !f64::from(l.original_value).approx_eq(r.value()), [INFO] [stdout] 84 | | random, [INFO] [stdout] 85 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 88 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 95 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 96 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 97 | | compare_to, [INFO] [stdout] 98 | | |l, r| f64::from(l.original_value) > r.value(), [INFO] [stdout] 99 | | random, [INFO] [stdout] 100 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:109:16 [INFO] [stdout] | [INFO] [stdout] 103 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 110 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 111 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 112 | | compare_to, [INFO] [stdout] 113 | | |l, r| f64::from(l.original_value) < r.value(), [INFO] [stdout] 114 | | random, [INFO] [stdout] 115 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:124:16 [INFO] [stdout] | [INFO] [stdout] 118 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 125 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 126 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 127 | | compare_to, [INFO] [stdout] 128 | | |l, r| f64::from(l.original_value) >= r.value(), [INFO] [stdout] 129 | | random, [INFO] [stdout] 130 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/function.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 133 | dice_lhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | dice_rhs: Operand, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | compare_to: Operand, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Operand::from(roll_compare( [INFO] [stdout] | ___________________^ [INFO] [stdout] 140 | | clamp_f64_to_u32(dice_lhs.value()), [INFO] [stdout] 141 | | clamp_f64_to_u32(dice_rhs.value()), [INFO] [stdout] 142 | | compare_to, [INFO] [stdout] 143 | | |l, r| f64::from(l.original_value) <= r.value(), [INFO] [stdout] 144 | | random, [INFO] [stdout] 145 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operator/unary_op.rs:40:3 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn eval(&self, operand: Operand, rng: &mut R) -> Operand [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | { [INFO] [stdout] 40 | self.eval_fn()(operand, rng) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(values: I) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | roll_queue: values.into_iter().map(|it| it.saturating_sub(1)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `saikoro` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "a20eee054aa200a8b3164db5b0b4cbce5368a10c4b6a63bfbdcc12b7b12e460b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a20eee054aa200a8b3164db5b0b4cbce5368a10c4b6a63bfbdcc12b7b12e460b", kill_on_drop: false }` [INFO] [stdout] a20eee054aa200a8b3164db5b0b4cbce5368a10c4b6a63bfbdcc12b7b12e460b