[INFO] fetching crate safeup 0.7.0... [INFO] checking safeup-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate safeup 0.7.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate safeup 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate safeup 0.7.0 [INFO] finished tweaking crates.io crate safeup 0.7.0 [INFO] tweaked toml for crates.io crate safeup 0.7.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate safeup 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3979e86c6f30629cedf99e4bd87527d840f0ad0952723a8e893f53e59f5ded7a [INFO] running `Command { std: "docker" "start" "-a" "3979e86c6f30629cedf99e4bd87527d840f0ad0952723a8e893f53e59f5ded7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3979e86c6f30629cedf99e4bd87527d840f0ad0952723a8e893f53e59f5ded7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3979e86c6f30629cedf99e4bd87527d840f0ad0952723a8e893f53e59f5ded7a", kill_on_drop: false }` [INFO] [stdout] 3979e86c6f30629cedf99e4bd87527d840f0ad0952723a8e893f53e59f5ded7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf433ac4b8cf6caf2edef3e133a4ddcb3766717e88a5071c16dea49cd1df785d [INFO] running `Command { std: "docker" "start" "-a" "bf433ac4b8cf6caf2edef3e133a4ddcb3766717e88a5071c16dea49cd1df785d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling async-trait v0.1.78 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking assert_fs v1.0.13 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.25 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking sn-releases v0.2.0 [INFO] [stderr] Checking safeup v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 138 | fn visit_some(self, deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | deserializer.deserialize_str(VersionVisitor).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:170:31 [INFO] [stdout] | [INFO] [stdout] 168 | serde_json::from_str(&contents).unwrap_or_else(|_| Settings { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | safe_path: None, [INFO] [stdout] 170 | safe_version: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:172:35 [INFO] [stdout] | [INFO] [stdout] 168 | serde_json::from_str(&contents).unwrap_or_else(|_| Settings { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | safenode_version: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:174:43 [INFO] [stdout] | [INFO] [stdout] 168 | serde_json::from_str(&contents).unwrap_or_else(|_| Settings { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | safenode_manager_version: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `safeup` (bin "safeup") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 138 | fn visit_some(self, deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | deserializer.deserialize_str(VersionVisitor).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:170:31 [INFO] [stdout] | [INFO] [stdout] 168 | serde_json::from_str(&contents).unwrap_or_else(|_| Settings { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | safe_path: None, [INFO] [stdout] 170 | safe_version: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:172:35 [INFO] [stdout] | [INFO] [stdout] 168 | serde_json::from_str(&contents).unwrap_or_else(|_| Settings { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | safenode_version: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:174:43 [INFO] [stdout] | [INFO] [stdout] 168 | serde_json::from_str(&contents).unwrap_or_else(|_| Settings { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | safenode_manager_version: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:514:36 [INFO] [stdout] | [INFO] [stdout] 499 | let latest_version_clone1 = latest_version.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 514 | .returning(move |_| Ok(latest_version_clone1.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:594:36 [INFO] [stdout] | [INFO] [stdout] 579 | let latest_version_clone1 = latest_version.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | .returning(move |_| Ok(latest_version_clone1.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `safeup` (bin "safeup" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "bf433ac4b8cf6caf2edef3e133a4ddcb3766717e88a5071c16dea49cd1df785d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf433ac4b8cf6caf2edef3e133a4ddcb3766717e88a5071c16dea49cd1df785d", kill_on_drop: false }` [INFO] [stdout] bf433ac4b8cf6caf2edef3e133a4ddcb3766717e88a5071c16dea49cd1df785d