[INFO] fetching crate safer_owning_ref 0.5.0... [INFO] checking safer_owning_ref-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate safer_owning_ref 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate safer_owning_ref 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate safer_owning_ref 0.5.0 [INFO] finished tweaking crates.io crate safer_owning_ref 0.5.0 [INFO] tweaked toml for crates.io crate safer_owning_ref 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5c22a5eb65c6af01c31ea17e370eade06d6097574f6d6d2b8129cd0fe9f6d66 [INFO] running `Command { std: "docker" "start" "-a" "c5c22a5eb65c6af01c31ea17e370eade06d6097574f6d6d2b8129cd0fe9f6d66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5c22a5eb65c6af01c31ea17e370eade06d6097574f6d6d2b8129cd0fe9f6d66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5c22a5eb65c6af01c31ea17e370eade06d6097574f6d6d2b8129cd0fe9f6d66", kill_on_drop: false }` [INFO] [stdout] c5c22a5eb65c6af01c31ea17e370eade06d6097574f6d6d2b8129cd0fe9f6d66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 234cc8888f175517b896b5ad5cd4c879c6afc70416d567b041013d50d482d073 [INFO] running `Command { std: "docker" "start" "-a" "234cc8888f175517b896b5ad5cd4c879c6afc70416d567b041013d50d482d073", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking safer_owning_ref v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1141:28 [INFO] [stdout] | [INFO] [stdout] 1141 | where O: Send, for<'a> (&'a T): Send {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1141 - where O: Send, for<'a> (&'a T): Send {} [INFO] [stdout] 1141 + where O: Send, for<'a> &'a T: Send {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1143:28 [INFO] [stdout] | [INFO] [stdout] 1143 | where O: Sync, for<'a> (&'a T): Sync {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1143 - where O: Sync, for<'a> (&'a T): Sync {} [INFO] [stdout] 1143 + where O: Sync, for<'a> &'a T: Sync {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1146:28 [INFO] [stdout] | [INFO] [stdout] 1146 | where O: Send, for<'a> (&'a mut T): Send {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1146 - where O: Send, for<'a> (&'a mut T): Send {} [INFO] [stdout] 1146 + where O: Send, for<'a> &'a mut T: Send {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1148:28 [INFO] [stdout] | [INFO] [stdout] 1148 | where O: Sync, for<'a> (&'a mut T): Sync {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1148 - where O: Sync, for<'a> (&'a mut T): Sync {} [INFO] [stdout] 1148 + where O: Sync, for<'a> &'a mut T: Sync {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1141:28 [INFO] [stdout] | [INFO] [stdout] 1141 | where O: Send, for<'a> (&'a T): Send {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1141 - where O: Send, for<'a> (&'a T): Send {} [INFO] [stdout] 1141 + where O: Send, for<'a> &'a T: Send {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1143:28 [INFO] [stdout] | [INFO] [stdout] 1143 | where O: Sync, for<'a> (&'a T): Sync {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1143 - where O: Sync, for<'a> (&'a T): Sync {} [INFO] [stdout] 1143 + where O: Sync, for<'a> &'a T: Sync {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1146:28 [INFO] [stdout] | [INFO] [stdout] 1146 | where O: Send, for<'a> (&'a mut T): Send {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1146 - where O: Send, for<'a> (&'a mut T): Send {} [INFO] [stdout] 1146 + where O: Send, for<'a> &'a mut T: Send {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1148:28 [INFO] [stdout] | [INFO] [stdout] 1148 | where O: Sync, for<'a> (&'a mut T): Sync {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1148 - where O: Sync, for<'a> (&'a mut T): Sync {} [INFO] [stdout] 1148 + where O: Sync, for<'a> &'a mut T: Sync {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:447:12 [INFO] [stdout] | [INFO] [stdout] 443 | pub fn try_map(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 448 | | reference: f(&self)?, [INFO] [stdout] 449 | | owner: self.owner, [INFO] [stdout] 450 | | marker: PhantomData, [INFO] [stdout] 451 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 466 | pub unsafe fn try_map_with_owner_direct(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | reference: f(&self.owner, &self)?, [INFO] [stdout] 472 | | owner: self.owner, [INFO] [stdout] 473 | | marker: PhantomData, [INFO] [stdout] 474 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:504:12 [INFO] [stdout] | [INFO] [stdout] 500 | pub fn try_map_with_owner(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 505 | | reference: f(&self.owner, &self)?, [INFO] [stdout] 506 | | owner: self.owner, [INFO] [stdout] 507 | | marker: PhantomData, [INFO] [stdout] 508 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:523:20 [INFO] [stdout] | [INFO] [stdout] 516 | pub unsafe fn map_owner(self, f: F) -> OwningRef<'t, P, T> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | owner: f(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:536:20 [INFO] [stdout] | [INFO] [stdout] 533 | pub fn map_owner_box(self) -> OwningRef<'t, Box, T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | owner: Box::new(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:578:20 [INFO] [stdout] | [INFO] [stdout] 573 | pub fn erase_owner<'a>(self) -> OwningRef<'t, O::Erased, T> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 578 | owner: self.owner.into_erased(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `safer_owning_ref` (lib) due to 13 previous errors; 4 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:730:12 [INFO] [stdout] | [INFO] [stdout] 726 | pub unsafe fn try_map(mut self, f: F) -> Result, E> [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 730 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 731 | | reference: f(&mut self)?, [INFO] [stdout] 732 | | owner: self.owner, [INFO] [stdout] 733 | | marker: PhantomData, [INFO] [stdout] 734 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:763:12 [INFO] [stdout] | [INFO] [stdout] 759 | pub fn try_map_mut(mut self, f: F) -> Result, E> [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 763 | Ok(OwningRefMut { [INFO] [stdout] | ____________^ [INFO] [stdout] 764 | | reference: f(&mut self)?, [INFO] [stdout] 765 | | owner: self.owner, [INFO] [stdout] 766 | | marker: PhantomData, [INFO] [stdout] 767 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:782:20 [INFO] [stdout] | [INFO] [stdout] 775 | pub unsafe fn map_owner(self, f: F) -> OwningRefMut<'t, P, T> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | owner: f(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:795:20 [INFO] [stdout] | [INFO] [stdout] 792 | pub fn map_owner_box(self) -> OwningRefMut<'t, Box, T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 795 | owner: Box::new(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:837:20 [INFO] [stdout] | [INFO] [stdout] 832 | pub fn erase_owner<'a>(self) -> OwningRefMut<'t, O::Erased, T> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 837 | owner: self.owner.into_erased(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:986:12 [INFO] [stdout] | [INFO] [stdout] 978 | pub fn try_new(o: O, f: F) -> Result [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 981 | let h: H; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 986 | Ok(OwningHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 987 | | handle: h, [INFO] [stdout] 988 | | _owner: o, [INFO] [stdout] 989 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `OwningRefMut::<'t, O, T>::map`: unsafe function. can create aliased references [INFO] [stdout] --> src/lib.rs:1778:50 [INFO] [stdout] | [INFO] [stdout] 1778 | let or: BoxRef<_, str> = unsafe { or.map(|_| "hello") }; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:1804:53 [INFO] [stdout] | [INFO] [stdout] 1804 | let mut_s: &'static mut [u8] = unsafe { &mut MUT_S }; [INFO] [stdout] | ^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 1804 | let mut_s: &'static mut [u8] = unsafe { addr_of_mut!(MUT_S) }; [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `OwningRefMut::<'t, O, T>::as_owner`: unsafe function. can create aliased references [INFO] [stdout] --> src/lib.rs:1843:40 [INFO] [stdout] | [INFO] [stdout] 1843 | assert_eq!(&** unsafe { or.as_owner() }, "hello world"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `OwningRefMut::<'t, O, T>::map`: unsafe function. can create aliased references [INFO] [stdout] --> src/lib.rs:2055:46 [INFO] [stdout] | [INFO] [stdout] 2055 | let or: BoxRef<()> = unsafe { or.map(|x| x) }; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:447:12 [INFO] [stdout] | [INFO] [stdout] 443 | pub fn try_map(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 448 | | reference: f(&self)?, [INFO] [stdout] 449 | | owner: self.owner, [INFO] [stdout] 450 | | marker: PhantomData, [INFO] [stdout] 451 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 466 | pub unsafe fn try_map_with_owner_direct(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | reference: f(&self.owner, &self)?, [INFO] [stdout] 472 | | owner: self.owner, [INFO] [stdout] 473 | | marker: PhantomData, [INFO] [stdout] 474 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:504:12 [INFO] [stdout] | [INFO] [stdout] 500 | pub fn try_map_with_owner(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 505 | | reference: f(&self.owner, &self)?, [INFO] [stdout] 506 | | owner: self.owner, [INFO] [stdout] 507 | | marker: PhantomData, [INFO] [stdout] 508 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:523:20 [INFO] [stdout] | [INFO] [stdout] 516 | pub unsafe fn map_owner(self, f: F) -> OwningRef<'t, P, T> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | owner: f(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:536:20 [INFO] [stdout] | [INFO] [stdout] 533 | pub fn map_owner_box(self) -> OwningRef<'t, Box, T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | owner: Box::new(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:578:20 [INFO] [stdout] | [INFO] [stdout] 573 | pub fn erase_owner<'a>(self) -> OwningRef<'t, O::Erased, T> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 578 | owner: self.owner.into_erased(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:730:12 [INFO] [stdout] | [INFO] [stdout] 726 | pub unsafe fn try_map(mut self, f: F) -> Result, E> [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 730 | Ok(OwningRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 731 | | reference: f(&mut self)?, [INFO] [stdout] 732 | | owner: self.owner, [INFO] [stdout] 733 | | marker: PhantomData, [INFO] [stdout] 734 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:763:12 [INFO] [stdout] | [INFO] [stdout] 759 | pub fn try_map_mut(mut self, f: F) -> Result, E> [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 763 | Ok(OwningRefMut { [INFO] [stdout] | ____________^ [INFO] [stdout] 764 | | reference: f(&mut self)?, [INFO] [stdout] 765 | | owner: self.owner, [INFO] [stdout] 766 | | marker: PhantomData, [INFO] [stdout] 767 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:782:20 [INFO] [stdout] | [INFO] [stdout] 775 | pub unsafe fn map_owner(self, f: F) -> OwningRefMut<'t, P, T> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | owner: f(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:795:20 [INFO] [stdout] | [INFO] [stdout] 792 | pub fn map_owner_box(self) -> OwningRefMut<'t, Box, T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 795 | owner: Box::new(self.owner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:837:20 [INFO] [stdout] | [INFO] [stdout] 832 | pub fn erase_owner<'a>(self) -> OwningRefMut<'t, O::Erased, T> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 837 | owner: self.owner.into_erased(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:986:12 [INFO] [stdout] | [INFO] [stdout] 978 | pub fn try_new(o: O, f: F) -> Result [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 981 | let h: H; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 986 | Ok(OwningHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 987 | | handle: h, [INFO] [stdout] 988 | | _owner: o, [INFO] [stdout] 989 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1674:68 [INFO] [stdout] | [INFO] [stdout] 1674 | let mut curr = OwningHandle::new_with_fn(curr, |x| unsafe { x.as_ref() }.unwrap().try_write().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1708:68 [INFO] [stdout] | [INFO] [stdout] 1708 | let mut curr = OwningHandle::new_with_fn(curr, |x| unsafe { x.as_ref() }.unwrap().try_write().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `safer_owning_ref` (lib test) due to 15 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "234cc8888f175517b896b5ad5cd4c879c6afc70416d567b041013d50d482d073", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "234cc8888f175517b896b5ad5cd4c879c6afc70416d567b041013d50d482d073", kill_on_drop: false }` [INFO] [stdout] 234cc8888f175517b896b5ad5cd4c879c6afc70416d567b041013d50d482d073