[INFO] fetching crate safecloset 1.3.2... [INFO] checking safecloset-1.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate safecloset 1.3.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate safecloset 1.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate safecloset 1.3.2 [INFO] finished tweaking crates.io crate safecloset 1.3.2 [INFO] tweaked toml for crates.io crate safecloset 1.3.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate safecloset 1.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f12509f82181568770d36507faa75d9aeee4c7520c4cca6948f073d5dc7cd1c [INFO] running `Command { std: "docker" "start" "-a" "7f12509f82181568770d36507faa75d9aeee4c7520c4cca6948f073d5dc7cd1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f12509f82181568770d36507faa75d9aeee4c7520c4cca6948f073d5dc7cd1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f12509f82181568770d36507faa75d9aeee4c7520c4cca6948f073d5dc7cd1c", kill_on_drop: false }` [INFO] [stdout] 7f12509f82181568770d36507faa75d9aeee4c7520c4cca6948f073d5dc7cd1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3365ef5de4c855b3c2b01a25229242885dedd90f8cf019549710bcf124bdf56b [INFO] running `Command { std: "docker" "start" "-a" "3365ef5de4c855b3c2b01a25229242885dedd90f8cf019549710bcf124bdf56b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling memchr v2.6.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling syn v2.0.31 [INFO] [stderr] Compiling aho-corasick v1.0.5 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling x11rb v0.12.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling crossbeam-queue v0.3.8 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking crossterm v0.23.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling regex-automata v0.3.8 [INFO] [stderr] Checking gethostname v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking x11rb-protocol v0.12.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking polyval v0.6.1 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking chrono v0.4.29 [INFO] [stderr] Checking blake2b_simd v0.5.11 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking proc-status v0.1.1 [INFO] [stderr] Compiling crokey-proc_macros v0.4.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking aes v0.8.3 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking coolor v0.8.0 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking minimad v0.13.0 [INFO] [stderr] Checking file-size v1.0.3 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking cli-log v2.0.0 [INFO] [stderr] Checking rust-argon2 v0.8.3 [INFO] [stderr] Checking secular v1.0.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking aes-gcm-siv v0.11.1 [INFO] [stderr] Checking char_reader v0.1.1 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling regex v1.9.5 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.0.1 [INFO] [stderr] Checking lazy-regex v3.0.1 [INFO] [stderr] Checking argh_shared v0.1.12 [INFO] [stderr] Checking termimad v0.26.1 [INFO] [stderr] Checking crokey v0.4.3 [INFO] [stderr] Checking rmp-serde v0.15.5 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking x11-clipboard v0.8.1 [INFO] [stderr] Checking terminal-clipboard v0.4.1 [INFO] [stderr] Checking safecloset v1.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `confirm::*` [INFO] [stdout] --> src/tui/menu/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | confirm::*, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `confirm::*` [INFO] [stdout] --> src/tui/menu/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | confirm::*, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bg` is never read [INFO] [stdout] --> src/tui/skin/content_skin.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct ContentSkin { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 18 | /// view background [INFO] [stdout] 19 | pub bg: Color, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bg` is never read [INFO] [stdout] --> src/tui/skin/content_skin.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct ContentSkin { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 18 | /// view background [INFO] [stdout] 19 | pub bg: Color, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/closet.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 211 | drawer: OpenDrawer, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | self.open_drawer(depth, &password).ok_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/closet.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 211 | drawer: OpenDrawer, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | self.open_drawer(depth, &password).ok_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/drawer_content.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 35 | let id = DrawerId::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let closet = Closet::new(depth + 1)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let garbage = Vec::new().into(); // will be (re)filled for save [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | id, [INFO] [stdout] 42 | | entries, [INFO] [stdout] 43 | | settings, [INFO] [stdout] 44 | | closet, [INFO] [stdout] 45 | | garbage, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/open_closet.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 111 | open_drawer: OpenDrawer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(self.take_deepest_open_drawer().unwrap()) // SAFETY: we just pushed back, so there's a drawer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/open_closet.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 294 | open_drawer: OpenDrawer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | Err(CoreError::InvalidDelete) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/open_drawer.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 38 | let cipher = closet.cipher(&self.password)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let nonce = nonce.as_slice().into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let id = self.content.id.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(ClosedDrawer::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | id, [INFO] [stdout] 49 | | nonce, [INFO] [stdout] 50 | | crypted_content.into_boxed_slice(), [INFO] [stdout] 51 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timer/mod.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 43 | let pair = Arc::new((Mutex::new(cmd), Condvar::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let timer_pair = Arc::clone(&pair); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (tx_ring, rx_ring) = bounded(1); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | (Self { pair }, rx_ring) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/app_state.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 38 | open_closet: OpenCloset, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let dialog = if args.open && !open_closet.just_created() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | drawer_state: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/drawer_content.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 35 | let id = DrawerId::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let closet = Closet::new(depth + 1)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let garbage = Vec::new().into(); // will be (re)filled for save [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | id, [INFO] [stdout] 42 | | entries, [INFO] [stdout] 43 | | settings, [INFO] [stdout] 44 | | closet, [INFO] [stdout] 45 | | garbage, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/open_closet.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 111 | open_drawer: OpenDrawer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(self.take_deepest_open_drawer().unwrap()) // SAFETY: we just pushed back, so there's a drawer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/open_closet.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 294 | open_drawer: OpenDrawer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | Err(CoreError::InvalidDelete) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/open_drawer.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 38 | let cipher = closet.cipher(&self.password)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let nonce = nonce.as_slice().into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let id = self.content.id.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(ClosedDrawer::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | id, [INFO] [stdout] 49 | | nonce, [INFO] [stdout] 50 | | crypted_content.into_boxed_slice(), [INFO] [stdout] 51 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timer/mod.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 43 | let pair = Arc::new((Mutex::new(cmd), Condvar::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let timer_pair = Arc::clone(&pair); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (tx_ring, rx_ring) = bounded(1); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | (Self { pair }, rx_ring) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/app_state.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 38 | open_closet: OpenCloset, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let dialog = if args.open && !open_closet.just_created() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | drawer_state: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/drawer_state.rs:611:12 [INFO] [stdout] | [INFO] [stdout] 599 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | drawer, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 610 | let drawer = open_closet.push_back_save_retake(drawer)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 611 | Ok(DrawerState { [INFO] [stdout] | ____________^ [INFO] [stdout] 612 | | drawer, [INFO] [stdout] 613 | | scroll, [INFO] [stdout] 614 | | focus, [INFO] [stdout] ... | [INFO] [stdout] 617 | | layout, [INFO] [stdout] 618 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/import/import_state.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 65 | dst_drawer_state: DrawerState, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | step: Step::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/drawer_state.rs:611:12 [INFO] [stdout] | [INFO] [stdout] 599 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | drawer, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 610 | let drawer = open_closet.push_back_save_retake(drawer)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 611 | Ok(DrawerState { [INFO] [stdout] | ____________^ [INFO] [stdout] 612 | | drawer, [INFO] [stdout] 613 | | scroll, [INFO] [stdout] 614 | | focus, [INFO] [stdout] ... | [INFO] [stdout] 617 | | layout, [INFO] [stdout] 618 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/import/import_state.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 65 | dst_drawer_state: DrawerState, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | step: Step::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `safecloset` (bin "safecloset" test) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `safecloset` (bin "safecloset") due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3365ef5de4c855b3c2b01a25229242885dedd90f8cf019549710bcf124bdf56b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3365ef5de4c855b3c2b01a25229242885dedd90f8cf019549710bcf124bdf56b", kill_on_drop: false }` [INFO] [stdout] 3365ef5de4c855b3c2b01a25229242885dedd90f8cf019549710bcf124bdf56b