[INFO] fetching crate sacrifice 0.3.0-alpha.3... [INFO] checking sacrifice-0.3.0-alpha.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sacrifice 0.3.0-alpha.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate sacrifice 0.3.0-alpha.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sacrifice 0.3.0-alpha.3 [INFO] finished tweaking crates.io crate sacrifice 0.3.0-alpha.3 [INFO] tweaked toml for crates.io crate sacrifice 0.3.0-alpha.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate sacrifice 0.3.0-alpha.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2781f533f633e7186194c5328f5417073c1fafd274c3c0332ba7afafddf36bda [INFO] running `Command { std: "docker" "start" "-a" "2781f533f633e7186194c5328f5417073c1fafd274c3c0332ba7afafddf36bda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2781f533f633e7186194c5328f5417073c1fafd274c3c0332ba7afafddf36bda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2781f533f633e7186194c5328f5417073c1fafd274c3c0332ba7afafddf36bda", kill_on_drop: false }` [INFO] [stdout] 2781f533f633e7186194c5328f5417073c1fafd274c3c0332ba7afafddf36bda [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe259586a5273c9c6352d093a7d9a8364078449a0d9edbc0adec504638054252 [INFO] running `Command { std: "docker" "start" "-a" "fe259586a5273c9c6352d093a7d9a8364078449a0d9edbc0adec504638054252", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking circular v0.3.0 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking shakmaty v0.26.0 [INFO] [stderr] Checking pgn-reader v0.25.0 [INFO] [stderr] Checking sacrifice v0.3.0-alpha.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game/node.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 56 | pub(crate) fn from_node(node: Self, move_next: Move) -> Option { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let ret = NodeImpl { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let ret = Rc::new(RefCell::new(ret)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | Some(Self(ret)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game/node.rs:138:18 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn set_variation_vec(&mut self, new_variation_vec: Vec) -> Vec { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | std::mem::replace( [INFO] [stdout] 138 | &mut self.0.borrow_mut().variation_vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sacrifice` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game/node.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 56 | pub(crate) fn from_node(node: Self, move_next: Move) -> Option { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let ret = NodeImpl { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let ret = Rc::new(RefCell::new(ret)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | Some(Self(ret)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game/node.rs:138:18 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn set_variation_vec(&mut self, new_variation_vec: Vec) -> Vec { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | std::mem::replace( [INFO] [stdout] 138 | &mut self.0.borrow_mut().variation_vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sacrifice` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "fe259586a5273c9c6352d093a7d9a8364078449a0d9edbc0adec504638054252", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe259586a5273c9c6352d093a7d9a8364078449a0d9edbc0adec504638054252", kill_on_drop: false }` [INFO] [stdout] fe259586a5273c9c6352d093a7d9a8364078449a0d9edbc0adec504638054252