[INFO] fetching crate s7 0.1.9... [INFO] checking s7-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate s7 0.1.9 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate s7 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s7 0.1.9 [INFO] finished tweaking crates.io crate s7 0.1.9 [INFO] tweaked toml for crates.io crate s7 0.1.9 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fa1dada0ba1534c33a0bcf357b482d43199920b867dc8113c97241d139653a4 [INFO] running `Command { std: "docker" "start" "-a" "4fa1dada0ba1534c33a0bcf357b482d43199920b867dc8113c97241d139653a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fa1dada0ba1534c33a0bcf357b482d43199920b867dc8113c97241d139653a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fa1dada0ba1534c33a0bcf357b482d43199920b867dc8113c97241d139653a4", kill_on_drop: false }` [INFO] [stdout] 4fa1dada0ba1534c33a0bcf357b482d43199920b867dc8113c97241d139653a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d50f3bc52999d5db38ea2596c1e748d411aa830192fba1f8508694ad4334a2a [INFO] running `Command { std: "docker" "start" "-a" "0d50f3bc52999d5db38ea2596c1e748d411aa830192fba1f8508694ad4334a2a", kill_on_drop: false }` [INFO] [stderr] Checking s7 v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `data_szl` [INFO] [stdout] --> src/client.rs:723:13 [INFO] [stdout] | [INFO] [stdout] 723 | let data_szl = 0; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_data_szl` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data_szl` [INFO] [stdout] --> src/client.rs:723:13 [INFO] [stdout] | [INFO] [stdout] 723 | let data_szl = 0; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_data_szl` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `module_type_name`, `serial_number`, `as_name`, `copyright`, and `module_name` are never read [INFO] [stdout] --> src/client.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct CpuInfo { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 14 | module_type_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 15 | serial_number: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 16 | as_name: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | copyright: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | module_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CpuInfo` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `max_pdu_length`, `max_connections`, `max_mpi_rate`, and `max_bus_rate` are never read [INFO] [stdout] --> src/client.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CPInfo { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 23 | max_pdu_length: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | max_connections: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 25 | max_mpi_rate: u16, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 26 | max_bus_rate: u16, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CPInfo` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `number_of_data_record` is never read [INFO] [stdout] --> src/transport.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 171 | pub(crate) struct SZLHeader { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 172 | pub length_header: u16, [INFO] [stdout] 173 | pub number_of_data_record: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(mut transport: T) -> Result, Error> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | transport.negotiate()?; [INFO] [stdout] 37 | Ok(Client { transport }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 79 | let tcp_client = TcpStream::connect(&options.address)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(Transport { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | options, [INFO] [stdout] 85 | | stream: Mutex::new(tcp_client), [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `module_type_name`, `serial_number`, `as_name`, `copyright`, and `module_name` are never read [INFO] [stdout] --> src/client.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct CpuInfo { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 14 | module_type_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 15 | serial_number: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 16 | as_name: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | copyright: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | module_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CpuInfo` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `max_pdu_length`, `max_connections`, `max_mpi_rate`, and `max_bus_rate` are never read [INFO] [stdout] --> src/client.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CPInfo { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 23 | max_pdu_length: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | max_connections: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 25 | max_mpi_rate: u16, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 26 | max_bus_rate: u16, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CPInfo` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `number_of_data_record` is never read [INFO] [stdout] --> src/transport.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 171 | pub(crate) struct SZLHeader { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 172 | pub length_header: u16, [INFO] [stdout] 173 | pub number_of_data_record: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(mut transport: T) -> Result, Error> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | transport.negotiate()?; [INFO] [stdout] 37 | Ok(Client { transport }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 79 | let tcp_client = TcpStream::connect(&options.address)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(Transport { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | options, [INFO] [stdout] 85 | | stream: Mutex::new(tcp_client), [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s7` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `s7` (lib) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0d50f3bc52999d5db38ea2596c1e748d411aa830192fba1f8508694ad4334a2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d50f3bc52999d5db38ea2596c1e748d411aa830192fba1f8508694ad4334a2a", kill_on_drop: false }` [INFO] [stdout] 0d50f3bc52999d5db38ea2596c1e748d411aa830192fba1f8508694ad4334a2a