[INFO] fetching crate s3m 0.10.0... [INFO] checking s3m-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate s3m 0.10.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate s3m 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s3m 0.10.0 [INFO] finished tweaking crates.io crate s3m 0.10.0 [INFO] tweaked toml for crates.io crate s3m 0.10.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate s3m 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 591728a77ce6cc9d0eb9eba9cacc255b3eb9b01d8e58fc0b94ed9222452ce061 [INFO] running `Command { std: "docker" "start" "-a" "591728a77ce6cc9d0eb9eba9cacc255b3eb9b01d8e58fc0b94ed9222452ce061", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "591728a77ce6cc9d0eb9eba9cacc255b3eb9b01d8e58fc0b94ed9222452ce061", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "591728a77ce6cc9d0eb9eba9cacc255b3eb9b01d8e58fc0b94ed9222452ce061", kill_on_drop: false }` [INFO] [stdout] 591728a77ce6cc9d0eb9eba9cacc255b3eb9b01d8e58fc0b94ed9222452ce061 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8c0dc3c16104dc53178fc847c1fc0dcc135098aa297e742a16042c630fb4637 [INFO] running `Command { std: "docker" "start" "-a" "a8c0dc3c16104dc53178fc847c1fc0dcc135098aa297e742a16042c630fb4637", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking xml-rs v0.8.20 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking temp-env v0.3.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking s3m v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/actions/object_put.rs:238:22 [INFO] [stdout] | [INFO] [stdout] 237 | .map_or(None, |additional_checksum| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Some(additional_checksum.context("could not calculate the additional checksum")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/progressbar.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 25 | let pb = ProgressBar::new(file_size); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | [INFO] [stdout] 27 | let style_result = ProgressStyle::default_bar() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let style = match style_result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Ok(style) => style, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Self { progress: Some(pb) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/progressbar.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 45 | let pb = ProgressBar::new_spinner(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let style_result = ProgressStyle::default_spinner() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let style = match style_result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Self { progress: Some(pb) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/progressbar.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 68 | let pb = ProgressBar::new_spinner(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let style_result = ProgressStyle::default_spinner() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let style = match style_result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Self { progress: Some(pb) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/start.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 37 | let cmd = commands::new(&config_path); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let matches = cmd.get_matches(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let config = Config::new(config_file)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let credentials = Credentials::new(&host.access_key, &host.secret_key); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let s3 = S3::new(&credentials, ®ion, bucket.clone(), no_sign_request); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok((s3, action, global_args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/checksum/mod.rs:189:61 [INFO] [stdout] | [INFO] [stdout] 189 | let digest = hasher.map(|hasher| Base64::encode_string(&hasher.finalize())); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/checksum/digest.rs:147:28 [INFO] [stdout] | [INFO] [stdout] 147 | || task::spawn(async { Ok(Bytes::default()) }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/request/mod.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | .map(|(k, v)| Ok((k.parse::()?, v.parse::()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/request/mod.rs:106:26 [INFO] [stdout] | [INFO] [stdout] 106 | .map(|(k, v)| Ok((k.parse::()?, v.parse::()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/request/mod.rs:158:26 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|(k, v)| Ok((k.parse::()?, v.parse::()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/signature/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(s3: &'a S3, aws_service: &'a str, http_method: Method) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | auth: s3, [INFO] [stdout] 40 | | aws_service, [INFO] [stdout] 41 | | http_method, [INFO] [stdout] 42 | | datetime: Utc::now(), [INFO] [stdout] 43 | | headers: BTreeMap::new(), [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/db.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 27 | let db = sled::Config::new() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { db, key }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/db.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | Ok(self.db_parts()?.insert(number.to_be_bytes(), cbor_part)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/db.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 136 | part.map(|part| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | / deserialize(&part[..]) [INFO] [stdout] 138 | | .map(|p: Part| { [INFO] [stdout] 139 | | ( [INFO] [stdout] 140 | | p.get_number(), [INFO] [stdout] ... | [INFO] [stdout] 146 | | ) [INFO] [stdout] 147 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/upload_multipart.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | .map(|p| deserialize(&p[..]).map_err(anyhow::Error::from)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s3m` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/actions/object_put.rs:238:22 [INFO] [stdout] | [INFO] [stdout] 237 | .map_or(None, |additional_checksum| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Some(additional_checksum.context("could not calculate the additional checksum")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/progressbar.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 25 | let pb = ProgressBar::new(file_size); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | [INFO] [stdout] 27 | let style_result = ProgressStyle::default_bar() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let style = match style_result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Ok(style) => style, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Self { progress: Some(pb) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/progressbar.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 45 | let pb = ProgressBar::new_spinner(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let style_result = ProgressStyle::default_spinner() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let style = match style_result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Self { progress: Some(pb) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/progressbar.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 68 | let pb = ProgressBar::new_spinner(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let style_result = ProgressStyle::default_spinner() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let style = match style_result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Self { progress: Some(pb) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/start.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 37 | let cmd = commands::new(&config_path); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let matches = cmd.get_matches(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let config = Config::new(config_file)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let credentials = Credentials::new(&host.access_key, &host.secret_key); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let s3 = S3::new(&credentials, ®ion, bucket.clone(), no_sign_request); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok((s3, action, global_args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/checksum/mod.rs:189:61 [INFO] [stdout] | [INFO] [stdout] 189 | let digest = hasher.map(|hasher| Base64::encode_string(&hasher.finalize())); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/checksum/digest.rs:147:28 [INFO] [stdout] | [INFO] [stdout] 147 | || task::spawn(async { Ok(Bytes::default()) }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/request/mod.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | .map(|(k, v)| Ok((k.parse::()?, v.parse::()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/request/mod.rs:106:26 [INFO] [stdout] | [INFO] [stdout] 106 | .map(|(k, v)| Ok((k.parse::()?, v.parse::()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/request/mod.rs:158:26 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|(k, v)| Ok((k.parse::()?, v.parse::()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/signature/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(s3: &'a S3, aws_service: &'a str, http_method: Method) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | auth: s3, [INFO] [stdout] 40 | | aws_service, [INFO] [stdout] 41 | | http_method, [INFO] [stdout] 42 | | datetime: Utc::now(), [INFO] [stdout] 43 | | headers: BTreeMap::new(), [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/db.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 27 | let db = sled::Config::new() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { db, key }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/db.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | Ok(self.db_parts()?.insert(number.to_be_bytes(), cbor_part)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/db.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 136 | part.map(|part| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | / deserialize(&part[..]) [INFO] [stdout] 138 | | .map(|p: Part| { [INFO] [stdout] 139 | | ( [INFO] [stdout] 140 | | p.get_number(), [INFO] [stdout] ... | [INFO] [stdout] 146 | | ) [INFO] [stdout] 147 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/upload_multipart.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | .map(|p| deserialize(&p[..]).map_err(anyhow::Error::from)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s3m` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "a8c0dc3c16104dc53178fc847c1fc0dcc135098aa297e742a16042c630fb4637", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8c0dc3c16104dc53178fc847c1fc0dcc135098aa297e742a16042c630fb4637", kill_on_drop: false }` [INFO] [stdout] a8c0dc3c16104dc53178fc847c1fc0dcc135098aa297e742a16042c630fb4637