[INFO] fetching crate s3-sync 0.4.0... [INFO] checking s3-sync-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate s3-sync 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate s3-sync 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s3-sync 0.4.0 [INFO] finished tweaking crates.io crate s3-sync 0.4.0 [INFO] tweaked toml for crates.io crate s3-sync 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 188 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.11.0 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding block-buffer v0.7.3 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.1.5 (latest: v0.3.3) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.1.2 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding crypto-mac v0.7.0 (latest: v0.11.1) [INFO] [stderr] Adding digest v0.8.1 (latest: v0.10.7) [INFO] [stderr] Adding dirs v1.0.5 (latest: v5.0.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.1.26 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.7.1 (latest: v0.12.1) [INFO] [stderr] Adding http v0.1.21 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.1.0 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.12.36 (latest: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.3.2 (latest: v0.6.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding redox_users v0.3.5 (latest: v0.4.6) [INFO] [stderr] Adding rusoto_core v0.42.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_credential v0.42.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_s3 v0.42.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_signature v0.42.0 (latest: v0.48.0) [INFO] [stderr] Adding rust-argon2 v0.8.3 (latest: v2.1.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding sha2 v0.8.2 (latest: v0.10.8) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding string v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding subtle v1.0.0 (latest: v2.6.1) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding want v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4731dfd554c65b695eed0f4b47753f69bdfa8d038bf8a6e8f077c78bafdc4908 [INFO] running `Command { std: "docker" "start" "-a" "4731dfd554c65b695eed0f4b47753f69bdfa8d038bf8a6e8f077c78bafdc4908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4731dfd554c65b695eed0f4b47753f69bdfa8d038bf8a6e8f077c78bafdc4908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4731dfd554c65b695eed0f4b47753f69bdfa8d038bf8a6e8f077c78bafdc4908", kill_on_drop: false }` [INFO] [stdout] 4731dfd554c65b695eed0f4b47753f69bdfa8d038bf8a6e8f077c78bafdc4908 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5d6d9b3f2bb98bab147014af0b162ae09a094ca85fbb65ca1d3f8ce43ba785e7 [INFO] running `Command { std: "docker" "start" "-a" "5d6d9b3f2bb98bab147014af0b162ae09a094ca85fbb65ca1d3f8ce43ba785e7", kill_on_drop: false }` [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling hyper v0.12.36 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking hmac v0.7.1 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Compiling rusoto_core v0.42.0 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking ensure v0.3.1 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking tokio-signal v0.2.9 [INFO] [stderr] Checking tokio-process v0.2.5 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking rusoto_credential v0.42.0 [INFO] [stderr] Checking hyper-tls v0.3.2 [INFO] [stderr] Checking problem v5.3.0 [INFO] [stderr] Checking rusoto_signature v0.42.0 [INFO] [stderr] Checking rusoto_s3 v0.42.0 [INFO] [stderr] Checking s3-sync v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:569:21 [INFO] [stdout] | [INFO] [stdout] 556 | region: impl Into>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 557 | region_endpoint: impl Into>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | settings: impl Into> [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | client: S3Client::new(region), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:570:33 [INFO] [stdout] | [INFO] [stdout] 556 | region: impl Into>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 557 | region_endpoint: impl Into>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | settings: impl Into> [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | on_upload_progress: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:742:24 [INFO] [stdout] | [INFO] [stdout] 734 | pages.flat_map(move |response| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 735 | let mut error = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 742 | unfold((), move |_| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 743 | | if let Some(error) = error.take() { [INFO] [stdout] 744 | | Some(Err(error)) [INFO] [stdout] 745 | | } else { [INFO] [stdout] 746 | | objects.as_mut().and_then(|obj| obj.next()).map(|o| Ok(Object::from_s3_object(bucket, o)?)) [INFO] [stdout] 747 | | } [INFO] [stdout] 748 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:763:50 [INFO] [stdout] | [INFO] [stdout] 763 | .and_then(|output| output.body.ok_or(S3SyncError::NoBodyError)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:780:45 [INFO] [stdout] | [INFO] [stdout] 780 | self._get_body(bucket, key).map(|r| Box::new(r) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:976:9 [INFO] [stdout] | [INFO] [stdout] 973 | bucket_keys: impl IntoIterator>> [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 976 | / bucket_keys [INFO] [stdout] 977 | | .into_iter() [INFO] [stdout] 978 | | .map(|o| o.into()) [INFO] [stdout] 979 | | .peekable() [INFO] [stdout] ... | [INFO] [stdout] 991 | | .collect::>())) [INFO] [stdout] 992 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1040:20 [INFO] [stdout] | [INFO] [stdout] 1007 | let ok_objects = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1021 | let mut failed_objects = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1040 | Ok(bucket_keys.into_iter().map(|k| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1041 | | if ok_objects.contains(&k.key) { [INFO] [stdout] 1042 | | Ok(Absent(k)) [INFO] [stdout] 1043 | | } else if let Some(err) = failed_objects.remove(&k.key) { [INFO] [stdout] ... | [INFO] [stdout] 1047 | | } [INFO] [stdout] 1048 | | }).collect::>()) // Option,>> [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1066:16 [INFO] [stdout] | [INFO] [stdout] 1062 | body: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1066 | Ok(match self.check_object_exists(bucket_key, check_impl)? { [INFO] [stdout] | ________________^ [INFO] [stdout] 1067 | | Left(present) => Met(present.into()), [INFO] [stdout] 1068 | | Right(absent) => EnsureAction(move || { [INFO] [stdout] 1069 | | let (body, meta) = body()?; [INFO] [stdout] 1070 | | self.put_object(absent, body, meta) [INFO] [stdout] 1071 | | }) [INFO] [stdout] 1072 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s3-sync` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:569:21 [INFO] [stdout] | [INFO] [stdout] 556 | region: impl Into>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 557 | region_endpoint: impl Into>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | settings: impl Into> [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | client: S3Client::new(region), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:570:33 [INFO] [stdout] | [INFO] [stdout] 556 | region: impl Into>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 557 | region_endpoint: impl Into>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | settings: impl Into> [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | on_upload_progress: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:742:24 [INFO] [stdout] | [INFO] [stdout] 734 | pages.flat_map(move |response| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 735 | let mut error = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 742 | unfold((), move |_| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 743 | | if let Some(error) = error.take() { [INFO] [stdout] 744 | | Some(Err(error)) [INFO] [stdout] 745 | | } else { [INFO] [stdout] 746 | | objects.as_mut().and_then(|obj| obj.next()).map(|o| Ok(Object::from_s3_object(bucket, o)?)) [INFO] [stdout] 747 | | } [INFO] [stdout] 748 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:763:50 [INFO] [stdout] | [INFO] [stdout] 763 | .and_then(|output| output.body.ok_or(S3SyncError::NoBodyError)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:780:45 [INFO] [stdout] | [INFO] [stdout] 780 | self._get_body(bucket, key).map(|r| Box::new(r) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:976:9 [INFO] [stdout] | [INFO] [stdout] 973 | bucket_keys: impl IntoIterator>> [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 976 | / bucket_keys [INFO] [stdout] 977 | | .into_iter() [INFO] [stdout] 978 | | .map(|o| o.into()) [INFO] [stdout] 979 | | .peekable() [INFO] [stdout] ... | [INFO] [stdout] 991 | | .collect::>())) [INFO] [stdout] 992 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1040:20 [INFO] [stdout] | [INFO] [stdout] 1007 | let ok_objects = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1021 | let mut failed_objects = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1040 | Ok(bucket_keys.into_iter().map(|k| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1041 | | if ok_objects.contains(&k.key) { [INFO] [stdout] 1042 | | Ok(Absent(k)) [INFO] [stdout] 1043 | | } else if let Some(err) = failed_objects.remove(&k.key) { [INFO] [stdout] ... | [INFO] [stdout] 1047 | | } [INFO] [stdout] 1048 | | }).collect::>()) // Option,>> [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1066:16 [INFO] [stdout] | [INFO] [stdout] 1062 | body: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1066 | Ok(match self.check_object_exists(bucket_key, check_impl)? { [INFO] [stdout] | ________________^ [INFO] [stdout] 1067 | | Left(present) => Met(present.into()), [INFO] [stdout] 1068 | | Right(absent) => EnsureAction(move || { [INFO] [stdout] 1069 | | let (body, meta) = body()?; [INFO] [stdout] 1070 | | self.put_object(absent, body, meta) [INFO] [stdout] 1071 | | }) [INFO] [stdout] 1072 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1211:45 [INFO] [stdout] | [INFO] [stdout] 1209 | let mut asserts = asserts.into_iter(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1210 | [INFO] [stdout] 1211 | s3.with_on_upload_progress(move |t| asserts.next().unwrap()(t), |s3| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s3-sync` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "5d6d9b3f2bb98bab147014af0b162ae09a094ca85fbb65ca1d3f8ce43ba785e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d6d9b3f2bb98bab147014af0b162ae09a094ca85fbb65ca1d3f8ce43ba785e7", kill_on_drop: false }` [INFO] [stdout] 5d6d9b3f2bb98bab147014af0b162ae09a094ca85fbb65ca1d3f8ce43ba785e7