[INFO] fetching crate s3-batch-put-tar 0.1.0... [INFO] checking s3-batch-put-tar-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate s3-batch-put-tar 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate s3-batch-put-tar 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s3-batch-put-tar 0.1.0 [INFO] finished tweaking crates.io crate s3-batch-put-tar 0.1.0 [INFO] tweaked toml for crates.io crate s3-batch-put-tar 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 187 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.11.0 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding core-foundation v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation-sys v0.7.0 (latest: v0.8.7) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding ct-logs v0.6.0 (latest: v0.9.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding dirs v2.0.2 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding h2 v0.2.7 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.8.1 (latest: v0.12.1) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.3.1 (latest: v1.0.1) [INFO] [stderr] Adding httpdate v0.3.2 (latest: v1.0.3) [INFO] [stderr] Adding hyper v0.13.10 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.20.0 (latest: v0.27.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding pin-project v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-internal v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rusoto_core v0.45.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_credential v0.45.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_s3 v0.45.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_signature v0.45.0 (latest: v0.48.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding rustls v0.17.0 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.3.0 (latest: v0.8.0) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding security-framework v0.4.4 (latest: v2.11.1) [INFO] [stderr] Adding security-framework-sys v0.4.3 (latest: v2.11.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding sha1 v0.6.1 (latest: v0.10.6) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding socket2 v0.3.19 (latest: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding standback v0.2.17 (latest: v0.4.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding time v0.2.27 (latest: v0.3.36) [INFO] [stderr] Adding time-macros v0.1.1 (latest: v0.2.18) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding tokio-rustls v0.13.1 (latest: v0.26.0) [INFO] [stderr] Adding tokio-util v0.3.1 (latest: v0.7.11) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_s3` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6035e63dd8b9364a4117c5829dd9a8e3b04a19dc23133d6f9d889d6ff15fc4e9 [INFO] running `Command { std: "docker" "start" "-a" "6035e63dd8b9364a4117c5829dd9a8e3b04a19dc23133d6f9d889d6ff15fc4e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6035e63dd8b9364a4117c5829dd9a8e3b04a19dc23133d6f9d889d6ff15fc4e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6035e63dd8b9364a4117c5829dd9a8e3b04a19dc23133d6f9d889d6ff15fc4e9", kill_on_drop: false }` [INFO] [stdout] 6035e63dd8b9364a4117c5829dd9a8e3b04a19dc23133d6f9d889d6ff15fc4e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ee0a539e5889a7e72e13b9dad24f50880a911b664f1e42e67f919005605c4d5 [INFO] running `Command { std: "docker" "start" "-a" "8ee0a539e5889a7e72e13b9dad24f50880a911b664f1e42e67f919005605c4d5", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_s3` dependency) [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Compiling const_fn v0.4.10 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking shlex v0.1.1 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rusoto_core v0.45.0 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking ct-logs v0.6.0 [INFO] [stderr] Checking rustls v0.17.0 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking rustls-native-certs v0.3.0 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.13.1 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking hyper v0.13.10 [INFO] [stderr] Checking rusoto_credential v0.45.0 [INFO] [stderr] Checking hyper-rustls v0.20.0 [INFO] [stderr] Checking rusoto_signature v0.45.0 [INFO] [stderr] Checking rusoto_s3 v0.45.0 [INFO] [stderr] Checking s3-batch-put-tar v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(start_time_ms: u64, output: W) -> Batch { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | output: tar::Builder::new(output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn process(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.rt.block_on(self.process_async()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:50 [INFO] [stdout] | [INFO] [stdout] 135 | let mut batch = current_batch.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | .spawn_blocking(move || (batch.put_object(req), batch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s3-batch-put-tar` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(start_time_ms: u64, output: W) -> Batch { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | output: tar::Builder::new(output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn process(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.rt.block_on(self.process_async()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:50 [INFO] [stdout] | [INFO] [stdout] 135 | let mut batch = current_batch.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | .spawn_blocking(move || (batch.put_object(req), batch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1070:67 [INFO] [stdout] | [INFO] [stdout] 1069 | input: PutObjectRequest, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1070 | ) -> Result> { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 1071 | | self.puts.lock().unwrap().borrow_mut().push(input); [INFO] [stdout] 1072 | | Ok(PutObjectOutput::default()) [INFO] [stdout] 1073 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1135:69 [INFO] [stdout] | [INFO] [stdout] 1134 | _input: UploadPartRequest, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1135 | ) -> Result> { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 1136 | | unimplemented!() [INFO] [stdout] 1137 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s3-batch-put-tar` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8ee0a539e5889a7e72e13b9dad24f50880a911b664f1e42e67f919005605c4d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ee0a539e5889a7e72e13b9dad24f50880a911b664f1e42e67f919005605c4d5", kill_on_drop: false }` [INFO] [stdout] 8ee0a539e5889a7e72e13b9dad24f50880a911b664f1e42e67f919005605c4d5