[INFO] fetching crate s2n-netbench-driver 0.1.0... [INFO] checking s2n-netbench-driver-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate s2n-netbench-driver 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate s2n-netbench-driver 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s2n-netbench-driver 0.1.0 [INFO] finished tweaking crates.io crate s2n-netbench-driver 0.1.0 [INFO] tweaked toml for crates.io crate s2n-netbench-driver 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 116 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bolero-generator v0.10.2 (latest: v0.11.1) [INFO] [stderr] Adding bolero-generator-derive v0.10.0 (latest: v0.11.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humansize v1.1.1 (latest: v2.1.3) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding s2n-codec v0.32.0 (latest: v0.45.0) [INFO] [stderr] Adding s2n-quic-core v0.32.0 (latest: v0.45.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b71e0438c808730adcc96e75a99233331339513bb8a98258c9e1889020b27ac [INFO] running `Command { std: "docker" "start" "-a" "7b71e0438c808730adcc96e75a99233331339513bb8a98258c9e1889020b27ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b71e0438c808730adcc96e75a99233331339513bb8a98258c9e1889020b27ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b71e0438c808730adcc96e75a99233331339513bb8a98258c9e1889020b27ac", kill_on_drop: false }` [INFO] [stdout] 7b71e0438c808730adcc96e75a99233331339513bb8a98258c9e1889020b27ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fec3f6ed62aded715dd9134e2a02cb62642621719745b35f5bbf22bf6465a132 [INFO] running `Command { std: "docker" "start" "-a" "fec3f6ed62aded715dd9134e2a02cb62642621719745b35f5bbf22bf6465a132", kill_on_drop: false }` [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling libmimalloc-sys v0.1.39 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking probe v0.5.1 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking mimalloc v0.1.43 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling enum-primitive-derive v0.3.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling bolero-generator-derive v0.10.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking bolero-generator v0.10.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures-test v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking s2n-codec v0.32.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking s2n-quic-core v0.32.0 [INFO] [stderr] Checking s2n-netbench v0.1.1 [INFO] [stderr] Checking s2n-netbench-driver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 237 | let scenario = scenario::Scenario::open(Path::new(s))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Ok(Self(Arc::new(scenario))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:12 [INFO] [stdout] | [INFO] [stdout] 253 | let throughput = if enabled && trace.iter().any(|v| matches!(v, Trace::Throughput)) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let trace = trace::Throughput::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | let stdio = if enabled && trace.iter().any(|v| matches!(v, Trace::Stdio)) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut trace = trace::StdioLogger::new(traces.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | (usdt, (throughput, stdio)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s2n-netbench-driver` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 237 | let scenario = scenario::Scenario::open(Path::new(s))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Ok(Self(Arc::new(scenario))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:12 [INFO] [stdout] | [INFO] [stdout] 253 | let throughput = if enabled && trace.iter().any(|v| matches!(v, Trace::Throughput)) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let trace = trace::Throughput::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | let stdio = if enabled && trace.iter().any(|v| matches!(v, Trace::Stdio)) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut trace = trace::StdioLogger::new(traces.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | (usdt, (throughput, stdio)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s2n-netbench-driver` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "fec3f6ed62aded715dd9134e2a02cb62642621719745b35f5bbf22bf6465a132", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fec3f6ed62aded715dd9134e2a02cb62642621719745b35f5bbf22bf6465a132", kill_on_drop: false }` [INFO] [stdout] fec3f6ed62aded715dd9134e2a02cb62642621719745b35f5bbf22bf6465a132