[INFO] fetching crate rxp 0.2.0... [INFO] checking rxp-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rxp 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rxp 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rxp 0.2.0 [INFO] finished tweaking crates.io crate rxp 0.2.0 [INFO] tweaked toml for crates.io crate rxp 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rxp 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60cb32a8eb698fad076d555610c9522ce720c6e13ece575843283146ba6c138c [INFO] running `Command { std: "docker" "start" "-a" "60cb32a8eb698fad076d555610c9522ce720c6e13ece575843283146ba6c138c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60cb32a8eb698fad076d555610c9522ce720c6e13ece575843283146ba6c138c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60cb32a8eb698fad076d555610c9522ce720c6e13ece575843283146ba6c138c", kill_on_drop: false }` [INFO] [stdout] 60cb32a8eb698fad076d555610c9522ce720c6e13ece575843283146ba6c138c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4ed50e4de87c1159ce03b79dc54180bb0ec8ff0243276cf51ee35672fcfd473 [INFO] running `Command { std: "docker" "start" "-a" "d4ed50e4de87c1159ce03b79dc54180bb0ec8ff0243276cf51ee35672fcfd473", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling semver v1.0.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking tracing-core v0.1.25 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking owo-colors v1.3.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling backtrace v0.3.64 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking color-spantrace v0.1.6 [INFO] [stderr] Checking color-eyre v0.5.11 [INFO] [stderr] Checking rxp v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 56 | fn sequence_expr(&mut self, a: Expr<'a>, b: Expr<'a>) -> Expr<'a> { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let id = self.get_id(); [INFO] [stdout] 58 | Expr::Sequence(SequenceExpr::new(id, a, b)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 61 | fn choice_expr(&mut self, start: Expr<'a>, end: Expr<'a>) -> Expr<'a> { [INFO] [stdout] | --------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let id = self.get_id(); [INFO] [stdout] 63 | Expr::Choice(ChoiceExpr::new(id, start, end)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:68:26 [INFO] [stdout] | [INFO] [stdout] 66 | fn repetition_expr(&mut self, n: Expr<'a>) -> Expr<'a> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let id = self.get_id(); [INFO] [stdout] 68 | Expr::Repetition(RepetitionExpr::new(id, n)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 71 | fn one_or_more_expr(&mut self, n: Expr<'a>) -> Expr<'a> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let id = self.get_id(); [INFO] [stdout] 73 | Expr::OneOrMore(OneOrMoreExpr::new(id, n)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(id: usize, a: Expr<'a>, b: Expr<'a>) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | a: Box::new(a), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(id: usize, a: Expr<'a>, b: Expr<'a>) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | b: Box::new(b), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(id: usize, start: Expr<'a>, end: Expr<'a>) -> Self { [INFO] [stdout] | --------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | start: Box::new(start), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(id: usize, start: Expr<'a>, end: Expr<'a>) -> Self { [INFO] [stdout] | --------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | end: Box::new(end), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(id: usize, term: Expr<'a>) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | term: Box::new(term), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(id: usize, term: Expr<'a>) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | term: Box::new(term), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn sequence(id: usize, a: Expr<'a>, b: Expr<'a>) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Self::Sequence(SequenceExpr::new(id, a, b)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:200:22 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn choice(id: usize, start: Expr<'a>, end: Expr<'a>) -> Self { [INFO] [stdout] | --------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | Self::Choice(ChoiceExpr::new(id, start, end)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:204:26 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn repetition(id: usize, n: Expr<'a>) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | Self::Repetition(RepetitionExpr::new(id, n)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:89:22 [INFO] [stdout] | [INFO] [stdout] 89 | .any(|x| x.transitions.borrow().is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:338:22 [INFO] [stdout] | [INFO] [stdout] 338 | .any(|x| x.transitions.borrow().is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rxp` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d4ed50e4de87c1159ce03b79dc54180bb0ec8ff0243276cf51ee35672fcfd473", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4ed50e4de87c1159ce03b79dc54180bb0ec8ff0243276cf51ee35672fcfd473", kill_on_drop: false }` [INFO] [stdout] d4ed50e4de87c1159ce03b79dc54180bb0ec8ff0243276cf51ee35672fcfd473