[INFO] fetching crate rxe 0.1.0... [INFO] checking rxe-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rxe 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rxe 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rxe 0.1.0 [INFO] finished tweaking crates.io crate rxe 0.1.0 [INFO] tweaked toml for crates.io crate rxe 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rxe 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae718d77cf004b17d154711f97c0c49c4aa1a3005979b1cba58e33ae8dfc59f2 [INFO] running `Command { std: "docker" "start" "-a" "ae718d77cf004b17d154711f97c0c49c4aa1a3005979b1cba58e33ae8dfc59f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae718d77cf004b17d154711f97c0c49c4aa1a3005979b1cba58e33ae8dfc59f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae718d77cf004b17d154711f97c0c49c4aa1a3005979b1cba58e33ae8dfc59f2", kill_on_drop: false }` [INFO] [stdout] ae718d77cf004b17d154711f97c0c49c4aa1a3005979b1cba58e33ae8dfc59f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d23a4483a003295bc25be9a0bceb8187e804026ac53f0e0d566a85333aa5d2cd [INFO] running `Command { std: "docker" "start" "-a" "d23a4483a003295bc25be9a0bceb8187e804026ac53f0e0d566a85333aa5d2cd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.38 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling syn v1.0.94 [INFO] [stderr] Compiling semver v1.0.9 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking once_cell v1.11.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling rstest v0.12.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking rxe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `helper::identify::Identify` [INFO] [stdout] --> src/constraints/text.rs:23:84 [INFO] [stdout] | [INFO] [stdout] 23 | use crate::{constraints::{Constraint, ValueParseError}, domain::ArgumentValue, helper::identify::Identify}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `helper::identify::Identify` [INFO] [stdout] --> src/constraints/flag.rs:46:84 [INFO] [stdout] | [INFO] [stdout] 46 | use crate::{constraints::{Constraint, ValueParseError}, domain::ArgumentValue, helper::identify::Identify}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::placeholder::fill::fill_first_placeholder` [INFO] [stdout] --> src/placeholder/mod.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | use crate::placeholder::fill::fill_first_placeholder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 38 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constraints/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | self.parse_value(value).map_err(ValueParseError::ParseFailed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|(k, v)| self.unwrap_parse_status(&k, v).map(|v| (k, v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | || Err(ParseError::InsufficientArgument) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/placeholder/parse.rs:10:54 [INFO] [stdout] | [INFO] [stdout] 10 | static PLACEHOLDER_REGEX: Lazy = Lazy::new(|| Regex::new(r"(^|[^\\]|\\\\)\{(.+?)}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rxe` (bin "rxe") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 38 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constraints/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | self.parse_value(value).map_err(ValueParseError::ParseFailed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constraints/choice.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 106 | let parsed = constraint.fallback(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | let error = parsed.expect_err("Should fail, but succeeded"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | assert_eq!(error, ValueParseError::ValueRequired) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constraints/number.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 82 | let parsed = NumberConstraint.fallback(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let error = parsed.expect_err("Should fail, but succeeded"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | assert_eq!(error, ValueParseError::ValueRequired) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constraints/text.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 37 | let parsed = TextConstraint.fallback(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | let error = parsed.expect_err("Should fail, but succeeded"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | assert_eq!(error, ValueParseError::ValueRequired) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constraints/flag.rs:63:27 [INFO] [stdout] | [INFO] [stdout] 60 | let parsed = FlagConstraint.parse_value(Some("thing")); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let error = parsed.expect_err("Should fail, but succeeded"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | assert_eq!(error, ValueParseError::ValueUneccesary) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|(k, v)| self.unwrap_parse_status(&k, v).map(|v| (k, v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | || Err(ParseError::InsufficientArgument) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:222:20 [INFO] [stdout] | [INFO] [stdout] 218 | fn decline_incorrect_input(input: Vec<&str>, expected: ParseError) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let result = parse(&config, &input); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | assert_eq!(result.unwrap_err(), expected) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/placeholder/parse.rs:10:54 [INFO] [stdout] | [INFO] [stdout] 10 | static PLACEHOLDER_REGEX: Lazy = Lazy::new(|| Regex::new(r"(^|[^\\]|\\\\)\{(.+?)}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rxe` (bin "rxe" test) due to 11 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d23a4483a003295bc25be9a0bceb8187e804026ac53f0e0d566a85333aa5d2cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d23a4483a003295bc25be9a0bceb8187e804026ac53f0e0d566a85333aa5d2cd", kill_on_drop: false }` [INFO] [stdout] d23a4483a003295bc25be9a0bceb8187e804026ac53f0e0d566a85333aa5d2cd