[INFO] fetching crate rx-editor 0.3.0... [INFO] checking rx-editor-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rx-editor 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rx-editor 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rx-editor 0.3.0 [INFO] finished tweaking crates.io crate rx-editor 0.3.0 [INFO] tweaked toml for crates.io crate rx-editor 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rx-editor 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 378a6787fce86faad2dc62103d2dd108f8784d45fe2453d47514d4cf00138621 [INFO] running `Command { std: "docker" "start" "-a" "378a6787fce86faad2dc62103d2dd108f8784d45fe2453d47514d4cf00138621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "378a6787fce86faad2dc62103d2dd108f8784d45fe2453d47514d4cf00138621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "378a6787fce86faad2dc62103d2dd108f8784d45fe2453d47514d4cf00138621", kill_on_drop: false }` [INFO] [stdout] 378a6787fce86faad2dc62103d2dd108f8784d45fe2453d47514d4cf00138621 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b0cbd65c7a32e722ac4b632d18e52037fa0091df0ea0071bb1862b52c529fc1 [INFO] running `Command { std: "docker" "start" "-a" "9b0cbd65c7a32e722ac4b632d18e52037fa0091df0ea0071bb1862b52c529fc1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling cc v1.0.40 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling pkg-config v0.3.15 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking atom v0.3.5 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Compiling x11 v2.18.1 [INFO] [stderr] Compiling cmake v0.1.41 [INFO] [stderr] Checking hibitset v0.6.2 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking colorful v0.2.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.5 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking raw-window-handle v0.3.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking gfx-hal v0.4.0 [INFO] [stderr] Checking ash v0.29.0 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling glfw-sys v3.3.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Checking copyless v0.1.4 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling proc-macro2 v1.0.1 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking backtrace v0.3.34 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking relevant v0.4.2 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Compiling syn v1.0.3 [INFO] [stderr] Checking rendy-descriptor v0.5.0 [INFO] [stderr] Checking rendy-memory v0.5.0 [INFO] [stderr] Checking gfx-backend-empty v0.4.0 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Checking nonempty v0.1.4 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking png v0.15.0 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking meowhash v0.1.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking snap v0.2.5 [INFO] [stderr] Checking pico-args v0.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.1.4 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking zerocopy v0.2.8 [INFO] [stderr] Checking glfw v0.34.0 [INFO] [stderr] Checking gfx-backend-vulkan v0.4.0 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking toml v0.5.5 [INFO] [stderr] Checking wgpu-native v0.4.1 [INFO] [stderr] Checking wgpu v0.4.0 [INFO] [stderr] Checking rgx v0.5.0 [INFO] [stderr] Checking rx-editor v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `winit` [INFO] [stdout] --> src/session.rs:503:23 [INFO] [stdout] | [INFO] [stdout] 503 | #[cfg(winit)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "winit"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(winit)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(winit)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `mutable_borrow_reservation_conflict` has been removed: now allowed, see issue #59159 for more information [INFO] [stdout] --> src/session.rs:2512:21 [INFO] [stdout] | [INFO] [stdout] 2512 | #[allow(mutable_borrow_reservation_conflict)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/parser.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | (c.is_ascii_lowercase() [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 331 | || [':', '/', '_', '+', '-', '!', '?'].contains(&c)) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 328 ~ c.is_ascii_lowercase() [INFO] [stdout] 329 | || c.is_ascii_uppercase() [INFO] [stdout] 330 | || c.is_ascii_digit() [INFO] [stdout] 331 ~ || [':', '/', '_', '+', '-', '!', '?'].contains(&c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value captured by `logical` is never read [INFO] [stdout] --> src/lib.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | logical = w.size(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: did you mean to capture by reference instead? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:256:68 [INFO] [stdout] | [INFO] [stdout] 256 | .run(|avg| session.update(&mut session_events, execution.clone(), delta, avg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 142 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let gif_recorder = if gif_mode == GifMode::Record { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let recorder = FrameRecorder::new(gif_recorder, gif_mode, digest_mode); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | [INFO] [stdout] 169 | Ok(Self::Recording { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | events: Vec::new(), [INFO] [stdout] 171 | | start: time::Instant::now(), [INFO] [stdout] 172 | | path: path.to_path_buf(), [INFO] [stdout] 173 | | digest, [INFO] [stdout] 174 | | recorder, [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution.rs:225:15 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn replaying>(path: P, mode: DigestMode) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let recorder = match &digest { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(f) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let r = io::BufReader::new(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | for line in r.lines() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | match File::open(&events_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution.rs:389:12 [INFO] [stdout] | [INFO] [stdout] 385 | pub fn new>(path: P, width: u16, height: u16) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | let file = Box::new(File::create(path.as_ref())?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | let encoder = Some(gif::Encoder::new(file, width, height, &[])?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | [INFO] [stdout] 389 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 390 | | width, [INFO] [stdout] 391 | | height, [INFO] [stdout] 392 | | encoder, [INFO] [stdout] 393 | | frames: Vec::new(), [INFO] [stdout] 394 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:796:31 [INFO] [stdout] | [INFO] [stdout] 777 | resources: ResourceManager, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 796 | settings_changed: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:800:27 [INFO] [stdout] | [INFO] [stdout] 777 | resources: ResourceManager, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 800 | key_bindings: KeyBindings::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:801:27 [INFO] [stdout] | [INFO] [stdout] 777 | resources: ResourceManager, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 801 | keys_pressed: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:2090:9 [INFO] [stdout] | [INFO] [stdout] 2086 | fn source_path>(&mut self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2090 | / File::open(&path) [INFO] [stdout] 2091 | | .or_else(|_| File::open(self.base_dirs.config_dir().join(path))) [INFO] [stdout] 2092 | | .and_then(|f| self.source_reader(io::BufReader::new(f), path)) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:2092:46 [INFO] [stdout] | [INFO] [stdout] 2092 | .and_then(|f| self.source_reader(io::BufReader::new(f), path)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 296 | let (press, p) = p.parse::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | let (release, p) = if let Ok((_, p)) = p.clone().sigil('{') { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | let (cmd, p) = p.parse::()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | KeyMapping { [INFO] [stdout] 308 | | key, [INFO] [stdout] 309 | | press, [INFO] [stdout] ... | [INFO] [stdout] 313 | | p, [INFO] [stdout] 314 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/glfw.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 18 | let mut glfw = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let (mut window, events) = glfw [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 38 | | Window { [INFO] [stdout] 39 | | handle: window, [INFO] [stdout] 40 | | redraw_requested: false, [INFO] [stdout] ... | [INFO] [stdout] 46 | | }, [INFO] [stdout] 47 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/glfw.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn run(mut win: Window, events: Events, mut callback: F) -> T [INFO] [stdout] | ------------------ -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut glfw = events.glfw; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | win.exit_reason.unwrap_or(T::default()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:212:22 [INFO] [stdout] | [INFO] [stdout] 196 | let vb = framebuffer2d::Pipeline::vertex_buffer(w, h, ZDepth::ZERO, r); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | [INFO] [stdout] 198 | let fb = r.framebuffer(w, h); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let binding = framebuffer2d.binding(r, &fb, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | let staging_fb = r.framebuffer(w, h); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let staging_binding = framebuffer2d.binding(r, &staging_fb, &sampler); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let anim_binding = sprite2d.binding(r, &fb.texture, &sampler); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | anim_vb: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:337:24 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn new(r: &mut core::Renderer, window: LogicalSize, resources: ResourceManager) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let sprite2d: kit::sprite2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | let shape2d: kit::shape2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let framebuffer2d: framebuffer2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | let view_transforms_buf = kit::TransformBuffer::with_capacity( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let (font, font_img) = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let (img, width, height) = image::decode(data::GLYPHS).unwrap(); [INFO] [stdout] 258 | let texture = r.texture(width, height); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let binding = sprite2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let mut cursor2d: cursor2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let (cursors, cursors_img) = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let (img, width, height) = image::decode(data::CURSORS).unwrap(); [INFO] [stdout] 270 | let texture = r.texture(width, height); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let binding = sprite2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let (checker, checker_img) = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let texture = r.texture(2, 2); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | let binding = sprite2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let brush2d = r.pipeline(Blending::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let const2d = r.pipeline(Blending::constant()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let paste2d: sprite2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | [INFO] [stdout] 296 | let paste = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let texture = r.texture(1, 1); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let binding = paste2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | let screen_vb = screen2d::Pipeline::vertex_buffer(r); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | let screen_fb = r.framebuffer(win_w, win_h); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let screen_binding = screen2d.binding(r, &screen_fb, &sampler); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | view_data: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:422:46 [INFO] [stdout] | [INFO] [stdout] 422 | enc.compress_vec(bytes).map(|v| Self(v.into_boxed_slice())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(x: T, y: T) -> Self { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Self(Point2::new(x, y)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rx-editor` (lib) due to 17 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unexpected `cfg` condition name: `winit` [INFO] [stdout] --> src/session.rs:503:23 [INFO] [stdout] | [INFO] [stdout] 503 | #[cfg(winit)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "winit"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(winit)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(winit)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `mutable_borrow_reservation_conflict` has been removed: now allowed, see issue #59159 for more information [INFO] [stdout] --> src/session.rs:2512:21 [INFO] [stdout] | [INFO] [stdout] 2512 | #[allow(mutable_borrow_reservation_conflict)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/parser.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | (c.is_ascii_lowercase() [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 331 | || [':', '/', '_', '+', '-', '!', '?'].contains(&c)) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 328 ~ c.is_ascii_lowercase() [INFO] [stdout] 329 | || c.is_ascii_uppercase() [INFO] [stdout] 330 | || c.is_ascii_digit() [INFO] [stdout] 331 ~ || [':', '/', '_', '+', '-', '!', '?'].contains(&c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value captured by `logical` is never read [INFO] [stdout] --> src/lib.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | logical = w.size(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: did you mean to capture by reference instead? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:256:68 [INFO] [stdout] | [INFO] [stdout] 256 | .run(|avg| session.update(&mut session_events, execution.clone(), delta, avg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 142 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let gif_recorder = if gif_mode == GifMode::Record { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let recorder = FrameRecorder::new(gif_recorder, gif_mode, digest_mode); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | [INFO] [stdout] 169 | Ok(Self::Recording { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | events: Vec::new(), [INFO] [stdout] 171 | | start: time::Instant::now(), [INFO] [stdout] 172 | | path: path.to_path_buf(), [INFO] [stdout] 173 | | digest, [INFO] [stdout] 174 | | recorder, [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution.rs:225:15 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn replaying>(path: P, mode: DigestMode) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let recorder = match &digest { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(f) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let r = io::BufReader::new(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | for line in r.lines() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | match File::open(&events_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution.rs:389:12 [INFO] [stdout] | [INFO] [stdout] 385 | pub fn new>(path: P, width: u16, height: u16) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | let file = Box::new(File::create(path.as_ref())?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | let encoder = Some(gif::Encoder::new(file, width, height, &[])?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | [INFO] [stdout] 389 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 390 | | width, [INFO] [stdout] 391 | | height, [INFO] [stdout] 392 | | encoder, [INFO] [stdout] 393 | | frames: Vec::new(), [INFO] [stdout] 394 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:796:31 [INFO] [stdout] | [INFO] [stdout] 777 | resources: ResourceManager, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 796 | settings_changed: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:800:27 [INFO] [stdout] | [INFO] [stdout] 777 | resources: ResourceManager, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 800 | key_bindings: KeyBindings::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:801:27 [INFO] [stdout] | [INFO] [stdout] 777 | resources: ResourceManager, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 801 | keys_pressed: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:2090:9 [INFO] [stdout] | [INFO] [stdout] 2086 | fn source_path>(&mut self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2090 | / File::open(&path) [INFO] [stdout] 2091 | | .or_else(|_| File::open(self.base_dirs.config_dir().join(path))) [INFO] [stdout] 2092 | | .and_then(|f| self.source_reader(io::BufReader::new(f), path)) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:2092:46 [INFO] [stdout] | [INFO] [stdout] 2092 | .and_then(|f| self.source_reader(io::BufReader::new(f), path)) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 296 | let (press, p) = p.parse::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | let (release, p) = if let Ok((_, p)) = p.clone().sigil('{') { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | let (cmd, p) = p.parse::()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | KeyMapping { [INFO] [stdout] 308 | | key, [INFO] [stdout] 309 | | press, [INFO] [stdout] ... | [INFO] [stdout] 313 | | p, [INFO] [stdout] 314 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/glfw.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 18 | let mut glfw = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let (mut window, events) = glfw [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 38 | | Window { [INFO] [stdout] 39 | | handle: window, [INFO] [stdout] 40 | | redraw_requested: false, [INFO] [stdout] ... | [INFO] [stdout] 46 | | }, [INFO] [stdout] 47 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/glfw.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn run(mut win: Window, events: Events, mut callback: F) -> T [INFO] [stdout] | ------------------ -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut glfw = events.glfw; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | win.exit_reason.unwrap_or(T::default()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:212:22 [INFO] [stdout] | [INFO] [stdout] 196 | let vb = framebuffer2d::Pipeline::vertex_buffer(w, h, ZDepth::ZERO, r); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | [INFO] [stdout] 198 | let fb = r.framebuffer(w, h); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let binding = framebuffer2d.binding(r, &fb, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | let staging_fb = r.framebuffer(w, h); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let staging_binding = framebuffer2d.binding(r, &staging_fb, &sampler); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let anim_binding = sprite2d.binding(r, &fb.texture, &sampler); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | anim_vb: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:337:24 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn new(r: &mut core::Renderer, window: LogicalSize, resources: ResourceManager) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let sprite2d: kit::sprite2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | let shape2d: kit::shape2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let framebuffer2d: framebuffer2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | let view_transforms_buf = kit::TransformBuffer::with_capacity( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let (font, font_img) = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let (img, width, height) = image::decode(data::GLYPHS).unwrap(); [INFO] [stdout] 258 | let texture = r.texture(width, height); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let binding = sprite2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let mut cursor2d: cursor2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let (cursors, cursors_img) = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let (img, width, height) = image::decode(data::CURSORS).unwrap(); [INFO] [stdout] 270 | let texture = r.texture(width, height); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let binding = sprite2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let (checker, checker_img) = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let texture = r.texture(2, 2); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | let binding = sprite2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let brush2d = r.pipeline(Blending::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let const2d = r.pipeline(Blending::constant()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let paste2d: sprite2d::Pipeline = r.pipeline(Blending::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | [INFO] [stdout] 296 | let paste = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let texture = r.texture(1, 1); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let binding = paste2d.binding(r, &texture, &sampler); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | let screen_vb = screen2d::Pipeline::vertex_buffer(r); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | let screen_fb = r.framebuffer(win_w, win_h); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let screen_binding = screen2d.binding(r, &screen_fb, &sampler); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | view_data: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:422:46 [INFO] [stdout] | [INFO] [stdout] 422 | enc.compress_vec(bytes).map(|v| Self(v.into_boxed_slice())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(x: T, y: T) -> Self { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Self(Point2::new(x, y)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rx-editor` (lib test) due to 17 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9b0cbd65c7a32e722ac4b632d18e52037fa0091df0ea0071bb1862b52c529fc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b0cbd65c7a32e722ac4b632d18e52037fa0091df0ea0071bb1862b52c529fc1", kill_on_drop: false }` [INFO] [stdout] 9b0cbd65c7a32e722ac4b632d18e52037fa0091df0ea0071bb1862b52c529fc1