[INFO] fetching crate rw-stream-sink 0.4.0... [INFO] checking rw-stream-sink-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rw-stream-sink 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rw-stream-sink 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rw-stream-sink 0.4.0 [INFO] finished tweaking crates.io crate rw-stream-sink 0.4.0 [INFO] tweaked toml for crates.io crate rw-stream-sink 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f019551b192f596b4c69f7809795477362966c734e1caf4657bf1f75f939b43 [INFO] running `Command { std: "docker" "start" "-a" "5f019551b192f596b4c69f7809795477362966c734e1caf4657bf1f75f939b43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f019551b192f596b4c69f7809795477362966c734e1caf4657bf1f75f939b43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f019551b192f596b4c69f7809795477362966c734e1caf4657bf1f75f939b43", kill_on_drop: false }` [INFO] [stdout] 5f019551b192f596b4c69f7809795477362966c734e1caf4657bf1f75f939b43 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fd5d6e4005f289b249fc2f94b52a0fd38cdf3e1c86de20c41019f3dcf0c6e72 [INFO] running `Command { std: "docker" "start" "-a" "2fd5d6e4005f289b249fc2f94b52a0fd38cdf3e1c86de20c41019f3dcf0c6e72", kill_on_drop: false }` [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rw-stream-sink v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | current_item: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 78 | *this.current_item = Some(match ready!(this.inner.as_mut().try_poll_next(cx)) { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Some(Ok(i)) => std::io::Cursor::new(i), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Some(Err(e)) => return Poll::Ready(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Poll::Ready(Ok(item_to_copy.read(buf)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rw-stream-sink` (lib) due to 3 previous errors [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | current_item: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 78 | *this.current_item = Some(match ready!(this.inner.as_mut().try_poll_next(cx)) { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Some(Ok(i)) => std::io::Cursor::new(i), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Some(Err(e)) => return Poll::Ready(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Poll::Ready(Ok(item_to_copy.read(buf)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 167 | let (tx1, _) = mpsc::channel::>(10); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let (mut tx2, rx2) = mpsc::channel(10); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | [INFO] [stdout] 170 | let mut wrapper = RwStreamSink::new(Wrapper(rx2.map(Ok), tx1)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | [INFO] [stdout] 172 | task::block_on(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 173 | | tx2.send(Vec::from("hel")).await.unwrap(); [INFO] [stdout] 174 | | tx2.send(Vec::from("lo wor")).await.unwrap(); [INFO] [stdout] 175 | | tx2.send(Vec::from("ld")).await.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 180 | | assert_eq!(data, b"hello world"); [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rw-stream-sink` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "2fd5d6e4005f289b249fc2f94b52a0fd38cdf3e1c86de20c41019f3dcf0c6e72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fd5d6e4005f289b249fc2f94b52a0fd38cdf3e1c86de20c41019f3dcf0c6e72", kill_on_drop: false }` [INFO] [stdout] 2fd5d6e4005f289b249fc2f94b52a0fd38cdf3e1c86de20c41019f3dcf0c6e72