[INFO] fetching crate rvideo 0.5.1... [INFO] checking rvideo-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rvideo 0.5.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rvideo 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate rvideo 0.5.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rvideo 0.5.1 [INFO] tweaked toml for crates.io crate rvideo 0.5.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rvideo 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8528252c2455c1a4c0a4f756324c71bc6b5687df9117402a79ca31e48379c981 [INFO] running `Command { std: "docker" "start" "-a" "8528252c2455c1a4c0a4f756324c71bc6b5687df9117402a79ca31e48379c981", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8528252c2455c1a4c0a4f756324c71bc6b5687df9117402a79ca31e48379c981", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8528252c2455c1a4c0a4f756324c71bc6b5687df9117402a79ca31e48379c981", kill_on_drop: false }` [INFO] [stdout] 8528252c2455c1a4c0a4f756324c71bc6b5687df9117402a79ca31e48379c981 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1afeb97de3577e428c93f67677023d15fbe89a6aff477196247273b599549ec4 [INFO] running `Command { std: "docker" "start" "-a" "1afeb97de3577e428c93f67677023d15fbe89a6aff477196247273b599549ec4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling binrw_derive v0.14.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling binrw v0.14.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking object-id v0.1.4 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking rulinalg v0.4.2 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking linux-futex v1.0.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking parking_lot_rt v0.12.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking imageproc v0.22.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking bma-ts v0.1.12 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling rtsc-derive v0.1.0 [INFO] [stderr] Checking rtsc v0.3.0 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking rvideo v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn send_frame(stream_id: u16, frame: Frame) -> Result<(), Error> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | DEFAULT_SERVER.send_frame(stream_id, frame) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn serve(addr: impl ToSocketAddrs + std::fmt::Debug) -> Result<(), Error> { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | DEFAULT_SERVER.serve(addr) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(data: Arc>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self { [INFO] [stdout] 70 | metadata: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:23 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(data: Arc>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Self { [INFO] [stdout] 81 | metadata: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new_with_metadata(metadata: Arc>, data: Arc>) -> Self { [INFO] [stdout] | ---------------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Self { [INFO] [stdout] 90 | metadata: Some(metadata), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn connect(addr: impl ToSocketAddrs, timeout: Duration) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut stream = TcpStream::connect_timeout( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | stream, [INFO] [stdout] 39 | | streams_available: greetings.streams_available, [INFO] [stdout] 40 | | ready: false, [INFO] [stdout] 41 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:101:14 [INFO] [stdout] | [INFO] [stdout] 81 | if let Err(e) = self.stream.read_exact(&mut buf) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Some(Ok(Frame { [INFO] [stdout] | ______________^ [INFO] [stdout] 102 | | metadata: metadata.map(Into::into), [INFO] [stdout] 103 | | data: data.into(), [INFO] [stdout] 104 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(Stream { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | id: stream_id, [INFO] [stdout] 57 | | server_inner: self.inner.clone(), [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rvideo` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1afeb97de3577e428c93f67677023d15fbe89a6aff477196247273b599549ec4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1afeb97de3577e428c93f67677023d15fbe89a6aff477196247273b599549ec4", kill_on_drop: false }` [INFO] [stdout] 1afeb97de3577e428c93f67677023d15fbe89a6aff477196247273b599549ec4