[INFO] fetching crate rv 0.17.0... [INFO] checking rv-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rv 0.17.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rv 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rv 0.17.0 [INFO] finished tweaking crates.io crate rv 0.17.0 [INFO] tweaked toml for crates.io crate rv 0.17.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rv 0.17.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6cf1666f2c66d402ad5877c31816758b81e615a7f0eb0453a33fdd5b5567831 [INFO] running `Command { std: "docker" "start" "-a" "e6cf1666f2c66d402ad5877c31816758b81e615a7f0eb0453a33fdd5b5567831", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6cf1666f2c66d402ad5877c31816758b81e615a7f0eb0453a33fdd5b5567831", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6cf1666f2c66d402ad5877c31816758b81e615a7f0eb0453a33fdd5b5567831", kill_on_drop: false }` [INFO] [stdout] e6cf1666f2c66d402ad5877c31816758b81e615a7f0eb0453a33fdd5b5567831 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f2625ff1ea3ebbac32b81f338cb30b7a30f27a6cc4a8541e6b7013ff0185c5db [INFO] running `Command { std: "docker" "start" "-a" "f2625ff1ea3ebbac32b81f338cb30b7a30f27a6cc4a8541e6b7013ff0185c5db", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking peroxide-num v0.1.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking puruspe v0.2.4 [INFO] [stderr] Checking order-stat v0.1.3 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking assert v0.7.5 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking special v0.10.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking thread-tree v0.3.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking num-bigint v0.4.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rv v0.17.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling peroxide-ad v0.3.0 [INFO] [stderr] Checking peroxide v0.37.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dist/mixture.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 130 | components: Vec, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(Mixture { [INFO] [stdout] | ____________^ [INFO] [stdout] 148 | | weights, [INFO] [stdout] 149 | | components, [INFO] [stdout] 150 | | ln_weights: OnceLock::new(), [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dist/mixture.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn new_unchecked(weights: Vec, components: Vec) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | ln_weights: OnceLock::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dist/mixture.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 381 | fn from(mut mm: Mixture) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | mm.weights.drain(..).zip(mm.components.drain(..)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dist/mixture.rs:804:5 [INFO] [stdout] | [INFO] [stdout] 794 | fn sort_mixture_by_mode(mm: Mixture) -> Mixture [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 798 | let mut components: Vec<(f64, Fx)> = mm.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 804 | Mixture::::try_from(components).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dist/skellam.rs:342:30 [INFO] [stdout] | [INFO] [stdout] 334 | let old_cache = self.bessel_iv_cache.borrow(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | let mut cache = LruCache::new(old_cache.cap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | bessel_iv_cache: RefCell::new(cache), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc/convergent_seq.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn aitken(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | self.tuple_windows::<(_, _, _)>().filter_map(|(x, y, z)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc/convergent_seq.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | fn limit(self, tol: f64) -> f64 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | / self.aitken() [INFO] [stdout] 53 | | .aitken() [INFO] [stdout] 54 | | .aitken() [INFO] [stdout] 55 | | .aitken() [INFO] [stdout] ... | [INFO] [stdout] 64 | | }, [INFO] [stdout] 65 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(fx: &Fx, pr: Arc) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | suffstat: fx.empty_suffstat(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 204 | pub fn new(pr: Pr, nx: usize) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | xs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rv` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f2625ff1ea3ebbac32b81f338cb30b7a30f27a6cc4a8541e6b7013ff0185c5db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2625ff1ea3ebbac32b81f338cb30b7a30f27a6cc4a8541e6b7013ff0185c5db", kill_on_drop: false }` [INFO] [stdout] f2625ff1ea3ebbac32b81f338cb30b7a30f27a6cc4a8541e6b7013ff0185c5db