[INFO] fetching crate ruwren 0.4.10... [INFO] checking ruwren-0.4.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ruwren 0.4.10 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ruwren 0.4.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ruwren 0.4.10 [INFO] finished tweaking crates.io crate ruwren 0.4.10 [INFO] tweaked toml for crates.io crate ruwren 0.4.10 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ruwren 0.4.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36bc4a382df84eeb476c23df7a908e11aaccbd67ee290058d3a1fb5f448283fc [INFO] running `Command { std: "docker" "start" "-a" "36bc4a382df84eeb476c23df7a908e11aaccbd67ee290058d3a1fb5f448283fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36bc4a382df84eeb476c23df7a908e11aaccbd67ee290058d3a1fb5f448283fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36bc4a382df84eeb476c23df7a908e11aaccbd67ee290058d3a1fb5f448283fc", kill_on_drop: false }` [INFO] [stdout] 36bc4a382df84eeb476c23df7a908e11aaccbd67ee290058d3a1fb5f448283fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b21f4f8e772ce97708a2a8ca00f763a8be5d17bed5f72e3187d9903b899caf72 [INFO] running `Command { std: "docker" "start" "-a" "b21f4f8e772ce97708a2a8ca00f763a8be5d17bed5f72e3187d9903b899caf72", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling prettyplease v0.2.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling bitflags v2.4.1 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling linux-raw-sys v0.4.12 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling bindgen v0.69.1 [INFO] [stderr] Compiling winnow v0.5.28 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Compiling arrayvec v0.7.4 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling if_chain v1.0.2 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling syn v2.0.40 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling deluxe-core v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling deluxe-macros v0.5.0 [INFO] [stderr] Compiling deluxe v0.5.0 [INFO] [stderr] Compiling ruwren-macros v0.4.10 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Compiling ruwren-sys v0.4.10 [INFO] [stderr] Checking ruwren v0.4.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:455:12 [INFO] [stdout] | [INFO] [stdout] 451 | pub fn execute(&self, f: F) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | f(&self.0.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1075:17 [INFO] [stdout] | [INFO] [stdout] 1073 | let signature = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1074 | ffi::CString::new(signature.as_wren_string()).expect("signature conversion failed"); [INFO] [stdout] 1075 | Rc::new(FunctionHandle(Handle { [INFO] [stdout] | _________________^ [INFO] [stdout] 1076 | | handle: unsafe { wren_sys::wrenMakeCallHandle(vm, signature.as_ptr()) }, [INFO] [stdout] 1077 | | wvm: vm, [INFO] [stdout] 1078 | | vm: marker::PhantomData, [INFO] [stdout] 1079 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/foreign_v2/convert.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 255 | fn convert(arr: [Option; N]) -> Option<[T; N]> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let arr = arr.into_iter().collect::>>()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Some( [INFO] [stdout] 258 | / arr.try_into() [INFO] [stdout] 259 | | .unwrap_or_else(|_| panic!("the array is of size {N}")), [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ruwren` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:455:12 [INFO] [stdout] | [INFO] [stdout] 451 | pub fn execute(&self, f: F) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | f(&self.0.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1075:17 [INFO] [stdout] | [INFO] [stdout] 1073 | let signature = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1074 | ffi::CString::new(signature.as_wren_string()).expect("signature conversion failed"); [INFO] [stdout] 1075 | Rc::new(FunctionHandle(Handle { [INFO] [stdout] | _________________^ [INFO] [stdout] 1076 | | handle: unsafe { wren_sys::wrenMakeCallHandle(vm, signature.as_ptr()) }, [INFO] [stdout] 1077 | | wvm: vm, [INFO] [stdout] 1078 | | vm: marker::PhantomData, [INFO] [stdout] 1079 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/foreign_v2/convert.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 255 | fn convert(arr: [Option; N]) -> Option<[T; N]> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let arr = arr.into_iter().collect::>>()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Some( [INFO] [stdout] 258 | / arr.try_into() [INFO] [stdout] 259 | | .unwrap_or_else(|_| panic!("the array is of size {N}")), [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ruwren` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "b21f4f8e772ce97708a2a8ca00f763a8be5d17bed5f72e3187d9903b899caf72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b21f4f8e772ce97708a2a8ca00f763a8be5d17bed5f72e3187d9903b899caf72", kill_on_drop: false }` [INFO] [stdout] b21f4f8e772ce97708a2a8ca00f763a8be5d17bed5f72e3187d9903b899caf72