[INFO] fetching crate ruw 0.0.2... [INFO] checking ruw-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ruw 0.0.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ruw 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ruw 0.0.2 [INFO] finished tweaking crates.io crate ruw 0.0.2 [INFO] tweaked toml for crates.io crate ruw 0.0.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate ruw 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 84977193312c15597541b9a5c3689b03fcef661df1163d9829655400dc4fe8fa [INFO] running `Command { std: "docker" "start" "-a" "84977193312c15597541b9a5c3689b03fcef661df1163d9829655400dc4fe8fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "84977193312c15597541b9a5c3689b03fcef661df1163d9829655400dc4fe8fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84977193312c15597541b9a5c3689b03fcef661df1163d9829655400dc4fe8fa", kill_on_drop: false }` [INFO] [stdout] 84977193312c15597541b9a5c3689b03fcef661df1163d9829655400dc4fe8fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68947972a77a975ba6194245050254dd2a15e05f9678b3ebe71cf33d4e3c0027 [INFO] running `Command { std: "docker" "start" "-a" "68947972a77a975ba6194245050254dd2a15e05f9678b3ebe71cf33d4e3c0027", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking value-bag v1.7.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.1.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling pin-project-internal v1.1.4 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking async-io v2.3.1 [INFO] [stderr] Checking pin-project v1.1.4 [INFO] [stderr] Checking ruw v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:11 [INFO] [stdout] | [INFO] [stdout] 110 | state: R::State, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | delta: R::Delta, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | track: R::TrackOne, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | ) -> Option<(R::State, R::TrackOne)> { [INFO] [stdout] 114 | match R::update(state, delta) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 173 | fn fallback_tail(self, prev: R::State) -> Tail { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | state: TailState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 177 | | next: self.state.fallback, [INFO] [stdout] 178 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:186:20 [INFO] [stdout] | [INFO] [stdout] 183 | fn success_tail(self, next: R::State) -> Tail { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | state: TailState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 187 | | next: self.state.success, [INFO] [stdout] 188 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:27 [INFO] [stdout] | [INFO] [stdout] 195 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | self.track.extend(HsIter:: { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 197 | | state: &mut self.state, [INFO] [stdout] 198 | | iter: iter.into_iter(), [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:242:20 [INFO] [stdout] | [INFO] [stdout] 239 | fn new(prev: R::State, next: R::State, track: R::TrackOne) -> Self { [INFO] [stdout] | -------------- -------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | state: TailState { next }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 239 | fn new(prev: R::State, next: R::State, track: R::TrackOne) -> Self { [INFO] [stdout] | -------------- -------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | track: R::many(track), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:249:19 [INFO] [stdout] | [INFO] [stdout] 247 | fn into_write_state(self) -> WriteState { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | WriteState { [INFO] [stdout] 249 | tail: Some(self), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:19 [INFO] [stdout] | [INFO] [stdout] 247 | fn into_write_state(self) -> WriteState { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | head: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:21 [INFO] [stdout] | [INFO] [stdout] 258 | fn writing>(self, write: &Write) -> Writing { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | Writing { [INFO] [stdout] 260 | future: self.write(write), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:261:20 [INFO] [stdout] | [INFO] [stdout] 258 | fn writing>(self, write: &Write) -> Writing { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | state: self.into_write_state(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:266:22 [INFO] [stdout] | [INFO] [stdout] 265 | fn into_state, Rf>(self, write: &Write) -> State { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | State::Write(self.writing(write)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:272:27 [INFO] [stdout] | [INFO] [stdout] 271 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | self.track.extend(TsIter:: { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 273 | | state: &mut self.state, [INFO] [stdout] 274 | | iter: iter.into_iter(), [INFO] [stdout] 275 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:288:14 [INFO] [stdout] | [INFO] [stdout] 286 | fn next_tail(&mut self, r: Result<(), R::Error>) -> Option> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | let tail = self.tail.take()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | Some(match r { [INFO] [stdout] | ______________^ [INFO] [stdout] 289 | | Ok(()) => { [INFO] [stdout] 290 | | R::accept(tail.track); [INFO] [stdout] 291 | | self.head.take()?.success_tail(tail.prev) [INFO] [stdout] ... | [INFO] [stdout] 296 | | } [INFO] [stdout] 297 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:393:27 [INFO] [stdout] | [INFO] [stdout] 392 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | self.track.extend(iter.into_iter().map(|(_, track)| track)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ruw` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "68947972a77a975ba6194245050254dd2a15e05f9678b3ebe71cf33d4e3c0027", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68947972a77a975ba6194245050254dd2a15e05f9678b3ebe71cf33d4e3c0027", kill_on_drop: false }` [INFO] [stdout] 68947972a77a975ba6194245050254dd2a15e05f9678b3ebe71cf33d4e3c0027