[INFO] fetching crate rustzx-core 0.16.0... [INFO] checking rustzx-core-0.16.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustzx-core 0.16.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rustzx-core 0.16.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustzx-core 0.16.0 [INFO] finished tweaking crates.io crate rustzx-core 0.16.0 [INFO] tweaked toml for crates.io crate rustzx-core 0.16.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding darling v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding from_variants v0.6.0 (latest: v1.0.2) [INFO] [stderr] Adding from_variants_impl v0.6.0 (latest: v1.0.2) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding strsim v0.9.3 (latest: v0.11.1) [INFO] [stderr] Adding strum v0.22.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.22.0 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e5127219af7dfdfe6ad08f522335509e37923c5d711cf89029b534a3d900e30 [INFO] running `Command { std: "docker" "start" "-a" "3e5127219af7dfdfe6ad08f522335509e37923c5d711cf89029b534a3d900e30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e5127219af7dfdfe6ad08f522335509e37923c5d711cf89029b534a3d900e30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e5127219af7dfdfe6ad08f522335509e37923c5d711cf89029b534a3d900e30", kill_on_drop: false }` [INFO] [stdout] 3e5127219af7dfdfe6ad08f522335509e37923c5d711cf89029b534a3d900e30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1e7e868a2f2d3f923bbe22b8a97cf72be4727ddce93e7a8eee343aa85f8e543 [INFO] running `Command { std: "docker" "start" "-a" "c1e7e868a2f2d3f923bbe22b8a97cf72be4727ddce93e7a8eee343aa85f8e543", kill_on_drop: false }` [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking rustzx-z80 v0.16.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling from_variants_impl v0.6.0 [INFO] [stderr] Checking from_variants v0.6.0 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking rustzx-core v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zx/video/screen.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(machine: ZXMachine, context: FB::Context) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | buffer: FB::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 104 | | CANVAS_WIDTH, [INFO] [stdout] 105 | | CANVAS_HEIGHT, [INFO] [stdout] 106 | | FrameBufferSource::Screen, [INFO] [stdout] 107 | | context.clone(), [INFO] [stdout] 108 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zx/video/screen.rs:109:26 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(machine: ZXMachine, context: FB::Context) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | back_buffer: FB::new( [INFO] [stdout] | __________________________^ [INFO] [stdout] 110 | | CANVAS_WIDTH, [INFO] [stdout] 111 | | CANVAS_HEIGHT, [INFO] [stdout] 112 | | FrameBufferSource::Screen, [INFO] [stdout] 113 | | context, [INFO] [stdout] 114 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zx/video/screen.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(machine: ZXMachine, context: FB::Context) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | banks: [ [INFO] [stdout] | ____________________^ [INFO] [stdout] 116 | | ScreenBank { [INFO] [stdout] 117 | | attributes: Box::new([ZXAttribute::from_byte(0); ATTR_COLS * ATTR_ROWS]), [INFO] [stdout] 118 | | bitmap: Box::new([0; ATTR_COLS * CANVAS_HEIGHT]), [INFO] [stdout] ... | [INFO] [stdout] 123 | | }, [INFO] [stdout] 124 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustzx-core` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zx/video/screen.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(machine: ZXMachine, context: FB::Context) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | buffer: FB::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 104 | | CANVAS_WIDTH, [INFO] [stdout] 105 | | CANVAS_HEIGHT, [INFO] [stdout] 106 | | FrameBufferSource::Screen, [INFO] [stdout] 107 | | context.clone(), [INFO] [stdout] 108 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zx/video/screen.rs:109:26 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(machine: ZXMachine, context: FB::Context) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | back_buffer: FB::new( [INFO] [stdout] | __________________________^ [INFO] [stdout] 110 | | CANVAS_WIDTH, [INFO] [stdout] 111 | | CANVAS_HEIGHT, [INFO] [stdout] 112 | | FrameBufferSource::Screen, [INFO] [stdout] 113 | | context, [INFO] [stdout] 114 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustzx-core` (lib) due to 4 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zx/video/screen.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(machine: ZXMachine, context: FB::Context) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | banks: [ [INFO] [stdout] | ____________________^ [INFO] [stdout] 116 | | ScreenBank { [INFO] [stdout] 117 | | attributes: Box::new([ZXAttribute::from_byte(0); ATTR_COLS * ATTR_ROWS]), [INFO] [stdout] 118 | | bitmap: Box::new([0; ATTR_COLS * CANVAS_HEIGHT]), [INFO] [stdout] ... | [INFO] [stdout] 123 | | }, [INFO] [stdout] 124 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "c1e7e868a2f2d3f923bbe22b8a97cf72be4727ddce93e7a8eee343aa85f8e543", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1e7e868a2f2d3f923bbe22b8a97cf72be4727ddce93e7a8eee343aa85f8e543", kill_on_drop: false }` [INFO] [stdout] c1e7e868a2f2d3f923bbe22b8a97cf72be4727ddce93e7a8eee343aa85f8e543