[INFO] fetching crate rustypipes 0.1.1... [INFO] checking rustypipes-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustypipes 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rustypipes 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustypipes 0.1.1 [INFO] finished tweaking crates.io crate rustypipes 0.1.1 [INFO] tweaked toml for crates.io crate rustypipes 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding errno v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c253d72982e1df9d19a90bf9e8ddc09c5504d409f1a9b73c5cadde475a4d07e [INFO] running `Command { std: "docker" "start" "-a" "7c253d72982e1df9d19a90bf9e8ddc09c5504d409f1a9b73c5cadde475a4d07e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c253d72982e1df9d19a90bf9e8ddc09c5504d409f1a9b73c5cadde475a4d07e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c253d72982e1df9d19a90bf9e8ddc09c5504d409f1a9b73c5cadde475a4d07e", kill_on_drop: false }` [INFO] [stdout] 7c253d72982e1df9d19a90bf9e8ddc09c5504d409f1a9b73c5cadde475a4d07e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b74e61096114481aa1aab6eca5354a754e4bbe1ae18ac2f2963bf59f16038291 [INFO] running `Command { std: "docker" "start" "-a" "b74e61096114481aa1aab6eca5354a754e4bbe1ae18ac2f2963bf59f16038291", kill_on_drop: false }` [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking unix-named-pipe v0.2.0 [INFO] [stderr] Checking rustypipes v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/client.rs:471:22 [INFO] [stdout] | [INFO] [stdout] 471 | Ok(_) => drop(self), [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesClient` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/client.rs:472:34 [INFO] [stdout] | [INFO] [stdout] 472 | Err(error) => panic!(error), //Don't worry, it won't panic [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 472 | Err(error) => panic!("{}", error), //Don't worry, it won't panic [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 472 | Err(error) => std::panic::panic_any(error), //Don't worry, it won't panic [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/server.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 307 | drop(worker); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesServerWorker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 307 - drop(worker); [INFO] [stdout] 307 + let _ = worker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/server.rs:697:9 [INFO] [stdout] | [INFO] [stdout] 697 | drop(self); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesServer` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 697 - drop(self); [INFO] [stdout] 697 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:770:12 [INFO] [stdout] | [INFO] [stdout] 722 | let worker_active: Arc> = Arc::new(Mutex::new(true)); //True [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 723 | let thread_active: Arc> = Arc::clone(&worker_active); //Clone active for thread [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | //Create channel [INFO] [stdout] 725 | let (worker_sender, worker_receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 726 | //Start thread [INFO] [stdout] 727 | let join_handle = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 770 | Ok(OctopipesServerWorker { [INFO] [stdout] | ____________^ [INFO] [stdout] 771 | | client_id: client_id, [INFO] [stdout] 772 | | subscription: subscriptions_obj, [INFO] [stdout] 773 | | pipe_read: cli_pipe_tx, //Invert pipes for Server [INFO] [stdout] ... | [INFO] [stdout] 777 | | receiver: worker_receiver, [INFO] [stdout] 778 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/server.rs:852:9 [INFO] [stdout] | [INFO] [stdout] 852 | drop(self); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesServerWorker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 852 - drop(self); [INFO] [stdout] 852 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustypipes` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/client.rs:471:22 [INFO] [stdout] | [INFO] [stdout] 471 | Ok(_) => drop(self), [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesClient` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/client.rs:472:34 [INFO] [stdout] | [INFO] [stdout] 472 | Err(error) => panic!(error), //Don't worry, it won't panic [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 472 | Err(error) => panic!("{}", error), //Don't worry, it won't panic [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 472 | Err(error) => std::panic::panic_any(error), //Don't worry, it won't panic [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipes/mod.rs:242:15 [INFO] [stdout] | [INFO] [stdout] 201 | let join_hnd: thread::JoinHandle<()> = thread::spawn(move || { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | match pipe_delete(&pipe_rx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/server.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 307 | drop(worker); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesServerWorker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 307 - drop(worker); [INFO] [stdout] 307 + let _ = worker; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/server.rs:697:9 [INFO] [stdout] | [INFO] [stdout] 697 | drop(self); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesServer` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 697 - drop(self); [INFO] [stdout] 697 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:770:12 [INFO] [stdout] | [INFO] [stdout] 722 | let worker_active: Arc> = Arc::new(Mutex::new(true)); //True [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 723 | let thread_active: Arc> = Arc::clone(&worker_active); //Clone active for thread [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | //Create channel [INFO] [stdout] 725 | let (worker_sender, worker_receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 726 | //Start thread [INFO] [stdout] 727 | let join_handle = thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 770 | Ok(OctopipesServerWorker { [INFO] [stdout] | ____________^ [INFO] [stdout] 771 | | client_id: client_id, [INFO] [stdout] 772 | | subscription: subscriptions_obj, [INFO] [stdout] 773 | | pipe_read: cli_pipe_tx, //Invert pipes for Server [INFO] [stdout] ... | [INFO] [stdout] 777 | | receiver: worker_receiver, [INFO] [stdout] 778 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/server.rs:852:9 [INFO] [stdout] | [INFO] [stdout] 852 | drop(self); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut OctopipesServerWorker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 852 - drop(self); [INFO] [stdout] 852 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustypipes` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b74e61096114481aa1aab6eca5354a754e4bbe1ae18ac2f2963bf59f16038291", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b74e61096114481aa1aab6eca5354a754e4bbe1ae18ac2f2963bf59f16038291", kill_on_drop: false }` [INFO] [stdout] b74e61096114481aa1aab6eca5354a754e4bbe1ae18ac2f2963bf59f16038291