[INFO] fetching crate rustyline 14.0.0... [INFO] checking rustyline-14.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustyline 14.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rustyline 14.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustyline 14.0.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rustyline 14.0.0 [INFO] tweaked toml for crates.io crate rustyline 14.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rustyline 14.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 555cebd6025cfcb7782b4b9f4c351f86c4549c793b4f57aa59809ec47890dae5 [INFO] running `Command { std: "docker" "start" "-a" "555cebd6025cfcb7782b4b9f4c351f86c4549c793b4f57aa59809ec47890dae5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "555cebd6025cfcb7782b4b9f4c351f86c4549c793b4f57aa59809ec47890dae5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "555cebd6025cfcb7782b4b9f4c351f86c4549c793b4f57aa59809ec47890dae5", kill_on_drop: false }` [INFO] [stdout] 555cebd6025cfcb7782b4b9f4c351f86c4549c793b4f57aa59809ec47890dae5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c408797f8b7a9da38e8793db0a90936edd1e42bea83217704dd699e83d226499 [INFO] running `Command { std: "docker" "start" "-a" "c408797f8b7a9da38e8793db0a90936edd1e42bea83217704dd699e83d226499", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rustyline v14.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:624:12 [INFO] [stdout] | [INFO] [stdout] 615 | pub fn with_history(config: Config, history: I) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 616 | let term = Terminal::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 625 | | term, [INFO] [stdout] 626 | | buffer: None, [INFO] [stdout] 627 | | history, [INFO] [stdout] ... | [INFO] [stdout] 631 | | custom_bindings: Bindings::new(), [INFO] [stdout] 632 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:866:55 [INFO] [stdout] | [INFO] [stdout] 862 | key_seq: E, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 863 | handler: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 866 | .insert(Event::normalize(key_seq.into()), handler.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:735:23 [INFO] [stdout] | [INFO] [stdout] 735 | .map(|pr| pr.lock().unwrap().0.as_raw_fd()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1339:12 [INFO] [stdout] | [INFO] [stdout] 1309 | let tty = OpenOptions::new().read(true).write(true).open("/dev/tty"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1310 | if let Ok(tty) = tty { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1339 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1340 | | unsupported, [INFO] [stdout] 1341 | | tty_in, [INFO] [stdout] 1342 | | is_in_a_tty, [INFO] [stdout] ... | [INFO] [stdout] 1354 | | enable_signals, [INFO] [stdout] 1355 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1400:12 [INFO] [stdout] | [INFO] [stdout] 1400 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 1401 | | PosixMode { [INFO] [stdout] 1402 | | termios: original_mode, [INFO] [stdout] 1403 | | tty_in: self.tty_in, [INFO] [stdout] ... | [INFO] [stdout] 1407 | | key_map, [INFO] [stdout] 1408 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1460:12 [INFO] [stdout] | [INFO] [stdout] 1454 | let (sender, receiver) = mpsc::sync_channel(1); // TODO validate: bound [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1455 | let (r, w) = pipe()?; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1456 | let reader = Arc::new(Mutex::new((r.into(), receiver))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1457 | let writer = (Arc::new(Mutex::new(w.into())), sender); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1460 | Ok(ExternalPrinter { [INFO] [stdout] | ____________^ [INFO] [stdout] 1461 | | writer, [INFO] [stdout] 1462 | | raw_mode: self.raw_mode.clone(), [INFO] [stdout] 1463 | | tty_out: self.tty_out, [INFO] [stdout] 1464 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustyline` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:624:12 [INFO] [stdout] | [INFO] [stdout] 615 | pub fn with_history(config: Config, history: I) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 625 | | term, [INFO] [stdout] 626 | | buffer: None, [INFO] [stdout] 627 | | history, [INFO] [stdout] ... | [INFO] [stdout] 631 | | custom_bindings: Bindings::new(), [INFO] [stdout] 632 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:866:55 [INFO] [stdout] | [INFO] [stdout] 862 | key_seq: E, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 863 | handler: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 866 | .insert(Event::normalize(key_seq.into()), handler.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:735:23 [INFO] [stdout] | [INFO] [stdout] 735 | .map(|pr| pr.lock().unwrap().0.as_raw_fd()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1339:12 [INFO] [stdout] | [INFO] [stdout] 1309 | let tty = OpenOptions::new().read(true).write(true).open("/dev/tty"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1310 | if let Ok(tty) = tty { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1339 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1340 | | unsupported, [INFO] [stdout] 1341 | | tty_in, [INFO] [stdout] 1342 | | is_in_a_tty, [INFO] [stdout] ... | [INFO] [stdout] 1354 | | enable_signals, [INFO] [stdout] 1355 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1400:12 [INFO] [stdout] | [INFO] [stdout] 1400 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 1401 | | PosixMode { [INFO] [stdout] 1402 | | termios: original_mode, [INFO] [stdout] 1403 | | tty_in: self.tty_in, [INFO] [stdout] ... | [INFO] [stdout] 1407 | | key_map, [INFO] [stdout] 1408 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1460:12 [INFO] [stdout] | [INFO] [stdout] 1454 | let (sender, receiver) = mpsc::sync_channel(1); // TODO validate: bound [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1455 | let (r, w) = pipe()?; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1456 | let reader = Arc::new(Mutex::new((r.into(), receiver))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1457 | let writer = (Arc::new(Mutex::new(w.into())), sender); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1460 | Ok(ExternalPrinter { [INFO] [stdout] | ____________^ [INFO] [stdout] 1461 | | writer, [INFO] [stdout] 1462 | | raw_mode: self.raw_mode.clone(), [INFO] [stdout] 1463 | | tty_out: self.tty_out, [INFO] [stdout] 1464 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustyline` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "c408797f8b7a9da38e8793db0a90936edd1e42bea83217704dd699e83d226499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c408797f8b7a9da38e8793db0a90936edd1e42bea83217704dd699e83d226499", kill_on_drop: false }` [INFO] [stdout] c408797f8b7a9da38e8793db0a90936edd1e42bea83217704dd699e83d226499