[INFO] fetching crate rustycopier 0.3.0... [INFO] checking rustycopier-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustycopier 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rustycopier 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustycopier 0.3.0 [INFO] finished tweaking crates.io crate rustycopier 0.3.0 [INFO] tweaked toml for crates.io crate rustycopier 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate rustycopier 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 23df0cc43e0c4cc1ed9a90a5c50613262dc14a7a415887bdfb92a196165b9fd7 [INFO] running `Command { std: "docker" "start" "-a" "23df0cc43e0c4cc1ed9a90a5c50613262dc14a7a415887bdfb92a196165b9fd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "23df0cc43e0c4cc1ed9a90a5c50613262dc14a7a415887bdfb92a196165b9fd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23df0cc43e0c4cc1ed9a90a5c50613262dc14a7a415887bdfb92a196165b9fd7", kill_on_drop: false }` [INFO] [stdout] 23df0cc43e0c4cc1ed9a90a5c50613262dc14a7a415887bdfb92a196165b9fd7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a47797ee1b9d76dd089fdd7fb8c8c51b5c0fbf489ab988fbfc3880da5fc6cbec [INFO] running `Command { std: "docker" "start" "-a" "a47797ee1b9d76dd089fdd7fb8c8c51b5c0fbf489ab988fbfc3880da5fc6cbec", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling rustix v0.38.11 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Compiling anstyle-parse v0.2.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Compiling anstyle-query v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling anstream v0.5.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling clap_lex v0.5.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Compiling clap_builder v4.4.2 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling portable-atomic v1.4.3 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling roff v0.2.1 [INFO] [stderr] Checking predicates v3.0.3 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking indicatif v0.17.6 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking bstr v1.6.2 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking globset v0.4.13 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking ignore v0.4.20 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking assert_fs v1.0.13 [INFO] [stderr] Compiling clap v4.4.2 [INFO] [stderr] Compiling clap_mangen v0.2.13 [INFO] [stderr] Compiling rustycopier v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/copier/file_copy.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 18 | let source_file: File = File::open(&source_file_path) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | let target_file = File::create(&target_file_path) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | source_file_path, [INFO] [stdout] 26 | | source_file, [INFO] [stdout] 27 | | target_file, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/copier_pool/mod.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 29 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut workers = Vec::with_capacity(worker_number); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let shared_stdout = Arc::new(Mutex::new(stdout())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/copier_pool/worker.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 20 | receiver: Arc>>>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | shared_stdout: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut progress_bar = CustomProgressBar::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut job_queue = LinkedList::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | load_jobs_thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_counter/progress_bar.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 50 | stout_mutex: Arc>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | progress_bar: ProgressBarDrawer::progress_bar( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 58 | | 0, [INFO] [stdout] 59 | | stdout_position + progress_bar_position * 2, [INFO] [stdout] 60 | | stdout_position + total_of_progress_bar * 2, [INFO] [stdout] 61 | | stout_mutex, [INFO] [stdout] 62 | | is_logging_active, [INFO] [stdout] 63 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustycopier` (bin "rustycopier") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a47797ee1b9d76dd089fdd7fb8c8c51b5c0fbf489ab988fbfc3880da5fc6cbec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a47797ee1b9d76dd089fdd7fb8c8c51b5c0fbf489ab988fbfc3880da5fc6cbec", kill_on_drop: false }` [INFO] [stdout] a47797ee1b9d76dd089fdd7fb8c8c51b5c0fbf489ab988fbfc3880da5fc6cbec