[INFO] fetching crate rusty_junctions 0.1.0... [INFO] checking rusty_junctions-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rusty_junctions 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rusty_junctions 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rusty_junctions 0.1.0 [INFO] finished tweaking crates.io crate rusty_junctions 0.1.0 [INFO] tweaked toml for crates.io crate rusty_junctions 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4a008ca9d429e9f8f1ceede48f2ed598b7a946db964d44b03fac48b4bf51bc51 [INFO] running `Command { std: "docker" "start" "-a" "4a008ca9d429e9f8f1ceede48f2ed598b7a946db964d44b03fac48b4bf51bc51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4a008ca9d429e9f8f1ceede48f2ed598b7a946db964d44b03fac48b4bf51bc51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a008ca9d429e9f8f1ceede48f2ed598b7a946db964d44b03fac48b4bf51bc51", kill_on_drop: false }` [INFO] [stdout] 4a008ca9d429e9f8f1ceede48f2ed598b7a946db964d44b03fac48b4bf51bc51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f19fb6761de413be682a0f40c58f8dc170d7ce3a95f01dbdcb466cd8feaa9c9 [INFO] running `Command { std: "docker" "start" "-a" "8f19fb6761de413be682a0f40c58f8dc170d7ce3a95f01dbdcb466cd8feaa9c9", kill_on_drop: false }` [INFO] [stderr] Checking rusty_junctions v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `contains_items` is never used [INFO] [stdout] --> src/bag.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 18 | / impl Bag [INFO] [stdout] 19 | | where [INFO] [stdout] 20 | | K: Hash + Eq, [INFO] [stdout] | |_________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 56 | pub(crate) fn contains_items(&self, key: &K) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `id` is never used [INFO] [stdout] --> src/channels.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 34 | impl SendChannel { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 35 | /// Return the channel's ID. [INFO] [stdout] 36 | pub(crate) fn id(&self) -> ids::ChannelId { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `id` is never used [INFO] [stdout] --> src/channels.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 125 | impl RecvChannel { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 126 | /// Return the channel's ID. [INFO] [stdout] 127 | pub(crate) fn id(&self) -> ids::ChannelId { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `id` is never used [INFO] [stdout] --> src/channels.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 236 | impl BidirChannel { [INFO] [stdout] | ----------------------------- method in this implementation [INFO] [stdout] 237 | /// Return the channel's ID. [INFO] [stdout] 238 | pub(crate) fn id(&self) -> ids::ChannelId { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `insert_multiple` and `peek_first` are never used [INFO] [stdout] --> src/inverted_index.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 16 | / impl InvertedIndex [INFO] [stdout] 17 | | where [INFO] [stdout] 18 | | K: Hash + Eq, [INFO] [stdout] | |_________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 49 | pub(crate) fn insert_multiple(&mut self, key: K, values: impl IntoIterator) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub(crate) fn peek_first(&self, key: &K) -> Option<&V> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `junction_id` is never read [INFO] [stdout] --> src/patterns.rs:768:9 [INFO] [stdout] | [INFO] [stdout] 767 | pub struct SendPartialPattern { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 768 | junction_id: ids::JunctionId, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/types.rs:222:23 [INFO] [stdout] | [INFO] [stdout] 221 | impl ChannelId { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 222 | pub(crate) fn new(value: usize) -> ChannelId { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channels.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn send(&self, value: T) -> Result<(), SendError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.sender.send(Packet::Message { [INFO] [stdout] | __________________________^ [INFO] [stdout] 70 | | channel_id: self.id, [INFO] [stdout] 71 | | msg: Message::new(value), [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:65:39 [INFO] [stdout] | [INFO] [stdout] 61 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | sender: Sender, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | receiver: Receiver, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ) -> ControllerHandle { [INFO] [stdout] 65 | ControllerHandle::new(sender, thread::spawn(move || self.handle_packets(receiver))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn transform_send(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Box::new(move |arg: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 20 | | f(*arg.downcast::().unwrap()); [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn transform_recv(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Box::new(move |return_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 31 | | let return_sender = *return_sender.downcast::>().unwrap(); [INFO] [stdout] 32 | | [INFO] [stdout] 33 | | return_sender.send(f()).unwrap(); [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) fn transform_bidir(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Box::new(move |arg_and_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 45 | | let (arg, return_sender) = *arg_and_sender.downcast::<(T, Sender)>().unwrap(); [INFO] [stdout] 46 | | [INFO] [stdout] 47 | | return_sender.send(f(arg)).unwrap(); [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn transform_send(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Box::new(move |arg_1: Message, arg_2: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 64 | | f( [INFO] [stdout] 65 | | *arg_1.downcast::().unwrap(), [INFO] [stdout] 66 | | *arg_2.downcast::().unwrap(), [INFO] [stdout] 67 | | ); [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 72 | pub(crate) fn transform_recv(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Box::new(move |arg: Message, return_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 79 | | let return_sender = *return_sender.downcast::>().unwrap(); [INFO] [stdout] 80 | | let arg = *arg.downcast::().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 87 | pub(crate) fn transform_bidir(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Box::new(move |arg_1: Message, arg_2_and_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 95 | | let arg_1 = *arg_1.downcast::().unwrap(); [INFO] [stdout] 96 | | let (arg_2, return_sender) = *arg_2_and_sender.downcast::<(U, Sender)>().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 108 | pub(crate) fn transform_send(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Box::new(move |arg_1: Message, arg_2: Message, arg_3: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 116 | | f( [INFO] [stdout] 117 | | *arg_1.downcast::().unwrap(), [INFO] [stdout] 118 | | *arg_2.downcast::().unwrap(), [INFO] [stdout] 119 | | *arg_3.downcast::().unwrap(), [INFO] [stdout] 120 | | ); [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 125 | pub(crate) fn transform_recv(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / move |arg_1: Message, arg_2: Message, return_sender: Message| { [INFO] [stdout] 134 | | let return_sender = *return_sender.downcast::>().unwrap(); [INFO] [stdout] 135 | | let arg_1 = *arg_1.downcast::().unwrap(); [INFO] [stdout] 136 | | let arg_2 = *arg_2.downcast::().unwrap(); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | return_sender.send(f(arg_1, arg_2)).unwrap(); [INFO] [stdout] 139 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 144 | pub(crate) fn transform_bidir(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | / move |arg_1: Message, arg_2: Message, arg_3_and_sender: Message| { [INFO] [stdout] 154 | | let arg_1 = *arg_1.downcast::().unwrap(); [INFO] [stdout] 155 | | let arg_2 = *arg_2.downcast::().unwrap(); [INFO] [stdout] 156 | | let (arg_3, return_sender) = [INFO] [stdout] ... | [INFO] [stdout] 159 | | return_sender.send(f(arg_1, arg_2, arg_3)).unwrap(); [INFO] [stdout] 160 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/junction.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 36 | let (sender, receiver) = channel::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let controller = Controller::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | controller_handle: Some(controller.start(sender.clone(), receiver)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn new(raw_value: T) -> Message [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Message(Box::new(raw_value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:87:36 [INFO] [stdout] | [INFO] [stdout] 84 | pub(crate) fn new(sender: Sender, handle: JoinHandle<()>) -> ControllerHandle { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | control_thread_handle: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_junctions` (lib) due to 15 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `id` is never used [INFO] [stdout] --> src/channels.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 34 | impl SendChannel { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 35 | /// Return the channel's ID. [INFO] [stdout] 36 | pub(crate) fn id(&self) -> ids::ChannelId { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `id` is never used [INFO] [stdout] --> src/channels.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 125 | impl RecvChannel { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 126 | /// Return the channel's ID. [INFO] [stdout] 127 | pub(crate) fn id(&self) -> ids::ChannelId { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `id` is never used [INFO] [stdout] --> src/channels.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 236 | impl BidirChannel { [INFO] [stdout] | ----------------------------- method in this implementation [INFO] [stdout] 237 | /// Return the channel's ID. [INFO] [stdout] 238 | pub(crate) fn id(&self) -> ids::ChannelId { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `junction_id` is never read [INFO] [stdout] --> src/patterns.rs:768:9 [INFO] [stdout] | [INFO] [stdout] 767 | pub struct SendPartialPattern { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 768 | junction_id: ids::JunctionId, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/types.rs:222:23 [INFO] [stdout] | [INFO] [stdout] 221 | impl ChannelId { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 222 | pub(crate) fn new(value: usize) -> ChannelId { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channels.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn send(&self, value: T) -> Result<(), SendError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.sender.send(Packet::Message { [INFO] [stdout] | __________________________^ [INFO] [stdout] 70 | | channel_id: self.id, [INFO] [stdout] 71 | | msg: Message::new(value), [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:65:39 [INFO] [stdout] | [INFO] [stdout] 61 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | sender: Sender, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | receiver: Receiver, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ) -> ControllerHandle { [INFO] [stdout] 65 | ControllerHandle::new(sender, thread::spawn(move || self.handle_packets(receiver))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn transform_send(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Box::new(move |arg: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 20 | | f(*arg.downcast::().unwrap()); [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn transform_recv(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Box::new(move |return_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 31 | | let return_sender = *return_sender.downcast::>().unwrap(); [INFO] [stdout] 32 | | [INFO] [stdout] 33 | | return_sender.send(f()).unwrap(); [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) fn transform_bidir(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Box::new(move |arg_and_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 45 | | let (arg, return_sender) = *arg_and_sender.downcast::<(T, Sender)>().unwrap(); [INFO] [stdout] 46 | | [INFO] [stdout] 47 | | return_sender.send(f(arg)).unwrap(); [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn transform_send(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Box::new(move |arg_1: Message, arg_2: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 64 | | f( [INFO] [stdout] 65 | | *arg_1.downcast::().unwrap(), [INFO] [stdout] 66 | | *arg_2.downcast::().unwrap(), [INFO] [stdout] 67 | | ); [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 72 | pub(crate) fn transform_recv(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Box::new(move |arg: Message, return_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 79 | | let return_sender = *return_sender.downcast::>().unwrap(); [INFO] [stdout] 80 | | let arg = *arg.downcast::().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 87 | pub(crate) fn transform_bidir(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Box::new(move |arg_1: Message, arg_2_and_sender: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 95 | | let arg_1 = *arg_1.downcast::().unwrap(); [INFO] [stdout] 96 | | let (arg_2, return_sender) = *arg_2_and_sender.downcast::<(U, Sender)>().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 108 | pub(crate) fn transform_send(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Box::new(move |arg_1: Message, arg_2: Message, arg_3: Message| { [INFO] [stdout] | __________________^ [INFO] [stdout] 116 | | f( [INFO] [stdout] 117 | | *arg_1.downcast::().unwrap(), [INFO] [stdout] 118 | | *arg_2.downcast::().unwrap(), [INFO] [stdout] 119 | | *arg_3.downcast::().unwrap(), [INFO] [stdout] 120 | | ); [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 125 | pub(crate) fn transform_recv(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / move |arg_1: Message, arg_2: Message, return_sender: Message| { [INFO] [stdout] 134 | | let return_sender = *return_sender.downcast::>().unwrap(); [INFO] [stdout] 135 | | let arg_1 = *arg_1.downcast::().unwrap(); [INFO] [stdout] 136 | | let arg_2 = *arg_2.downcast::().unwrap(); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | return_sender.send(f(arg_1, arg_2)).unwrap(); [INFO] [stdout] 139 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function_transforms.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 144 | pub(crate) fn transform_bidir(f: F) -> Box [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | / move |arg_1: Message, arg_2: Message, arg_3_and_sender: Message| { [INFO] [stdout] 154 | | let arg_1 = *arg_1.downcast::().unwrap(); [INFO] [stdout] 155 | | let arg_2 = *arg_2.downcast::().unwrap(); [INFO] [stdout] 156 | | let (arg_3, return_sender) = [INFO] [stdout] ... | [INFO] [stdout] 159 | | return_sender.send(f(arg_1, arg_2, arg_3)).unwrap(); [INFO] [stdout] 160 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/junction.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 36 | let (sender, receiver) = channel::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let controller = Controller::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | controller_handle: Some(controller.start(sender.clone(), receiver)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn new(raw_value: T) -> Message [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Message(Box::new(raw_value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:87:36 [INFO] [stdout] | [INFO] [stdout] 84 | pub(crate) fn new(sender: Sender, handle: JoinHandle<()>) -> ControllerHandle { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | control_thread_handle: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_junctions` (lib test) due to 15 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8f19fb6761de413be682a0f40c58f8dc170d7ce3a95f01dbdcb466cd8feaa9c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f19fb6761de413be682a0f40c58f8dc170d7ce3a95f01dbdcb466cd8feaa9c9", kill_on_drop: false }` [INFO] [stdout] 8f19fb6761de413be682a0f40c58f8dc170d7ce3a95f01dbdcb466cd8feaa9c9