[INFO] fetching crate rusty_crypto 0.1.24... [INFO] checking rusty_crypto-0.1.24 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rusty_crypto 0.1.24 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rusty_crypto 0.1.24 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rusty_crypto 0.1.24 [INFO] finished tweaking crates.io crate rusty_crypto 0.1.24 [INFO] tweaked toml for crates.io crate rusty_crypto 0.1.24 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a93e29cf04397d7e203fc46f5019228fbff278a65f4285f86227b3b1c332b262 [INFO] running `Command { std: "docker" "start" "-a" "a93e29cf04397d7e203fc46f5019228fbff278a65f4285f86227b3b1c332b262", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a93e29cf04397d7e203fc46f5019228fbff278a65f4285f86227b3b1c332b262", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a93e29cf04397d7e203fc46f5019228fbff278a65f4285f86227b3b1c332b262", kill_on_drop: false }` [INFO] [stdout] a93e29cf04397d7e203fc46f5019228fbff278a65f4285f86227b3b1c332b262 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ef759d030ef042e0f08cac9d7462b4455213fdb27d1858ee1cc5c9c502b0636 [INFO] running `Command { std: "docker" "start" "-a" "3ef759d030ef042e0f08cac9d7462b4455213fdb27d1858ee1cc5c9c502b0636", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling pqc_kyber v0.7.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking algebra_kit v0.1.10 [INFO] [stderr] Checking sylvan_number v0.1.5 [INFO] [stderr] Checking matrix_kit v0.1.9 [INFO] [stderr] Checking rusty_crypto v0.1.24 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `lwe::Ciphertext` [INFO] [stdout] --> src/speck.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::{lwe::Ciphertext, padding, utility::PaddedFileStream}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std_impls::ZM` [INFO] [stdout] --> src/secsharing/types.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | use algebra_kit::{algebra::*, std_impls::ZM}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Rng`, `SeedableRng`, and `rngs::StdRng` [INFO] [stdout] --> src/utility.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | use rand::{rngs::StdRng, Rng, SeedableRng}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lwe::enc` [INFO] [stdout] --> src/padding.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | use crate::lwe::enc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::Rng` [INFO] [stdout] --> src/lettuce.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | use rand::Rng; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `slice_flatten` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(slice_flatten)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lwe::Ciphertext` [INFO] [stdout] --> src/speck.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::{lwe::Ciphertext, padding, utility::PaddedFileStream}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std_impls::ZM` [INFO] [stdout] --> src/secsharing/types.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | use algebra_kit::{algebra::*, std_impls::ZM}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Rng`, `SeedableRng`, and `rngs::StdRng` [INFO] [stdout] --> src/utility.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | use rand::{rngs::StdRng, Rng, SeedableRng}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lwe::enc` [INFO] [stdout] --> src/padding.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | use crate::lwe::enc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `slice_flatten` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(slice_flatten)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/speck.rs:208:7 [INFO] [stdout] | [INFO] [stdout] 208 | Err(e) => false [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/speck.rs:214:7 [INFO] [stdout] | [INFO] [stdout] 214 | Ok(t) => (), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/speck.rs:208:7 [INFO] [stdout] | [INFO] [stdout] 208 | Err(e) => false [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/speck.rs:214:7 [INFO] [stdout] | [INFO] [stdout] 214 | Ok(t) => (), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_lwe` is never used [INFO] [stdout] --> src/lwe.rs:258:4 [INFO] [stdout] | [INFO] [stdout] 258 | fn test_lwe() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_conversions` is never used [INFO] [stdout] --> src/lwe.rs:392:4 [INFO] [stdout] | [INFO] [stdout] 392 | fn test_conversions() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_correctness` is never used [INFO] [stdout] --> src/lwe.rs:442:4 [INFO] [stdout] | [INFO] [stdout] 442 | fn test_correctness() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SHARED_SECRET_BYTES` is never used [INFO] [stdout] --> src/lettuce.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const SHARED_SECRET_BYTES: usize = pqc_kyber::KYBER_SSBYTES; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `SharedSecret` is never used [INFO] [stdout] --> src/lettuce.rs:15:6 [INFO] [stdout] | [INFO] [stdout] 15 | type SharedSecret = [u8 ; SHARED_SECRET_BYTES]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `CiphertextKEM` is never used [INFO] [stdout] --> src/lettuce.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | type CiphertextKEM = [u8 ; CIPHERTEXT_KEM_BYTES]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lwe.rs:430:29 [INFO] [stdout] | [INFO] [stdout] 429 | let (sk_mat, pk_mat) = gen_mat::(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | (matrix_rep_to_sk(sk_mat), matrix_rep_to_pk(&pk_mat)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lwe.rs:434:71 [INFO] [stdout] | [INFO] [stdout] 433 | pub fn enc(pk: PublicKey, pt: Plaintext) -> Ciphertext { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | matrix_rep_to_ct(enc_mat::(pk_to_matrix_rep(pk), pt_to_matrix_rep(pt))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_crypto` (lib) due to 3 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `test_lwe` is never used [INFO] [stdout] --> src/lwe.rs:258:4 [INFO] [stdout] | [INFO] [stdout] 258 | fn test_lwe() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_conversions` is never used [INFO] [stdout] --> src/lwe.rs:392:4 [INFO] [stdout] | [INFO] [stdout] 392 | fn test_conversions() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_correctness` is never used [INFO] [stdout] --> src/lwe.rs:442:4 [INFO] [stdout] | [INFO] [stdout] 442 | fn test_correctness() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SHARED_SECRET_BYTES` is never used [INFO] [stdout] --> src/lettuce.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const SHARED_SECRET_BYTES: usize = pqc_kyber::KYBER_SSBYTES; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `SharedSecret` is never used [INFO] [stdout] --> src/lettuce.rs:15:6 [INFO] [stdout] | [INFO] [stdout] 15 | type SharedSecret = [u8 ; SHARED_SECRET_BYTES]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `CiphertextKEM` is never used [INFO] [stdout] --> src/lettuce.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | type CiphertextKEM = [u8 ; CIPHERTEXT_KEM_BYTES]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lwe.rs:430:29 [INFO] [stdout] | [INFO] [stdout] 429 | let (sk_mat, pk_mat) = gen_mat::(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | (matrix_rep_to_sk(sk_mat), matrix_rep_to_pk(&pk_mat)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lwe.rs:434:71 [INFO] [stdout] | [INFO] [stdout] 433 | pub fn enc(pk: PublicKey, pt: Plaintext) -> Ciphertext { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | matrix_rep_to_ct(enc_mat::(pk_to_matrix_rep(pk), pt_to_matrix_rep(pt))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_crypto` (lib test) due to 3 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3ef759d030ef042e0f08cac9d7462b4455213fdb27d1858ee1cc5c9c502b0636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ef759d030ef042e0f08cac9d7462b4455213fdb27d1858ee1cc5c9c502b0636", kill_on_drop: false }` [INFO] [stdout] 3ef759d030ef042e0f08cac9d7462b4455213fdb27d1858ee1cc5c9c502b0636