[INFO] fetching crate rusty-source-map 0.2.2... [INFO] checking rusty-source-map-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rusty-source-map 0.2.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rusty-source-map 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rusty-source-map 0.2.2 [INFO] finished tweaking crates.io crate rusty-source-map 0.2.2 [INFO] tweaked toml for crates.io crate rusty-source-map 0.2.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rusty-source-map 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80b60a71c31771d1364d00810e0a836bfa5914d3978d631c330d0113924ea7ac [INFO] running `Command { std: "docker" "start" "-a" "80b60a71c31771d1364d00810e0a836bfa5914d3978d631c330d0113924ea7ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80b60a71c31771d1364d00810e0a836bfa5914d3978d631c330d0113924ea7ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80b60a71c31771d1364d00810e0a836bfa5914d3978d631c330d0113924ea7ac", kill_on_drop: false }` [INFO] [stdout] 80b60a71c31771d1364d00810e0a836bfa5914d3978d631c330d0113924ea7ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71738053ecf7af8213db424a14ac870a6d52bf7ff3d43c6af54b6b1443b3a4f4 [INFO] running `Command { std: "docker" "start" "-a" "71738053ecf7af8213db424a14ac870a6d52bf7ff3d43c6af54b6b1443b3a4f4", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling serde_json v1.0.71 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking vlq v0.5.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking source-map-mappings v0.5.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking rusty-source-map v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 125 | let source_map = serde_json::from_str::(source_map_raw).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | BasicConsumer { [INFO] [stdout] 127 | source_map: source_map.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn from_source_map_json(source_map: SourceMapJson, source_map_url: Option<&str>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | BasicConsumer { [INFO] [stdout] 153 | source_map: source_map.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:510:25 [INFO] [stdout] | [INFO] [stdout] 495 | pub fn from_source_map_json(source_map: SourceMapJson, source_map_url: Option<&str>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | let last_offset = Arc::new(Mutex::new(Position { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | source_map: source_map.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:531:23 [INFO] [stdout] | [INFO] [stdout] 495 | pub fn from_source_map_json(source_map: SourceMapJson, source_map_url: Option<&str>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | let last_offset = Arc::new(Mutex::new(Position { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 531 | sections: Rc::new(RefCell::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 532 | | source_map [INFO] [stdout] 533 | | .sections [INFO] [stdout] 534 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 570 | | .collect(), [INFO] [stdout] 571 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:563:43 [INFO] [stdout] | [INFO] [stdout] 537 | let last_offset = last_offset; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | let mut last_offset = last_offset.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 563 | consumer: BasicConsumer::from_source_map_json( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 564 | | *section.map.clone(), [INFO] [stdout] 565 | | source_map_url, [INFO] [stdout] 566 | | ), [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:821:9 [INFO] [stdout] | [INFO] [stdout] 820 | fn each_mapping(&mut self, f: impl Fn(&source_map_mappings::Mapping), ord: IterOrd) { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 821 | / (*self.sections) [INFO] [stdout] 822 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:170:14 [INFO] [stdout] | [INFO] [stdout] 169 | fn create_safe_handler(cb: Box) -> Box String + Sync> { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | Box::new(move |input: String| -> String { [INFO] [stdout] | ______________^ [INFO] [stdout] 171 | | let t = get_url_type(input.as_str()); [INFO] [stdout] 172 | | let base = build_safe_base(input.as_str()); [INFO] [stdout] 173 | | let urlx = Url::parse(base.as_str()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 185 | | } [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-source-map` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 125 | let source_map = serde_json::from_str::(source_map_raw).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | BasicConsumer { [INFO] [stdout] 127 | source_map: source_map.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn from_source_map_json(source_map: SourceMapJson, source_map_url: Option<&str>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | BasicConsumer { [INFO] [stdout] 153 | source_map: source_map.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:510:25 [INFO] [stdout] | [INFO] [stdout] 495 | pub fn from_source_map_json(source_map: SourceMapJson, source_map_url: Option<&str>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | let last_offset = Arc::new(Mutex::new(Position { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | source_map: source_map.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:531:23 [INFO] [stdout] | [INFO] [stdout] 495 | pub fn from_source_map_json(source_map: SourceMapJson, source_map_url: Option<&str>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | let last_offset = Arc::new(Mutex::new(Position { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 531 | sections: Rc::new(RefCell::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 532 | | source_map [INFO] [stdout] 533 | | .sections [INFO] [stdout] 534 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 570 | | .collect(), [INFO] [stdout] 571 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:563:43 [INFO] [stdout] | [INFO] [stdout] 537 | let last_offset = last_offset; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | let mut last_offset = last_offset.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 563 | consumer: BasicConsumer::from_source_map_json( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 564 | | *section.map.clone(), [INFO] [stdout] 565 | | source_map_url, [INFO] [stdout] 566 | | ), [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer.rs:821:9 [INFO] [stdout] | [INFO] [stdout] 820 | fn each_mapping(&mut self, f: impl Fn(&source_map_mappings::Mapping), ord: IterOrd) { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 821 | / (*self.sections) [INFO] [stdout] 822 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:170:14 [INFO] [stdout] | [INFO] [stdout] 169 | fn create_safe_handler(cb: Box) -> Box String + Sync> { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | Box::new(move |input: String| -> String { [INFO] [stdout] | ______________^ [INFO] [stdout] 171 | | let t = get_url_type(input.as_str()); [INFO] [stdout] 172 | | let base = build_safe_base(input.as_str()); [INFO] [stdout] 173 | | let urlx = Url::parse(base.as_str()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 185 | | } [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-source-map` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "71738053ecf7af8213db424a14ac870a6d52bf7ff3d43c6af54b6b1443b3a4f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71738053ecf7af8213db424a14ac870a6d52bf7ff3d43c6af54b6b1443b3a4f4", kill_on_drop: false }` [INFO] [stdout] 71738053ecf7af8213db424a14ac870a6d52bf7ff3d43c6af54b6b1443b3a4f4